From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48C4DC10F1A for ; Tue, 7 May 2024 19:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F+LAXoaPd4yFLvjzUK+REeWgSddnRtYIdOZJmYfqF8w=; b=gzFhynlAtUKyYf 8i/mE3rfIXukaJ/VgMDfer3Qg6hlqffBuixb/taLBBUM5S8hVPvBznq7IWt5h7OWh/9AX52lDW8no d9WZw1nm4Z0/HDFTzapQAS5kx3y2W0wdponJesh9nHqF19rT7jrtrtj2+ZKjZ6IvDgFuCtn5Qu5oS tLuYjEAyYBY3LQm8Fqmt/yL9JDxppd9DyxF0gY8JMQ9EtMWT8Jj67DNvUT5rWD0RXkkkSqJknCI9l /jSJI26eNuk1UvYKsbfpWW4oThVA7TJrcLMkSFt5bDWiTgOKUEZIB8J/urwXKNMNHUqkNHMpv1l0m wIC2AoTE0eQ6qk5MEtCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4QE1-0000000CVxx-47R4; Tue, 07 May 2024 19:11:41 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4QDy-0000000CVxI-1aJg for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 19:11:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 073D9CE13CD; Tue, 7 May 2024 19:11:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F6EC2BBFC; Tue, 7 May 2024 19:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715109095; bh=0QWF8zaj0qi8QUphv7YChHYzkRCmy97vi1jsbdB5UkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uj6LsvUParyf07o2w6RO/eH3ICzXHMjmesw+8sHjWhcxLq3uBKJnDHMd8qAL6Fu7p F4t214j2bobOmaiBd05h7lIEUz3MDEzwXTUVphAqov6KEY94Sq54M2HJKLcua82r1D FGteBlJu3uDLGTiSNtX/8d77s+DzWR1HjabFZH1DcS49usYPdUnZYHJqtVq6RFZmUW qTNuPmJCkHsis4m4er16i0OH5kMxu+Es25aqJQO4nCcI9Y7txdBv/5BHjl427fVBS3 g32z5tKj6Lo2WyClZvekeaewOIixgWHlr6ei3CalHj4kijMaFoV47VBtmh8SSPKT/1 2SzjSuOfruJtA== Date: Tue, 7 May 2024 14:11:33 -0500 From: Rob Herring To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Dong Aisheng , Jacky Bai , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-gpio@vger.kernel.org, Peng Fan Subject: Re: [PATCH v4 1/3] dt-bindings: firmware: arm,scmi: Add properties for i.MX95 Pinctrl OEM extensions Message-ID: <20240507191133.GA904879-robh@kernel.org> References: <20240505-pinctrl-scmi-oem-v3-v4-0-7c99f989e9ba@nxp.com> <20240505-pinctrl-scmi-oem-v3-v4-1-7c99f989e9ba@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240505-pinctrl-scmi-oem-v3-v4-1-7c99f989e9ba@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_121138_829284_10651314 X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 05, 2024 at 11:47:17AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > i.MX95 Pinctrl is managed by System Control Management Interface(SCMI) > firmware using OEM extensions. No functions, no groups are provided by > the firmware. To reuse generic properties, add the binding to enable > pinmux, slew-rate, bias-pull-up and etc, under a subnode of '-pins'. > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/firmware/arm,scmi.yaml | 9 ++++-- > .../bindings/firmware/nxp,imx95-scmi-pinctrl.yaml | 37 ++++++++++++++++++++++ > 2 files changed, 43 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 7de2c29606e5..bd4dfd7a85cd 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -262,9 +262,12 @@ properties: > patternProperties: > '-pins$': > type: object > - allOf: > - - $ref: /schemas/pinctrl/pincfg-node.yaml# > - - $ref: /schemas/pinctrl/pinmux-node.yaml# > + anyOf: > + - $ref: /schemas/firmware/nxp,imx95-scmi-pinctrl.yaml > + - allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml# > + - $ref: /schemas/pinctrl/pinmux-node.yaml# > + > unevaluatedProperties: false > > description: > diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml > new file mode 100644 > index 000000000000..1a694881f193 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/nxp,imx95-scmi-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX System Control and Management Interface (SCMI) Pinctrl Protocol > + > +maintainers: > + - Peng Fan > + > +patternProperties: > + 'grp[0-9a-f]$': > + type: object > + unevaluatedProperties: false > + > + properties: > + pinmux: > + description: | > + An integer array for representing pinmux configurations of > + a device. Each integer has the format, pinid[31:21], mux[20:16], > + daisy_value[15:12], daisy_valid[11:11], daisy_id[10:0]. I would format this with one field per line. Otherwise, Reviewed-by: Rob Herring > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + drive-strength: > + enum: [ 0, 1, 3, 7, 15, 31, 63 ] > + > + slew-rate: > + enum: [2, 3] > + > + input-schmitt-enable: true > + drive-open-drain: true > + bias-pull-up: true > + bias-pull-down: true > + > +additionalProperties: true > > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel