From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 025BAC10F1A for ; Tue, 7 May 2024 21:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6IvM9qBVylIpzAOWymz5ELaFZVmnoIOoZnbe5k9icso=; b=BBMWI9oO+wexrM A6Rf6gTTTdp5aHiHvSCpM+cyXSSg6hBB4W8e3ul0sXl9hzmLJcTPPFdM0BZw3kUi2xKtlkO2hke4W T72mPnJz60XWQ1btxR2lXsWBcpVN5OgLrW+Luvu9eXlP/1CwKZVGnv75gVIS9g3oF/Ivenz6ip34y f/V+zI1leUe2z+o6Haw8AbehXAH0XPVEt4iLJb8df7XHIV0g2ggJLZVK6SlaRCrgZ1OM1PGTWqX/o RKdDgXec1QxqFOBz4M6tcp+CWG5zBIF1vZ7zgwK+es2wXY0ZpmbxsFlDIzy3TZtK7ZxysSOruSlUg JbCflFdYo3wdJC+XQzhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4S5n-0000000CrUn-3L1n; Tue, 07 May 2024 21:11:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4S5k-0000000CrSb-0SUM for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 21:11:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7295F619D7; Tue, 7 May 2024 21:11:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA90C2BBFC; Tue, 7 May 2024 21:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715116274; bh=XdUodymdRB65eR7Rdr7ZYq48VpisLuK+dc2m5P9E1jE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DPoixQPzNU6IyEpl+1YPBIPcbPSW507umWTlrI87a+x4ukswKKUhIL4Q0tRb2K7wO IFP7pGSsVDKfjN37CWzJquawoaZWDAv85aLKLe7xLaQd10BP2V4RNp1nOM6NaqiF/o r4dQhUZXgOSCQubJAGqRHk0H0jq7+iajzL/B3Xd1zbjZztZz0VMKknBZDgIF1W5qnW I5wDyluT2wYzMzLXt5wZx/gx8OycdII7C2YTyFnc3ElG1WwAHQLqizRTu2BQmSzgqa H7gDOx4K9VHZunRE+ELBhHsitZ1CMcbSW/c5dBS5X+fJl0RiJMtgzWwXjqxhmO0Ksr H4n86KutFUOUw== Date: Tue, 7 May 2024 16:11:12 -0500 From: Rob Herring To: Neha Malcom Francis Cc: conor+dt@kernel.org, krzk+dt@kernel.org, kristo@kernel.org, vigneshr@ti.com, nm@ti.com, broonie@kernel.org, lgirdwood@gmail.com, marten.lindahl@axis.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, u-kumar1@ti.com Subject: Re: [PATCH 1/5] regulator: dt-bindings: Unify compatible Message-ID: <20240507211112.GA1053164-robh@kernel.org> References: <20240507122158.3739291-1-n-francis@ti.com> <20240507122158.3739291-2-n-francis@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240507122158.3739291-2-n-francis@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141116_210167_49AF6032 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2024 at 05:51:54PM +0530, Neha Malcom Francis wrote: > TPS62870/1/2/3 devices have different output currents (6A/9A/12A/15A) of > the TPS6287x family. The I2C addresses are the same between them. There > is no need for different compatibles for each for these devices so drop > them and add a unified "ti,tps6287x" compatible. And s/w will never need to know what the max output current is? Same i2c address has no bearing. That's usually not even fixed for 1 device. > > Signed-off-by: Neha Malcom Francis > --- > .../devicetree/bindings/regulator/ti,tps62870.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml > index 386989544dac..2998773db990 100644 > --- a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml > +++ b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml > @@ -15,10 +15,7 @@ allOf: > properties: > compatible: > enum: > - - ti,tps62870 > - - ti,tps62871 > - - ti,tps62872 > - - ti,tps62873 > + - ti,tps6287x You just broke the existing users. Wildcards in compatible names are generally discouraged. Maybe if this was a new binding and had sufficient justification why we don't need to distinguish parts, but this is an ABI and we're stuck with them. If you are doing this to support more versions, then feel free to use an existing string. It's just a unique identifier. You have 4 to choose from. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel