From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E6ABC25B10 for ; Fri, 10 May 2024 08:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TfrO1eQ1SwlA1uXXwYObDC+3MIoI21FEftHOFrgVqGk=; b=QJvr8c7cgqqBzA dc3D2pLMMHu3FdCDx4dZ1Fxx38Po5wJQ8HG61IS42V22+n67rsfrx3lxKl58XDodbb0IIUtNWIlnQ Akffb2fR69dVwPb1+3B/gJGQDMH78CBlZzXHlX+9A4cnpJxCklJZY5i74Yxwtugp1DTkEb08duyX+ ICX5atoN052X7y2t4A1b+4APEmk9jUfMoiKiYjDtFzDMTpgLY3NfQj6IqZ2EzcyPsPczuRti1lIzR RYvsUgWDZAiX/BEJO0U1dZjyU6PcXeRuo5O2jkSUGarO42h1qzMah1aITL6DfJei09m9qv5zr/SvS nrm55EyIrrUfB6T14Zkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5LRK-00000004Tly-0ein; Fri, 10 May 2024 08:17:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5LRH-00000004TlK-1CXg for linux-arm-kernel@lists.infradead.org; Fri, 10 May 2024 08:17:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 31C9561E56; Fri, 10 May 2024 08:17:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88BE0C113CC; Fri, 10 May 2024 08:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715329027; bh=3ZDwHzsfGWUbx3aEP4Hd/f3NEWbuvIEMGcIBveCseHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxmllSwk1PKimxkjWGI+xVbv2XdXeALb32vl6iCT8ro/0zNi7eAu575eXmDq15uf3 FB/F1ZYzWhJxFUSkxMdlbK+4aGftv22e+1ynyu6fr3bTfI6/LwrQ3nGL12fVdxubaa a0xZ+cLyNchKaiZJISJsDlJOpTWCAEfBSzDlFaTY= Date: Fri, 10 May 2024 09:17:05 +0100 From: Greg KH To: Jay Buddhabhatti Cc: michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 RESEND] drivers: soc: xilinx: check return status of get_api_version() Message-ID: <2024051034-surfacing-length-eae9@gregkh> References: <20240509043629.21506-1-jay.buddhabhatti@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240509043629.21506-1-jay.buddhabhatti@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_011711_466465_90549593 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 08, 2024 at 09:36:29PM -0700, Jay Buddhabhatti wrote: > Currently return status is not getting checked for get_api_version > and because of that for x86 arch we are getting below smatch error. > > CC drivers/soc/xilinx/zynqmp_power.o > drivers/soc/xilinx/zynqmp_power.c: In function 'zynqmp_pm_probe': > drivers/soc/xilinx/zynqmp_power.c:295:12: warning: 'pm_api_version' is > used uninitialized [-Wuninitialized] > 295 | if (pm_api_version < ZYNQMP_PM_VERSION) > | ^ > CHECK drivers/soc/xilinx/zynqmp_power.c > drivers/soc/xilinx/zynqmp_power.c:295 zynqmp_pm_probe() error: > uninitialized symbol 'pm_api_version'. > > So, check return status of pm_get_api_version and return error in case > of failure to avoid checking uninitialized pm_api_version variable. > > Fixes: b9b3a8be28b3 ("firmware: xilinx: Remove eemi ops for get_api_version") > Signed-off-by: Jay Buddhabhatti > --- > V1: https://lore.kernel.org/lkml/20240424063118.23200-1-jay.buddhabhatti@amd.com/ > V1->V2: Removed AMD copyright > --- Why is this a RESEND? Also my bot had issues: -------- Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel