From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECD3FC10F1A for ; Sun, 12 May 2024 08:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N385xwgPBajYdNK3XriwH2Pnlg6lDn+EUtCTHzuo8N4=; b=3m8lN9ktXVF8lY WkaBQboDSIdNNo1r0hTJpwwNMeRU6dF9sEUIIZEKg2AYLAYhYxGrYbGBY6m40vCp9NXPiB0suB2YO R0F3UC/YpwNqCSpSGJf2t8VITDM4/JEAWgaqrm17PX9UoxJo3c0jqLr+Qy7IqJv2rwWa6teuloPcl kW8aDDfLBsxXxuwYbHYr0Bg3bLNc5jWhtLt9qTmtQfoRqYUeKTYR8qqRdhTPKflHQkecbkZeA7Rsu fWx7wVPZYFjWDF10hUG1/Uyu6E+26M/BO+qlXmzgMnul8MUcPqMiW/kSZVcx8njug6QUe0Ona08BY 5haFTtdC0dsRpPVfwDag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s64g5-00000009aWN-451A; Sun, 12 May 2024 08:35:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s64g3-00000009aVi-0cf9 for linux-arm-kernel@lists.infradead.org; Sun, 12 May 2024 08:35:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E9FECCE0A29; Sun, 12 May 2024 08:35:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36A72C116B1; Sun, 12 May 2024 08:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715502924; bh=kXs5Vk2uM7TF2KGpm3iKNAHLpYpFzJyyIakxcjC+ewE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCxVXXfliol5EzkqZ307uFnJDXrNPhRi9Ta4wEvxHKbAbzOorKrUoMmuTSZyYW5Ca C0hS53eqzqve6hpg8aqbJ+jKAZ+5y1G6Vy6XzA243VIDssTBanTYI/ZLr0TcrQLoB3 7iDjbQQbZhmR9KHDYVBCJeuiz/Ubp/lI+FEjXyyONc88CfYv1mwq3FotWwZlXQxc8t l+SZzLppHWo9iM5FHxcRJVpaUAfg+VfmsuUghi3DovDLyLS5sIAy0UKDegBoNLhvxp vuX92yWw2YsOno/k5qpE+XW1A4iq7dgGOt+FT5IaDnPbVzHLTxdNR/j9hRrGHkJ6pD mL0u2Vz12TPLQ== Date: Sun, 12 May 2024 09:35:18 +0100 From: Simon Horman To: Jitendra Vegiraju Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bcm-kernel-feedback-list@broadcom.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC Message-ID: <20240512083518.GX2347895@kernel.org> References: <20240510000331.154486-3-jitendra.vegiraju@broadcom.com> <20240511015924.41457-1-jitendra.vegiraju@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240511015924.41457-1-jitendra.vegiraju@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240512_013527_470102_E79537A6 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 06:59:24PM -0700, Jitendra Vegiraju wrote: > Broadcom BCM8958X SoCs use Synopsys XGMAC design, which is similar to > dwxgmac2 core implementation in stmmac driver. The existing dwxgmac2 dma > operation functions have some conflicting differences with BCM8958X. > This glue driver attempts to reuse dwxgmac2 implementation wherever > possible, adding alternative implementations where necessary. > > v2: code cleanup to address patchwork reports. > > Signed-off-by: Jitendra Vegiraju ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c ... > +static struct mac_device_info *dwxgmac_brcm_setup(void *ppriv) > +{ > + struct mac_device_info *mac; > + struct stmmac_priv *priv = ppriv; Hi, Jitendra, A minor nit from my side. Please consider using reverse xmas tree order - longest line to shortest - for new Networking code. This tool can be of assistance: https://github.com/ecree-solarflare/xmastree ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel