From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56C33C25B74 for ; Mon, 13 May 2024 15:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+IKDKrBXDV9NBZVWxcr38kQR3W69hb+ZTsvTNQ9Z4BY=; b=JjrytSvJWNpWIwg7jMbqnI8zKz KleoM9H/4tX9uI/t143kv4etqcbkF71U4V0NZgTfY7kYY6wqQHR9OMHmH6T8q45oEmX4IwWbuDOh7 cRP96/RVINZ/y6YD3hFgVEDQIYh8n/IU8Mk31i1CFEK1KN0GgSUQOtt/JZCAK3QFPy8LU1tT10AEM rbW9ZlpxIQIxWXfCHE/Gp/zHVbCaEBF5hVWQrixm2BBajUtUyaiukpZ2aeZl7WT5wsS7SD12PzrMK JTM8FOGk7B9CH3juq+8lZZhbKEla52He6g9hU+DJryd0NedTigMd6X5VRF6JhyJHz66v0ttPmH/OM ppVd6ytA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6XQ9-0000000DKWX-2RGW; Mon, 13 May 2024 15:16:57 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6XQ6-0000000DKVH-1SAX for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 15:16:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B6C13CE0F24; Mon, 13 May 2024 15:16:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15316C113CC; Mon, 13 May 2024 15:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715613408; bh=HU9Kthyf9AMvfavUhbOcA41Vuir/Y1fnNqQMRB+ThnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lxrHjuKhb3JXMA3yvXcjLCZF753vbE9sWINCd0Ep1XXA/LSaBp0ZDXvT/q/5gKO++ Lzw2/twgMrGiuEScOAO2zDy7CNwaxX60tVhSo6+rkjF/wCWkAWuAVKl9TgahRpbc2W txo0MSgdR8a7Xaa22nzigdLN+L/2/TNXt1OtiXtpcY8l07zZwtDiquDwe/NfbOsgJI /pznRwlM7FwQt7kBN7vaWpxl23/sqHvUTabMWXUG+WBr8X8Oa+Dba4lawv9R6hE1Dg 5QdcD1DRFHRnjtvt7PtcdVMh+mR+jzwqk1ZMF0ipkEChrgIvzW9RgXC5vjYDCTZU+b v5p+29TQr+oxw== Date: Mon, 13 May 2024 16:16:43 +0100 From: Conor Dooley To: Marek Vasut Cc: Patrick Delaunay , Alexandre TORGUE , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Pascal Paillet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v3 1/2] dt-bindings: regulator: st,stm32mp1-pwr-reg: add compatible for STM32MP13 Message-ID: <20240513-stabilize-proofread-81f0f9ee38b9@spud> References: <20240513095605.218042-1-patrick.delaunay@foss.st.com> <20240513115601.v3.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid> <615dfdcb-cbda-426f-895e-810f03a8ce60@denx.de> MIME-Version: 1.0 In-Reply-To: <615dfdcb-cbda-426f-895e-810f03a8ce60@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_081654_852939_9031CECF X-CRM114-Status: GOOD ( 23.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5243228328856898974==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5243228328856898974== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7WL8bDW+3sE8qEPT" Content-Disposition: inline --7WL8bDW+3sE8qEPT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 04:34:20PM +0200, Marek Vasut wrote: > On 5/13/24 11:56 AM, Patrick Delaunay wrote: > > Add new compatible "st,stm32mp13-pwr-reg" for STM32MP13 SoC family. > >=20 > > Signed-off-by: Patrick Delaunay > > --- > >=20 > > Changes in v3: > > - Replace oneOf/const by enum; solve the V2 issues for dt_binding_check > >=20 > > Changes in v2: > > - update for Rob review, only add compatible for STM32MP13 family > >=20 > > .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pw= r-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-re= g.yaml > > index c9586d277f41..c766f0a15a31 100644 > > --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.y= aml > > +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.y= aml > > @@ -11,7 +11,9 @@ maintainers: > > properties: > > compatible: > > - const: st,stm32mp1,pwr-reg > > + enum: > > + - st,stm32mp1,pwr-reg > > + - st,stm32mp13-pwr-reg >=20 > Should the st,stm32mp1,pwr-reg be treated as fallback compatible for > st,stm32mp13-pwr-reg or not ? >=20 > In other words, should the DT contain: > compatible =3D "st,stm32mp13-pwr-reg", "st,stm32mp1,pwr-reg"; > or > compatible =3D "st,stm32mp13-pwr-reg"; > ? Which one is preferable ? >=20 > I think the former one, since the MP13 PWR block could also be operated by > older MP1(5) PWR block driver(s) without any adverse effects, except the = SD > IO domain configuration won't be available, right ? Aye, the fallback sounds like what should be being used here, especially if another user of the DT might not need to implement the extra domain. --7WL8bDW+3sE8qEPT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkIu2wAKCRB4tDGHoIJi 0lvfAP9rGyh8L75hqzO31KKo0VjnQVaddbWqnT+TfJuogvhOPgD+K/V4pOzfwW3l NyOTQkYcM9fqIXgdfeeXPmIZ/6VV3QI= =kDOI -----END PGP SIGNATURE----- --7WL8bDW+3sE8qEPT-- --===============5243228328856898974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5243228328856898974==--