From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC904C25B5F for ; Mon, 13 May 2024 06:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYcAJHdPhWI1CPGNHwVcl9NdxQfyfP0VZwRV6CFoCk4=; b=VdyBhuBq5kAhlp KgZZZeXrAewXS5zA+FBrYYck+CFtlKz9HNG4jzvnzrZD9Nr8TNYWxLXwWoc8kd6M2xPuI7tYePHgw nwIS6KIBPBX8L45e5OWOlIlar1/GBwiuOWimMKvIMh7V0m5Hnho1JkkN4tXWYjbpUJWbVKDgnVpEj A14l6BCFDYktqNX6IG+yGlaFLgFq2tAKFlRk2zSyfz3IctNEdd4VEOtR5Si1Sd2yy6EHY52h3jIQM /xiVQlv2bizewRyGO5o8Ot/UYRioG0tuwTx/Y5zjwxr3F8t5FVjfpl1kaVVHcKpXtGc/bANLAdXXT Hyi4WT82dSD6rz5WYcZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6PIs-0000000BslW-2bF1; Mon, 13 May 2024 06:36:54 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6PIo-0000000BsjB-2lUi for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 06:36:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 28832CE0B42; Mon, 13 May 2024 06:36:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49A8EC113CC; Mon, 13 May 2024 06:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715582199; bh=TbOvTyRXh66VompTcjMDwvYNM69rIo59zf33ZAIoC3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tTaxfkDWkpFLHTwZC04kCtJkxNIENzZTmI5PYUKwkt1HRtZwwVBTYbFXCKWXcUsFE lu793V3wsQpVnnxhiyy4l3w5M3BManAyomm+xMwTAyNaim5rV90eGNn3mMiMpD8jsA UqfnBD4pUsnBApFDVrZ72bs8rFERvxkxKcnlGxScNmrpZTFJO+rliEnufnsu6y1QsJ jdnX14KSi0SrFalr1dugXSDJs67FWBNS2YuhD+3FL8+CiNOMhnAtTO7NBueFaBX95U Nzb7vZnq+/kTgT5lFs+P3Qv+b3a98AU3Lm85P6JH8vioKPHQYsZ7kJnumUdy3NbnRA DYkUpN6BPUoVA== Date: Sun, 12 May 2024 23:36:36 -0700 From: Nathan Chancellor To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Jesse Brandeburg , Marek =?iso-8859-1?Q?Beh=FAn?= , Piergiorgio Beruto , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart Subject: Re: [PATCH net-next 0/2] Fix phy_link_topology initialization Message-ID: <20240513063636.GA652533@thelio-3990X> References: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240512_233651_211739_AF040347 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Tue, May 07, 2024 at 12:28:19PM +0200, Maxime Chevallier wrote: > Nathan and Heiner reported issues that occur when phylib and phy drivers > built as modules expect the phy_link_topology to be initialized, due to > wrong use of IS_REACHABLE. > > This small fixup series addresses that by moving the initialization code > into net/core/dev.c, but at the same time implementing lazy > initialization to only allocate the topology upon the first PHY > insertion. > > This needed some refactoring, namely pass the netdevice itself as a > parameter for phy_link_topology helpers. > > Thanks Heiner for the help on untangling this, and Nathan for the > report. Are you able to prioritize getting this series merged? This has been a problem in -next for over a month now and the merge window is now open. I would hate to see this regress in mainline, as my main system may be affected by it (not sure, I got a new test machine that got bit by it in addition to the other two I noticed it on). Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel