From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70A0BC25B74 for ; Mon, 13 May 2024 15:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GfchlAGiJ/an2tcPm/Bw9iuL2d6HPdjysFakrn/BW9k=; b=eN5mq2vBEjHQrx 7tS526o4AUZfqI9qH5UBy3sfEEMVTaYTuwKkoAOore7V291THhk6pNC1zvI20/qFsgA64yg9NdUdJ qp0MCHxqjZJAB+oVoM1RbcR+n7wkGFeTgIjngfbFkG3bZQmwzUMTP1KC7Gae0kVw8+f2McBTLniDX MurmC3JeODYxcYixlu98ox2iSjRWJ0vHrGv95xckLt13p5v+qcqcai3Wzs0yKNCAtMMR6L/x+PYh8 ndv+PNTZDRMJZHACK+yTtwsc0c3xR4qIdvP0jT8psTf9agFKAWyZvRFBolQQ1JsEOZ4hZ+i70pP0s CJ2n7Nwj70fpJdQcruVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6XLP-0000000DJZx-1XRc; Mon, 13 May 2024 15:12:03 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6XLL-0000000DJY7-2mxN for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 15:12:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7FE0CCE0F20; Mon, 13 May 2024 15:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 895FCC113CC; Mon, 13 May 2024 15:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715613100; bh=ZGgil73BE3HNKRxqE46JpywWmkJeK1/QT9NbcobOA2M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VuH21bQ5WI78cvv9gorAje7f4LxViRt/6ZEJddl/oyAmKbrP+lHltNpQL7En0zFVG 4Uq9A1K7XYEfY9b0uLlVKsOP9J7JGYf1WTDVsPxMyA/uCanS57pMrZu4Qcis+z4ZKC GL+RbGQPpb/DzobAJ14IPDP7DrrDTbLVHE/r3tr2jNgVJ69rk1eGVycB6pVZ6UO9ns nBYGfYgPp5+xKss9kSexxs3Hb5wi/0WMxqQ/GuasaTR6g/R790e15nS6imntO1dDaV m8N/krTeN5mp43/dcqavMvEArPbImlqsvNGabI2Gq6gl1zgOSL8iVsueVhhnllqiAr Ss8SDnI1Ku3og== Date: Mon, 13 May 2024 08:11:38 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Nathan Chancellor , davem@davemloft.net, Paolo Abeni , Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart Subject: Re: [PATCH net-next 0/2] Fix phy_link_topology initialization Message-ID: <20240513081138.7e7eb3d0@kernel.org> In-Reply-To: References: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> <20240513063636.GA652533@thelio-3990X> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_081200_104296_1997495C X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 13 May 2024 10:15:48 +0100 Russell King (Oracle) wrote: > ... and Maxime has been working on trying to get an acceptable fix for > it over that time, with to-and-fro discussions. Maxime still hasn't got > an ack from Heiner for the fixes, and changes are still being > requested. > > I think, sadly, the only way forward at this point would be to revert > the original commit. I've just tried reverting 6916e461e793 in my > net-next tree and it's possible, although a little noisy: > > $ git revert 6916e461e793 > Performing inexact rename detection: 100% (8904/8904), done. > Auto-merging net/core/dev.c > Auto-merging include/uapi/linux/ethtool.h > Removing include/linux/phy_link_topology_core.h > Removing include/linux/phy_link_topology.h > Auto-merging include/linux/phy.h > Auto-merging include/linux/netdevice.h > Removing drivers/net/phy/phy_link_topology.c > Auto-merging drivers/net/phy/phy_device.c > Auto-merging MAINTAINERS > hint: Waiting for your editor to close the file... > > I haven't checked whether that ends up with something that's buildable. > > Any views Jakub/Dave/Paolo? I think you're right. The series got half-merged, we shouldn't push it into a release in this state. We should revert all of it, I reckon? 6916e461e793 ("net: phy: Introduce ethernet link topology representation") 0ec5ed6c130e ("net: sfp: pass the phy_device when disconnecting an sfp module's PHY") e75e4e074c44 ("net: phy: add helpers to handle sfp phy connect/disconnect") fdd353965b52 ("net: sfp: Add helper to return the SFP bus name") 841942bc6212 ("net: ethtool: Allow passing a phy index for some commands") Does anyone feel strongly that we should try to patch it up instead? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel