From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2665C25B10 for ; Mon, 13 May 2024 08:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XBdHYC/jYqW0275C6T3w563woICNT1EEvaeixT7pNRI=; b=YBT2MgvapE/5Xa PPLMM9820QUE6U5IpnawL2fm+S+abACs5DWTMKuzUTPcTrFPI0bdfH54BxClyBxjwtxmzvo9FCUqD 5lnu/OIOCZnYdsEcRgWGeFBPnWqZkDfYxpKhDa7jZyh821rp4Pfjp5jn5mxQs2GaRPMJ9V1j89+5E kf3vLtofmhUizzLYJ/TFEYcKXAGzl2f6hTePWOFBpPtGL3yZd/Fq9M0OL7EdNQpYYKerDlUVTZZT6 pOTn/lHQy9z+x1XEJAp9DkUGUm4FKxaIlMK8u0z2PD5Eur31f5a/IETHZKUrOoqP3fbIKCcZrBwZw 98MkFR8IQiOh2lWhqLsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Qig-0000000C9vU-0suC; Mon, 13 May 2024 08:07:38 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Qid-0000000C9uv-2fSi for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 08:07:37 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BB31AFF80C; Mon, 13 May 2024 08:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715587653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/YUgEe1bGHZKnZAoXKQuqCOAbUHDdbNXzV7Y3U3kIQ=; b=KVb74pfNhpZrW/QoHHtX0rQAF/onUadKVpuW9nH2Jt/p2aJr+M3WfrdsoLbnk83+b3S7gL WAxlBSDUFLCITPRCbjqjwoHxVLGuUIyqhDrpu0EUqHUV5miIP2/84lPAV5t/4WfkuBZodx TXXJMOVygI5he/O6T1zjLV5JO29Shgb9GtEBtfxF2uBoPZ6xOGdvW1jZoBqSdRVXueB5/1 PYXCCotWQPY3nwtxuRyEsPQQyDNK4UHgduy2JV2r/zyoVA6rXpKoYdzhEwRWtoMPrrPQfE 3O06zzM93OmMl2UbkDjYl6A4saWhrhwhEl51Uo9PsnD+kbiI6SWb7EwWpisOWw== Date: Mon, 13 May 2024 10:07:29 +0200 From: Maxime Chevallier To: Heiner Kallweit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next 2/2] net: phy: phy_link_topology: Lazy-initialize the link topology Message-ID: <20240513100729.39713abb@device-28.home> In-Reply-To: <6cedd632-d555-4c17-81cb-984af73f2c08@gmail.com> References: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> <20240507102822.2023826-3-maxime.chevallier@bootlin.com> <6cedd632-d555-4c17-81cb-984af73f2c08@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_010735_852080_2D40FF7A X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello again Heiner, On Wed, 8 May 2024 07:44:22 +0200 Heiner Kallweit wrote: > On 07.05.2024 12:28, Maxime Chevallier wrote: > > Having the net_device's init path for the link_topology depend on > > IS_REACHABLE(PHYLIB)-protected helpers triggers errors when modules are being > > built with phylib as a module as-well, as they expect netdev->link_topo > > to be initialized. > > > > Move the link_topo initialization at the first PHY insertion, which will > > both improve the memory usage, and make the behaviour more predicatble > > and robust. I agree with some of the comments, as stated in my previous mail, however I'm struggling to find the time to fix, and re-test everything, especially before net-next closes. Would it be OK if I re-send with a fix for the kbuild bot warning, improve the commit log as you mentionned for patch 1 so that at least the issue can be solved ? I still have the netlink part of this work to send, so I definitely will have to rework that, but with a bit less time constraints so that I can properly re-test everything. Best regards, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel