From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 089C2C25B10 for ; Mon, 13 May 2024 14:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+YA8f4hKJA1/pgvurVT2GqTeU1xH70k0gtFKVdJhehM=; b=GzyT3HkYFlNFC5 xoCly+hIhpaii2rzgbzHBYLgIcVdMM6nJqbFdS9mXcwTnT0O0RT6pxcckLHkwscNLHDVOw5UO+fex HrYBD8N4zbKhXrenZllazOjjl7PBBuNpQl7uM1wL2uUKf0PdgS33nPSjaiekCLQyhrhjcW1C5BUa+ HR/BtWaqGAjzoh9GUMikY4nVZ9s8dcM+S85R74UhHYbrJRCNhLdyShv4Qg8mhQnvNpCfYPZCaffez 7TjvVE+GVQcs6DlHKZHWaJk9S7mc2b3KiqgzUfy95VOHjlxRuN8jyaNljizaQ5gi5Gg5quW3MrM8s 5aL3o4/AS8iFeHlQI00Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6X2p-0000000DFA1-1ZuR; Mon, 13 May 2024 14:52:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6X2n-0000000DF8h-1ie5 for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 14:52:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BEEF660DFE; Mon, 13 May 2024 14:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C640EC32782; Mon, 13 May 2024 14:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715611968; bh=GhGdQKNqljv/diEmKy6DBZ8tuusN/Q8wpaUsamwB/l0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hhtej7WjJN6Rpnnoomhym6z3QD0H55mJhktM4st/nRJULRJPxIE0whb9NzbGTGItu 5vi84OiA6wfl+1yxEsDDSIxOEQV1XUD0yHwDbFwp34EruER5NIw2x0ozsgrZ8zeq2M CvB9j71bkPpVKIWuL8AmhJvJJDvUYw5GWjTLVIepZFoQlTZ71/dWcdkZpKOK9MmvZl 1hAXZi05pddgjUfsgZJ10sOhc5G0CxlL42tcM2KpFhmNyZKjLuvcDvEAr3V2AheAQN 1cwGUViXKwxPIEM2nqB3f0Wq69VBku74uiYAwXE3ypHuGSe9M+vqaslgvNItcD4WhV tv93nVawotJfw== Date: Mon, 13 May 2024 15:52:43 +0100 From: Will Deacon To: =?iso-8859-1?Q?Pierre-Cl=E9ment?= Tosi Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Marc Zyngier , Oliver Upton , Suzuki K Poulose , Vincent Donnefort Subject: Re: [PATCH v3 07/12] KVM: arm64: VHE: Mark __hyp_call_panic __noreturn Message-ID: <20240513145243.GF28749@willie-the-truck> References: <20240510112645.3625702-1-ptosi@google.com> <20240510112645.3625702-8-ptosi@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510112645.3625702-8-ptosi@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_075249_521676_F29120DB X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 12:26:36PM +0100, Pierre-Cl=E9ment Tosi wrote: > Given that the sole purpose of __hyp_call_panic() is to call panic(), a > __noreturn function, give it the __noreturn attribute, removing the need > for its caller to use unreachable(). > = > Signed-off-by: Pierre-Cl=E9ment Tosi > --- > arch/arm64/kvm/hyp/vhe/switch.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > = > diff --git a/arch/arm64/kvm/hyp/vhe/switch.c b/arch/arm64/kvm/hyp/vhe/swi= tch.c > index 1581df6aec87..9db04a286398 100644 > --- a/arch/arm64/kvm/hyp/vhe/switch.c > +++ b/arch/arm64/kvm/hyp/vhe/switch.c > @@ -301,7 +301,7 @@ int __kvm_vcpu_run(struct kvm_vcpu *vcpu) > return ret; > } > = > -static void __hyp_call_panic(u64 spsr, u64 elr, u64 par) > +static void __noreturn __hyp_call_panic(u64 spsr, u64 elr, u64 par) > { > struct kvm_cpu_context *host_ctxt; > struct kvm_vcpu *vcpu; > @@ -326,7 +326,6 @@ void __noreturn hyp_panic(void) > u64 par =3D read_sysreg_par(); > = > __hyp_call_panic(spsr, elr, par); > - unreachable(); > } > = Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel