From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3B4BC25B10 for ; Mon, 13 May 2024 18:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g46CIggTBVlZaNTw/StMWoVTAYYeJjIHFCzWYoGjSyY=; b=s0eZcbF5h6oGNz peoT8LQXc9Cs4yo6hYlV57cba1X0k6gexTLxPtR1B3lKpQqUejz7YpXdgGgCxhigp5dhl+OH98YZp rSqmZQnYQMXX4NGebBmV3DKdKFvRon457PadymALEyqixNSj+rJ9Q8W7eJPHf/eN1Wi1DnyGBbF0I SkawXZaVYq2qfZ2I8JH4TnC2M3Lc5lPq73lX0ogddk7nKM50ea5m9EDyoCJSUShOGmLjUB7XLTfBN 96C+NJAhj6YjmZdfjHenyI/XZiAXDyDKwIOPG38RojZuap6AYF7/lqus2MUKGVmZV6seR5AbX2zYb V5RgCvgiuttClziM7qaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6asN-0000000DwKN-1eN3; Mon, 13 May 2024 18:58:19 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6asK-0000000DwJk-3SVR; Mon, 13 May 2024 18:58:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 24801CE0D01; Mon, 13 May 2024 18:58:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15146C113CC; Mon, 13 May 2024 18:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715626694; bh=57fZM2+CJ+hL4V48G83HQA+tgOjiimKWogurk2thYUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BmsNO9zN1OA/q1Gq2nCgr0abq+WgVsthzfcBAOOEj4p0Kp2bZN88jyiYKI0GIwbna Sbu32+V1CYQ6uhazji7m9MlROgolHRKycA4k9YG8aL/nOD4xNWOBH6BljBl/T2CO/m 9VkQ/veriSICNyyTUlQEEs2N79yjVkq+CFuTC1K2deygf0Fkhbet/9ix1ItTsF13wZ 8JgC92a61eYeIzyVK51ZhHKzAV7ejSZJn120RlMgGiCLrDQY+kYXgecJ9JdEmImbAM jiN8aXyopVuvOTB5kjyJYk006jJUwoH1es1NX1e3G4yw+LTZhSyUh1Bd/n+hlk627+ 33mEhOtDOU3+g== Date: Mon, 13 May 2024 13:58:13 -0500 From: Rob Herring To: Stefan Wahren Cc: Andrea della Porta , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , Eric Anholt , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Message-ID: <20240513185813.GA2931923-robh@kernel.org> References: <1f0c4fa62d6849753e2138cce5498693cfc3a230.1715332922.git.andrea.porta@suse.com> <01a7a263-9de3-468c-b438-c16f2c73872c@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01a7a263-9de3-468c-b438-c16f2c73872c@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_115817_069254_B192AE7E X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 09:01:33PM +0200, Stefan Wahren wrote: > Hi Andrea, > > please drop E. Anholt from the recipients. AFAIK she is not interested > in kernel development anymore. > > Am 10.05.24 um 16:35 schrieb Andrea della Porta: > > The BCM2712 has an SDHCI capable host interface similar to the one found > > in other STB chipsets. Add the relevant compatible string and relative > > example. > > > > Signed-off-by: Andrea della Porta > > --- > > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > index cbd3d6c6c77f..404b75fa7adb 100644 > > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > @@ -13,6 +13,10 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - brcm,bcm2712-sdhci > > + - const: brcm,sdhci-brcmstb > > - items: > > - enum: > > - brcm,bcm7216-sdhci > > @@ -114,3 +118,22 @@ examples: > > clocks = <&scmi_clk 245>; > > clock-names = "sw_sdio"; > > }; > > + > > + - | > > + #include > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > Would be nice to have a short explanation in the commit message why this > is necessary. That has nothing to do with *this* patch. It's needed because 'reg' is dependent on it and the examples default to 1 cell. In any case, please just drop the example. A new compatible doesn't justify another example. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel