From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61BB9C25B75 for ; Tue, 14 May 2024 12:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=twiOKDLoEBCH+tM5r+XOubT4JgfSlosW0F0Neo6duNM=; b=GjC50glf635hKAvOD0coYU7sgv XUL3um895T8Ww6Dt9uBm0LbVwMJj3k9KE0K2RUUiVLEhKZYeyazQNw5p7kV3pNWl2PZfc6n0SyA+F whi7yDm+sH+6m2u/2wVAL7IOx0BU7P7cMXOIx1F0d3Lvpo2AhZfamafP2l9xRZvRV85PM7lPvp1Lk nrvFnlep4dOE3ww1TaCRpsakKrckB5km2Arp5ytYBl/Gexo8lW/tvFhxINRDIckynUk0lRNIHPPU7 iSHBQrZmxYskObBQa5U9eMnm/MT4M5Bcl5HFVksIA/WliRN6sB7nRQXmiST5BE8lERiqTDD6hZFLd V/X1WgjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6rI5-0000000Fsdh-3Ffg; Tue, 14 May 2024 12:29:57 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6rI2-0000000Fsc7-1fOF for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2024 12:29:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 576B8CE1258; Tue, 14 May 2024 12:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06663C2BD10; Tue, 14 May 2024 12:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715689789; bh=6cPrpE0EOmonSqbDlomNuzEI4XBK54BEpKNy1lBWCU4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qI0k5HvLfn1CfWJxRrdpit474Aa9aUxoOG7lKfDGJZ4mH86QzX3tmCOKcHdYhEspa Z81olAP9T5jKFCeYEubMWE6uWxP31811HsJnrqjSwJF9thfFSeATGhHwi4ckomsIch tO3lrlIV8++649cRA9gyRmBnhHTOunHMMw3OQLCy8EJFoPwXUqRwN3+xSorBEBpYl7 vQD++G3Tkyx5/MrdedtUejyEoqkgfIVtYjOjefsyId/95tPIFGH2TDeK2jb9FjjF7S aqF84E3Z/R2vVis3YdJjmzv9+FOU/I6aVtD8FSdttZSNrNy3FP/GgTYISNilqIw26E iAKRAmiemJkLw== Date: Tue, 14 May 2024 13:29:43 +0100 From: Conor Dooley To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Jassi Brar , Bjorn Andersson , Maximilian Luz , Ard Biesheuvel , Johan Hovold , "Michael S. Tsirkin" , Sudeep Holla , Conor Dooley , Bartosz Golaszewski , "open list:COMMON CLK FRAMEWORK" , open list , Stefan Wahren Subject: Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835 Message-ID: <20240514-amiable-unequal-d4133956c80c@spud> References: <20240513235234.1474619-1-florian.fainelli@broadcom.com> <20240513235234.1474619-2-florian.fainelli@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20240513235234.1474619-2-florian.fainelli@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240514_052954_643355_1F2E8007 X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9075610386950342278==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9075610386950342278== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZF82ErRhEId7DTVg" Content-Disposition: inline --ZF82ErRhEId7DTVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote: > This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides > a number of essential services, including but not limited to a Linux > common clock framework provider. Make sure that enable > CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver. >=20 > Signed-off-by: Florian Fainelli > --- > drivers/mailbox/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index 42940108a187..2b4cde562a90 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -109,6 +109,7 @@ config ALTERA_MBOX > config BCM2835_MBOX > tristate "BCM2835 Mailbox" > depends on ARCH_BCM2835 > + default ARCH_BCM2835 This is just "default y", since I doubt ARCH_BCM2835 can be a module? If so, patch 2 could also just be "default y" and I think patch 3 can have the same logic applied to it, given you're defaulting it to a dependency also? Thanks, Conor. > help > An implementation of the BCM2385 Mailbox. It is used to invoke > the services of the Videocore. Say Y here if you want to use the > --=20 > 2.34.1 >=20 --ZF82ErRhEId7DTVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkNZNwAKCRB4tDGHoIJi 0g9yAQCQfW/zAiGbZezyBzVcnkHGAEnFDwul79aAYPQZhc0dGAD9H+asSEG/ICHL HtOFDWlh1G+Pmy1k37sMldVMk4wZfAI= =1AwS -----END PGP SIGNATURE----- --ZF82ErRhEId7DTVg-- --===============9075610386950342278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9075610386950342278==--