From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 492F9C04FFE for ; Tue, 14 May 2024 06:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T7+0f+5wCbL7f0+cw9QTTRGX50/Mf2xAAGO3Muo5kYw=; b=YtoWPwZHZlAF7c DmN8tkP8iw3CbddnnNMhk0gnDuVQ4PrAmFA+dKOa/JIvmnGQhKs1rKtngcvBsAeokPWttGEmrM33u cq2F6XRmnfap8FN7XKVXqlSkNjcYg0VHT0+nDNBSWIVuz6KwWT1+BQVREF6kbw4+peuM3ogy08g80 j+/4hN92sfzccTnMncb0emk0/U3KnzsHZzb5JE/sQg47sjP1XWgXj0Odk7YKu2NWOv8H4kWNY+e+D GOXiaOMknirCEtJCp5ZfQ117xy9fGz4Ueu9RIz2H6Fs/W0mQ72iIgW0JKvwcwUs5RI1kOlV1KRfdK 3tgXW0CskaY7VkpdB+mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6lve-0000000F92m-475t; Tue, 14 May 2024 06:46:26 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6lva-0000000F927-250Z for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2024 06:46:25 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id AD58EFF808; Tue, 14 May 2024 06:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715669178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCIrRriEzgk/G7WM/sS3L+fxbWtFNIOHOsZ1sDN8iUw=; b=ZJVVBplmWrmGcwSr5bCK8FekXBM8wIgMszHR6IDo2Z01gVTViowSMZmJAAE8YLNimRHUYF tHWjNA5JrSOgDm52+eUbFb8aS4ZlQb9yiEfCG72dF12+DgimIo3dxGTicOfrYU1gLD0YRE 7vGn5G/TRMYHMlg4SptNG9CDHf3U84RD/RYrzcwqZmyP8at26cPvSWbxciJdbEkwXjh5HI D+U0NWH5bwj80nJ/CPw1Hum3nR9MG+UFXPCA1UanUr1ljgxK2NeckttU/9WD2G8Y6uwQT/ KF/ISjU+jZ3DWpW88oClpuvkHOyb+szNkiwZfdmcLdUTX+dPxvW8HA4ArVERWg== Date: Tue, 14 May 2024 08:46:14 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: "Russell King (Oracle)" , Nathan Chancellor , davem@davemloft.net, Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart Subject: Re: [PATCH net-next 0/2] Fix phy_link_topology initialization Message-ID: <20240514084614.1f00e2ed@device-28.home> In-Reply-To: <20240513081138.7e7eb3d0@kernel.org> References: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> <20240513063636.GA652533@thelio-3990X> <20240513081138.7e7eb3d0@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_234623_000991_E96465D6 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jakub, On Mon, 13 May 2024 08:11:38 -0700 Jakub Kicinski wrote: > On Mon, 13 May 2024 10:15:48 +0100 Russell King (Oracle) wrote: > > ... and Maxime has been working on trying to get an acceptable fix for > > it over that time, with to-and-fro discussions. Maxime still hasn't got > > an ack from Heiner for the fixes, and changes are still being > > requested. > > > > I think, sadly, the only way forward at this point would be to revert > > the original commit. I've just tried reverting 6916e461e793 in my > > net-next tree and it's possible, although a little noisy: > > > > $ git revert 6916e461e793 > > Performing inexact rename detection: 100% (8904/8904), done. > > Auto-merging net/core/dev.c > > Auto-merging include/uapi/linux/ethtool.h > > Removing include/linux/phy_link_topology_core.h > > Removing include/linux/phy_link_topology.h > > Auto-merging include/linux/phy.h > > Auto-merging include/linux/netdevice.h > > Removing drivers/net/phy/phy_link_topology.c > > Auto-merging drivers/net/phy/phy_device.c > > Auto-merging MAINTAINERS > > hint: Waiting for your editor to close the file... > > > > I haven't checked whether that ends up with something that's buildable. > > > > Any views Jakub/Dave/Paolo? > > I think you're right. The series got half-merged, we shouldn't push it > into a release in this state. We should revert all of it, I reckon? > > 6916e461e793 ("net: phy: Introduce ethernet link topology representation") > 0ec5ed6c130e ("net: sfp: pass the phy_device when disconnecting an sfp module's PHY") > e75e4e074c44 ("net: phy: add helpers to handle sfp phy connect/disconnect") > fdd353965b52 ("net: sfp: Add helper to return the SFP bus name") > 841942bc6212 ("net: ethtool: Allow passing a phy index for some commands") > > Does anyone feel strongly that we should try to patch it up instead? It's OK for me, at least this showed some of the shortcomings with the current code, let's come back with a better version for the next round. Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel