From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13983C25B75 for ; Wed, 15 May 2024 18:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=zFwp7TV2gWp1eQQdt/yU7C53ofKvxp8T2qtydH9Di6c=; b=ttLLobHMAMq/Mo owdw2ziZjpBgxO2tB4JvwlUHrzAPdjvRC908ElKyuKZUv7nDOh6kdk+qhWvB/tVgJkB8oi62OHkIn thp9Jbfd1rwn/IcO8MxgjYCXMM6E41U9VnSKwQnY1cV9/W918q5uiDZ1Uttf+CUbguaD4Ds3zjrxd ottqICQRqj9sqVM8T2jOvLh+0D6pA8RGQ4gBGX4fd7ba7aCnVXWkvKnUn0+9eZBlvAq173fUiHNR+ He/MIeXMKfmjhTFbJUUhPq2vjedbtqGHvc2UBvuoebjtckU9r6nPGC0oHkQVKZQPJzBaJZZ+h2x1V LqnwxdKuX9TA0PspPyJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7J7O-00000002VVp-3nLQ; Wed, 15 May 2024 18:12:46 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7J7L-00000002VUz-3BmK for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 18:12:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B9ECACE0AB7; Wed, 15 May 2024 18:12:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB5BFC116B1; Wed, 15 May 2024 18:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715796761; bh=LOrt+7GsCdn7DVj/gMbh6Xgf4i7fcQTqSrnZGxnrKlo=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fUGicGn9UQgOA6mw01bZqzwkiP556cGeMZciwhppd1eEX9Q0UyRqHaH8a4Pix3k4b pMz23Ce3cls1u/0/VAklE+zSfxBIc4q/Uh5HvttBB97ty+zfdR7aOGF/Nm8Fl63jWh 8i/bfP5MmhIMJBpGlOlyFiqqNulqAA0FX0FBTo9laWKQKZ+YcI2JfkT2N5K2d06Gbp WBxbqYwCJ5g3Y8isM7PyYMPTixIec/VbFzK6ez58k2QvWcWE0Jls5XZyrRsy0ovJc9 V327PgagjEknSV7Nzxh+JZX4mJGlP6Cksf6OBV6yYGWAx9kmRq3lFcEsKsSo40a8CI +YRlQR7DjwxjA== Date: Wed, 15 May 2024 13:12:38 -0500 From: Bjorn Helgaas To: Roman Kisel Cc: Saurabh Singh Sengar , arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, mhklinux@outlook.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev Subject: Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT Message-ID: <20240515181238.GA2129352@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_111243_998116_FFB7C083 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 15, 2024 at 09:34:09AM -0700, Roman Kisel wrote: > > > On 5/15/2024 2:48 AM, Saurabh Singh Sengar wrote: > > On Tue, May 14, 2024 at 03:43:53PM -0700, Roman Kisel wrote: > > > The hyperv-pci driver uses ACPI for MSI IRQ domain configuration > > > on arm64 thereby it won't be able to do that in the VTL mode where > > > only DeviceTree can be used. > > > > > > Update the hyperv-pci driver to discover interrupt configuration > > > via DeviceTree. > > > > Subject prefix should be "PCI: hv:" > > > Thanks! "git log --oneline " is a good guide in general and could be used for other patches in this series as well. > > > + hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, > > > + fn, &hv_pci_domain_ops, > > > + chip_data); > > > > Upto 100 characters per line are supported now, we can have less > > line breaks. > > > Fewer line breaks would make this look nicer, let me know if you had any > particular style in mind. Let's not use the checkpatch "$max_line_length = 100" as a guide. The pci-hyperv.c file as a whole is obviously formatted to fit in 80 columns with few exceptions. IMO it would not be an improvement to scatter random 100-column lines throughout. That would just mean the file would look bad in an 80-column terminal and there would be a lot of wasted space in a 100-column terminal. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel