From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 212E3C25B75 for ; Wed, 15 May 2024 19:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=KCplz0rhcZkWEnkksQ9I9dxbZSCiFNkZFOlVlASiiHk=; b=qPDAPaPW6c4Ls5 ySwBM5t9LUwdhu0U1xzUG0d1sK59+F7fqxaARPVf3Mdub+wBVVx3XI88H/kQO5WGOWj8HsOVj7MsT Rw3fGpCD+wWOOeDue/bSSQn0lduucSHZWZrm/Hm7Qms6byP/ODck9h4k8W5UBjX6szXWWSc0FqGA2 vef1j1yzutNm/t2TONI+djNOAtmawQsi/PdxTNy/ghEpT+7wMj3RfFJxdTypqBkThLFyzLUKD6auG +/p3VOF02JeSnvSTStE1gTUUrzZnxmzKO/BOBEgxz267Q+dAE+xNYyhOI/jvXSqhapJEa2byNk7zR 5JRgOWwSScoAVcZgE6CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7KGd-00000002hX1-3W2I; Wed, 15 May 2024 19:26:23 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7KGZ-00000002hWC-46X3 for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 19:26:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 23982CE0B2C; Wed, 15 May 2024 19:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 178B8C116B1; Wed, 15 May 2024 19:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715801176; bh=/uESMWzJ0qlSKrj7tTV6bA6iZEGcMmGLFrgFJNV8pRc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=rd0OOavEspsrXZCLoWfQd9F0nwYmVhee07cuGCr3AuSmzbAjut0BwGJXJ1bEGG5X/ PEhN/sIZxqYTUlj+2aeX5cHT5EKuoIeIS4ktf/z75viJF7glR0Jfor0zdMT1vV9uYT mxQlAZbM02ILp/HEf3/Kb4DF7xVZ6nxuC04hOGs6Z3PYv4UICDFlR5oxIAbeU77wDu 1tl8P3gxgmi8BCm/ZAqs14E6/LS0jPq+aAuoPFA/iBPx3IpnsWZR/vA+8m+8aN40dm tP1ThsT073Z2eVI4bYkZa7jb2JT7ENOZUXctkERnL2xXV+XvNDeb4pfCNF3aV61oqw rKpaCCodJ91Iw== Date: Wed, 15 May 2024 14:26:14 -0500 From: Bjorn Helgaas To: Siddharth Vadapalli Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, manivannan.sadhasivam@linaro.org, fancer.lancer@gmail.com, u.kleine-koenig@pengutronix.de, cassel@kernel.org, dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH v7 2/2] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: <20240515192614.GA2133406@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240514211452.GA2082543@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_122620_295003_BBB50D77 X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 14, 2024 at 04:14:54PM -0500, Bjorn Helgaas wrote: > On Tue, May 14, 2024 at 05:41:48PM +0530, Siddharth Vadapalli wrote: > > On Mon, May 13, 2024 at 04:53:50PM -0500, Bjorn Helgaas wrote: > ... > > > I'm not quite clear on the mechanism, but it would be helpful to at > > > least know what's wrong and on what platform. E.g., currently v4.90 > > > suffers Completion Timeouts and 45 second boot delays? And this patch > > > fixes that? > > > > Yes, the Completion Timeouts cause the 45 second boot delays and this > > patch fixes that. > > And this problem happens on AM654x/v4.90a, right? I really want the > commit log to say what platform is affected! > > Maybe something like this? > > PCI: keystone: Enable BAR 0 only for v3.65a > > The BAR 0 initialization done by ks_pcie_v3_65_add_bus() should > happen for v3.65a devices only. On other devices, BAR 0 should be > left disabled, as it is by dw_pcie_setup_rc(). > > After 6ab15b5e7057 ("PCI: dwc: keystone: Convert .scan_bus() > callback to use add_bus"), ks_pcie_v3_65_add_bus() enabled BAR 0 for > both v3.65a and v4.90a devices. On the AM654x SoC, which uses > v4.90a, enabling BAR 0 causes Completion Timeouts when setting up > MSI-X. These timeouts delay boot of the AM654x by about 45 seconds. > > Move the BAR 0 initialization to ks_pcie_msi_host_init(), which is > only used for v3.65a devices, and remove ks_pcie_v3_65_add_bus(). I haven't heard anything so I amended it to the above. But please correct me if it's wrong. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel