From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FB30C25B77 for ; Fri, 17 May 2024 12:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KB7pvhUAtDkfqtKyW4k7K/GyhlDrV1hU0ZwYVgZuVmM=; b=BF3lGKVta/Ihfm xUfT+2QC//e2UawK4xIkgxVXaxpwmkJwDeqkt+9tv3ff+fWOabY+VuEjXhTyjO0TQv88mk+XaSt40 GnsKBDqCAibZ+a9KEn42YpTZNWmNF0Ri7pjr54oSkLEN1xEmsWqhYzAHuGam7HOh00BMTTAb1vFJe pfh3VXQI7jaueLGUa//GS0KGFSGuLHXkak7q6AV1jQUo49Gz880fhzZ/B4CCrFxMG7uxN8btQTZGU P9r60oB4Hn0DUv8CJaACurAHIoBon2HhFG5CkJKZVJwdnF2FMX/AsuKaCnyrOwDxpgGlBmkVU7wIY U1PFPsU1Xid94F50K/YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7wIR-00000007lP4-46Mb; Fri, 17 May 2024 12:02:47 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7wIM-00000007lNe-1ID1 for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2024 12:02:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5B66DCE1AA8; Fri, 17 May 2024 12:02:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C99A6C32786; Fri, 17 May 2024 12:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715947359; bh=Aj995U25J5UbB1WP0fjOwm2XJjRFPFEAj+XFyuAV13o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=glxgZeLpP1uLmV4GBnYAiTerOc6h4T+R96O1PurnqCi/R8mFeRKSfXTyy57zbZCF9 u62t3dhnkqcVEXQqUZd76ITjG7wlJSWUfrqU8agoKARxrSu1R8w0WgsNwheRRW2gCY UdTsYEowBotGDj+MwCstPfvBj5+mZaDHmEAtSOnWj4ng5drK5lHCuL+keMB3HcHhud 45ur3p/t+QEG6pxL0CXUTjkjbGD7VZ5B4y2I8d6gJekxUxAN8d9pi7vpViiFH8r89o R6UU4qt3qoOAnQ4Iv8qeDFy+AtUYb0GVF9GGZppgpo/XdO9A/oZEGD1EacwkG6aq9R QJHIt9JUoNb3A== Date: Fri, 17 May 2024 13:02:34 +0100 From: Will Deacon To: Namhyung Kim Cc: Mark Rutland , Ingo Molnar , Peter Zijlstra , LKML , linux-arm-kernel@lists.infradead.org, Greg Thelen , Robin Murphy , Tuan Phan Subject: Re: [PATCH] perf/arm-dmc620: Fix lockdep assert in ->event_init() Message-ID: <20240517120234.GA32598@willie-the-truck> References: <20240514180050.182454-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240514180050.182454-1-namhyung@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_050242_603049_14D21AA1 X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 14, 2024 at 11:00:50AM -0700, Namhyung Kim wrote: > for_each_sibling_event() checks leader's ctx but it doesn't have the ctx > yet if it's the leader. Like in perf_event_validate_size(), we should > skip checking siblings in that case. > > Fixes: f3c0eba287049 ("perf: Add a few assertions") > Reported-by: Greg Thelen > Cc: Robin Murphy > Cc: Tuan Phan > Signed-off-by: Namhyung Kim > --- > drivers/perf/arm_dmc620_pmu.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c > index 8a81be2dd5ec..88c17c1d6d49 100644 > --- a/drivers/perf/arm_dmc620_pmu.c > +++ b/drivers/perf/arm_dmc620_pmu.c > @@ -542,12 +542,16 @@ static int dmc620_pmu_event_init(struct perf_event *event) > if (event->cpu < 0) > return -EINVAL; > > + hwc->idx = -1; > + > + if (event->group_leader == event) > + return 0; > + > /* > * We can't atomically disable all HW counters so only one event allowed, > * although software events are acceptable. > */ > - if (event->group_leader != event && > - !is_software_event(event->group_leader)) > + if (!is_software_event(event->group_leader)) > return -EINVAL; > > for_each_sibling_event(sibling, event->group_leader) { > @@ -556,7 +560,6 @@ static int dmc620_pmu_event_init(struct perf_event *event) > return -EINVAL; > } > > - hwc->idx = -1; > return 0; > } Thanks, I'll pick this up, although Mark reckoned he'd found some other issues over at: https://lore.kernel.org/r/Zg0l642PgQ7T3a8Z@FVFF77S0Q05N but didn't elaborate on what exactly he'd found :/ Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel