From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D2E4C04FFE for ; Fri, 17 May 2024 20:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4VG+HCz8Vaeye4+HfFmM2c8nEkr2sHnlR+PRkT2WtfY=; b=P2dnNtTthPgzqF YPSzRnC9yOnUoOmby3hJlYaYZrF/6a67kzjyg36K9yVOUHpB+ZA/5HvzOFHpH3SB4ocvHyiLwfAnG a3ohY3LW2UFivAXLCyt4/kfIGZ5ArQF7y36q9yPA/7zFkdNXsP59IOBqeeNDZM3bExmO0+RoD5o01 MMh+0yF0Z19zlD0Z3bobDIfldrCMrv7qiLYz5indoz0TjtpOeA5NHkUFsFIRONNwIscRkW83Jbqee 5IxX0WEggKlyDaNJ5D6/FyaKywzLafIBQYAlG6Kbd7JfkkXLQpQXpEOfEVUouVTATdR6R55tIQ+oo qEZi0QdxO9VUgGL06ePQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s83k6-00000008taS-454m; Fri, 17 May 2024 19:59:50 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s83k3-00000008tZn-3LFq for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2024 19:59:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A0A2BCE1B8F; Fri, 17 May 2024 19:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 707BDC2BD10; Fri, 17 May 2024 19:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715975984; bh=dYYtjZRFg1w3fItuQaPCJGU5QXhIg35KUK9e0MdEWpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vCd8nWTrqP1F+FxyMtyqxSqIGrdlOE3jZE9tZ1LGythn4sC5NqUz+wJ8GuWmnS07k o1mt2HfxUPx2/+Psc31tEMwCL9JbR9kMgOppdvl1q0WnrBqD3mdvEf2lSUQjffdI1p nAUiCtDA2rQK7XHnun/A147wzBMDhRLi0SVHG6lMfid0XKCAyUcWd5cUUIFf4lyfCa GgN5QTmnFH0djiCEzmpzW/13H144vuiHcV0RqpMOe6uqhEsvCQl9j9Vw4YkMuAomjU Mh5gKa36JIlgU3PjY1kRurlXXQq9FxHpoTzIn3pw8MuzjkMJEubXOI6VsubL6ceW8I EcX1Rhh7jgTjw== Date: Fri, 17 May 2024 14:59:43 -0500 From: Rob Herring To: Laurentiu Mihalcea Cc: Krzysztof Kozlowski , Conor Dooley , Lee Jones , Shawn Guo , Philipp Zabel , Liu Ying , Sascha Hauer , laurentiu.mihalcea@nxp.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: reset: add schema for imx8ulp SIM reset Message-ID: <20240517195943.GA2854624-robh@kernel.org> References: <20240516204031.171920-1-laurentiumihalcea111@gmail.com> <20240516204031.171920-2-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240516204031.171920-2-laurentiumihalcea111@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_125948_254142_47C6508B X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 16, 2024 at 11:40:28PM +0300, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea > > Add schema for imx8ulp's SIM reset controller. > > Signed-off-by: Liu Ying > Signed-off-by: Laurentiu Mihalcea > --- > .../bindings/reset/nxp,imx8ulp-sim-reset.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > new file mode 100644 > index 000000000000..ec9a5c73e83c > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8ULP System Integration Module Reset Controller > + > +maintainers: > + - Liu Ying > + > +description: | > + Some instances of i.MX8ULP's SIM may offer control over the > + reset of some components of a certain domain (e.g: AVD-SIM). > + As far as the DT is concerned, this means that the reset > + controller needs to be a child of the SIM node. > + > +properties: > + compatible: > + const: nxp,imx8ulp-avd-sim-reset > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + syscon@2da50000 { > + compatible = "nxp,imx8ulp-avd-sim", "syscon"; > + reg = <0x2da50000 0x38>; > + clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>; > + > + reset-controller { > + compatible = "nxp,imx8ulp-avd-sim-reset"; > + #reset-cells = <1>; > + }; > + }; Why do you need a child node here? No DT resources or anything for this 'sub-block'. Just put "#reset-cells" in the parent node. (Note that examples for MFDs like this go in the MFD binding rather than having incomplete examples here.) Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel