From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A6B7C25B75 for ; Sun, 19 May 2024 08:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ckiecsz97hmCyvstWKiarp6PkH/i8BHXn0rZLHMhE58=; b=u80ywHf4afPa04 DdjraHQCjhqAvUKjikAOioW3HdHH0PyD/BWrHuMOBpYzyCgU+qomun6Lzj0tL62j2n7QgSguoGbdP d2QoqhAI3Y/G/NX5gn5cAay2/38H6DJ5YPF+fNdNdiiiyTIDbJmhXP2imkrZ438ehQcdicLm5NCvY WRz/TODkSedCyXWJkY+A/t0Gh910vBYe3gLgAKjcouhdQTMSIXBurL7kjsHXv/Y9MAQomCUc2+R1d eIm4WWAbWQiwNjEv4irNX1iP/DUcx1E8du4PymWXzsTAYCEU2jkmjrcZVe/bOfjHUKHlvoNBmxgGP ZiYVr1jDfm36jxPHx+Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8cJc-0000000Bh2o-2X5O; Sun, 19 May 2024 08:54:48 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8cJX-0000000Bh29-098T; Sun, 19 May 2024 08:54:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 69181CE0976; Sun, 19 May 2024 08:54:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAF3EC32781; Sun, 19 May 2024 08:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716108879; bh=avtQ0tx1UdGxRsX9qlthvVsjKBAmRdw8FRebf2A40AY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nZr0+0uH7hovHNTAPMinTSPdETzLlI5O+iBMGKaXSs8Dn6tjYThYVZzpuuB3q89k7 8ivAraMr8BuZNiDzkNjR/dw/01BJItU3zMnON0g2J5TM9Tz5uw5dZXEBMbSE45LRbU njK9ujwV0dIekKzEFZV4X3qw2RHWZ5KQYPCMhgUQ= Date: Sun, 19 May 2024 10:54:36 +0200 From: Greg KH To: Val Packett Cc: stable@vger.kernel.org, Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066 Message-ID: <2024051930-canteen-produce-1ba7@gregkh> References: <20240519074019.10424-1-val@packett.cool> <2024051936-cosmetics-seismic-9fea@gregkh> <0C5QDS.UDESKUXHKPET1@packett.cool> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0C5QDS.UDESKUXHKPET1@packett.cool> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240519_015443_295496_85004DFE X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 19, 2024 at 05:38:24AM -0300, Val Packett wrote: > > > On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH > wrote: > > On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > > > On the RK3066, there is a bit that must be cleared on flush, > > > otherwise > > > we do not get display output (at least for RGB). > > > > What commit id does this fix? > > I guess: f4a6de855e "drm: rockchip: vop: add rk3066 vop definitions" ? Great, can you add a Fixes: tag when you resend these? > But similar changes like: > 742203cd "drm: rockchip: add missing registers for RK3066" > 8d544233 "drm/rockchip: vop: Add directly output rgb feature for px30" > did not have any "Fixes" reference. Just because people didn't properly tag things in the past, doesn't mean you should perpetuate that problem :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel