From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78836C25B78 for ; Mon, 20 May 2024 21:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SZixobxWYEryI5/YozqO23NHlNT0pUnL+j15yR2FoHw=; b=euRJ5UjpfOVo22 JDqiKjnXucx3qd7tDcXmp/o7zNIfIzqtonX/2jFz20l23LMrCOZYn6NBkkU8c8QO2fef4FekB3+rE sycdGCUPm96u3Z0ol4VHUOO9hOYI4JafYm1393k5DUV3Y+hrb4yy4T0UfcjwveQmB0WotYrxJWuPI t9KTdkiTd9WRgBF4eIfQ4RHDPWkVrBMa3S88UF9X2yBYSuzeCC7vfgOkY/ZAd3s0NAgVNovtr0el9 I/sKJKkgN3zCyhXr5wISgWXLRAVcgp7MGKxKQ6++tWWbCWjVb6LP514OK3jld0NzikbkmdWm+MXul T9lKC4JsAPNMSYYX8y5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9AEJ-0000000FYTp-2ZGf; Mon, 20 May 2024 21:07:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9AEG-0000000FYTG-1FrJ; Mon, 20 May 2024 21:07:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6944461DED; Mon, 20 May 2024 21:07:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D44D8C2BD10; Mon, 20 May 2024 21:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716239251; bh=X/NsTjluZhFUIdDleKVBp6yB9DdSZqAO99eq3Zz04l8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=COcLBCX11lfP8lavHY9s/toyqvSg0NurL5PdVAePq5mib/NEy463Muej/HOax+eLx y8tUmti4dWfu3xUUT+aiN0V10wxnYLZfqx9/Kzft/yecuvlfWMcGGJS7dDETp4Nnj8 oVse2C/FFlqR3oqzMmYrRH5KxPD0iQV2czPJvL620Ch4JyYAVSibMURUAhvbSqboem Ci/mnOigC+B/TR0Xqkvbdt19uMeQ6aXidSreVnfpI5Mh6mgKokpZxSIwcqp9pzYgBH cl3QgPwYIGSdITwSDB8ClhtRg2cjspJ3W6Rfg7htOz20Qct3H+qHF4S504N971qnHD yhFPwYQzEcTGw== Date: Mon, 20 May 2024 16:07:29 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Lee Jones , Krzysztof Kozlowski , Conor Dooley , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Nishanth Menon , Matthias Brugger , AngeloGioacchino Del Regno , Jiaxun Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 3/8] dt-bindings: soc: intel: lgm-syscon: Move to dedicated schema Message-ID: <20240520210729.GA1509114-robh@kernel.org> References: <20240519-dt-bindings-mfd-syscon-split-v1-0-aaf996e2313a@linaro.org> <20240519-dt-bindings-mfd-syscon-split-v1-3-aaf996e2313a@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240519-dt-bindings-mfd-syscon-split-v1-3-aaf996e2313a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_140732_451540_488E348F X-CRM114-Status: GOOD ( 19.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 19, 2024 at 08:42:18PM +0200, Krzysztof Kozlowski wrote: > intel,lgm-syscon is not a simple syscon device - it has children - thus > it should be fully documented in its own binding. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Context might depend on > https://lore.kernel.org/r/20240510123018.3902184-1-robh@kernel.org > and also further patches here depend on this one. > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 - > .../bindings/soc/intel/intel,lgm-syscon.yaml | 53 ++++++++++++++++++++++ > 2 files changed, 53 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 622ea0f1b08e..5a0aeae24a50 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -77,7 +77,6 @@ properties: > - hisilicon,pcie-sas-subctrl > - hisilicon,peri-subctrl > - hpe,gxp-sysreg > - - intel,lgm-syscon > - loongson,ls1b-syscon > - loongson,ls1c-syscon > - lsi,axxia-syscon > diff --git a/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml > new file mode 100644 > index 000000000000..aa8d24074fd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/intel/intel,lgm-syscon.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/intel/intel,lgm-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel Lightning Mountain(LGM) Syscon > + > +maintainers: > + - Ramuthevar Vadivel Murugan > + > +properties: > + compatible: > + items: > + - const: intel,lgm-syscon > + - const: syscon > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 Should have ranges. > + > +patternProperties: > + "^emmc-phy@[0-9a-f]+$": > + $ref: /schemas/phy/intel,lgm-emmc-phy.yaml# > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + - | > + chiptop@e0200000 { > + compatible = "intel,lgm-syscon", "syscon"; > + reg = <0xe0200000 0x100>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + emmc-phy@a8 { > + compatible = "intel,lgm-emmc-phy"; > + reg = <0x00a8 0x10>; > + clocks = <&emmc>; > + #phy-cells = <0>; > + }; > + }; > > -- > 2.43.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel