From: Chen-Yu Tsai <wenst@chromium.org>
To: Simon Glass <sjg@chromium.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: [PATCH 1/2] scripts/make_fit: Drop fdt image entry compatible string
Date: Tue, 21 May 2024 14:51:04 +0800 [thread overview]
Message-ID: <20240521065107.30371-2-wenst@chromium.org> (raw)
In-Reply-To: <20240521065107.30371-1-wenst@chromium.org>
According to the FIT image spec, the compatible string in the fdt image
node or any image node specifies the method to load the image, not the
compatible string embedded in the FDT or used for matching.
Drop the compatible string from the fdt image entry node.
While at it also fix up a typo in the document section of output_dtb.
Fixes: 7a23b027ec17 ("arm64: boot: Support Flat Image Tree")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
scripts/make_fit.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/make_fit.py b/scripts/make_fit.py
index 3de90c5a094b..263147df80a4 100755
--- a/scripts/make_fit.py
+++ b/scripts/make_fit.py
@@ -190,7 +190,7 @@ def output_dtb(fsw, seq, fname, arch, compress):
Args:
fsw (libfdt.FdtSw): Object to use for writing
seq (int): Sequence number (1 for first)
- fmame (str): Filename containing the DTB
+ fname (str): Filename containing the DTB
arch: FIT architecture, e.g. 'arm64'
compress (str): Compressed algorithm, e.g. 'gzip'
@@ -211,7 +211,6 @@ def output_dtb(fsw, seq, fname, arch, compress):
fsw.property_string('type', 'flat_dt')
fsw.property_string('arch', arch)
fsw.property_string('compression', compress)
- fsw.property('compatible', bytes(compat))
with open(fname, 'rb') as inf:
compressed = compress_data(inf, compress)
--
2.45.0.215.g3402c0e53f-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-21 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 6:51 [PATCH 0/2] scripts/make_fit fix and disabled compression for DTBs Chen-Yu Tsai
2024-05-21 6:51 ` Chen-Yu Tsai [this message]
2024-05-23 17:19 ` [PATCH 1/2] scripts/make_fit: Drop fdt image entry compatible string Simon Glass
2024-05-23 17:30 ` Chen-Yu Tsai
2024-05-23 17:38 ` Simon Glass
2024-05-24 6:29 ` Chen-Yu Tsai
2024-05-24 13:01 ` Simon Glass
2024-05-28 8:31 ` Chen-Yu Tsai
2024-05-28 14:14 ` Simon Glass
2024-05-21 6:51 ` [PATCH 2/2] scripts/make_fit: Add option to disable compression for DTBs Chen-Yu Tsai
2024-05-22 13:08 ` [PATCH 0/2] scripts/make_fit fix and disabled " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521065107.30371-2-wenst@chromium.org \
--to=wenst@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).