[PATCH 1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz Xtal on i.MX8MM Menlo board

[PATCH 1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz Xtal on i.MX8MM Menlo board

[Marek Vasut]

The i.MX8MM Menlo carrier board uses dedicated 20 MHz Xtal to supply
clock to second SPI CAN controller on the carrier board as well as
CPLD on the same board. Fix incorrect reuse of SoM 20 MHz Xtal for
that purpose, describe the separate Xtal and use it.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
index 0b123a84018b2..4c38979f7333f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
@@ -14,6 +14,13 @@ / {
 		     "toradex,verdin-imx8mm",
 		     "fsl,imx8mm";
 
+	/* Carrier board Xtal for SPI CAN controller and CPLD */
+	clk20mcb: clk-20m-cb {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <20000000>;
+	};
+
 	/delete-node/ gpio-keys;
 
 	leds {
@@ -60,7 +67,7 @@ &ecspi1 {
 	/* CAN controller on the baseboard */
 	canfd: can@0 {
 		compatible = "microchip,mcp2518fd";
-		clocks = <&clk_xtal20>;
+		clocks = <&clk20mcb>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
 		reg = <0>;
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/3] arm64: dts: imx8mm: Avoid iMX8MM errata ERR050080 on i.MX8MM Menlo board

[Marek Vasut]

i.MX8MM Mask Set Errata for Mask 0N87W, Rev. 1, 09/2021 document has the
following errata, which could affect the beeper and the LEDs. The beeper
has external pull down and it is likely gonna be off most of the time, so
disable pull resistors altogether. The LEDs do not have any external pull
resistors, so enable internal pull down, as they are also likely gonna be
off most of the time. The rest of the IO is not affected by the errata,
as it is not being driven against the pull resistor for the majority of
uptime.

"
ERR050080:
IO: Degradation of internal IO pullup/pulldown current capability for
    IO's continuously driven in a 3.3V operating mode
Description:
    There is a degradation of the internal IO pullup/pulldown capability
    when the IO pads are continuously driven in the opposite logic level,
    for example, when internal pullup is enabled with external logic
    driving the pin low, and a 3.3V operating condition which limits
    the pads pullup/pulldown ability.

    All IO pin groups are impacted except for XTAL, DDR, PCI, USB, and
    MIPI PHY IO’s.
Workaround:
    Where the IO’s are used for 3.3V operation and the circuit requires
    pullup or pulldown, use external resistors for the pullup/pulldown
    and disable the internal pullup/pulldown via software.
"

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
index 4c38979f7333f..ed83a019159ac 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
@@ -210,7 +210,7 @@ &iomuxc {
 
 	pinctrl_beeper: beepergrp {
 		fsl,pins = <
-			MX8MM_IOMUXC_SPDIF_TX_GPIO5_IO3			0x1c4
+			MX8MM_IOMUXC_SPDIF_TX_GPIO5_IO3			0x4
 		>;
 	};
 
@@ -225,8 +225,8 @@ MX8MM_IOMUXC_ECSPI1_SS0_GPIO5_IO9		0x1c4
 
 	pinctrl_led: ledgrp {
 		fsl,pins = <
-			MX8MM_IOMUXC_SAI1_TXD6_GPIO4_IO18		0x1c4
-			MX8MM_IOMUXC_SAI1_TXFS_GPIO4_IO10		0x1c4
+			MX8MM_IOMUXC_SAI1_TXD6_GPIO4_IO18		0x184
+			MX8MM_IOMUXC_SAI1_TXFS_GPIO4_IO10		0x184
 		>;
 	};
 
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/3] arm64: dts: imx8mm: Delete SoM hwmon node on i.MX8MM Menlo board

[Marek Vasut]

The INA239 is not populated on the SoM variant used in i.MX8MM Menlo
carrier board, delete the unused hwmon node just like the rest of the
unused nodes which are already deleted.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
index ed83a019159ac..b8dc7b299f94c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
@@ -197,6 +197,7 @@ &i2c3 {
 &i2c4 {
 	/* None of this is present on the SoM. */
 	/delete-node/ bridge@2c;
+	/delete-node/ hwmon@40;
 	/delete-node/ hdmi@48;
 	/delete-node/ touch@4a;
 	/delete-node/ sensor@4f;
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz Xtal on i.MX8MM Menlo board

[Peng Fan]

> Subject: [PATCH 1/3] arm64: dts: imx8mm: Describe carrier board 20 MHz
> Xtal on i.MX8MM Menlo board
> 
> The i.MX8MM Menlo carrier board uses dedicated 20 MHz Xtal to supply
> clock to second SPI CAN controller on the carrier board as well as CPLD on the
> same board. Fix incorrect reuse of SoM 20 MHz Xtal for that purpose,
> describe the separate Xtal and use it.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> index 0b123a84018b2..4c38979f7333f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> @@ -14,6 +14,13 @@ / {
>  		     "toradex,verdin-imx8mm",
>  		     "fsl,imx8mm";
> 
> +	/* Carrier board Xtal for SPI CAN controller and CPLD */
> +	clk20mcb: clk-20m-cb {

Per fixed-clock.yaml, nodename should be clock-xx.

Regards,
Peng.

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <20000000>;
> +	};
> +
>  	/delete-node/ gpio-keys;
> 
>  	leds {
> @@ -60,7 +67,7 @@ &ecspi1 {
>  	/* CAN controller on the baseboard */
>  	canfd: can@0 {
>  		compatible = "microchip,mcp2518fd";
> -		clocks = <&clk_xtal20>;
> +		clocks = <&clk20mcb>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
>  		reg = <0>;
> --
> 2.43.0
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel