public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated
@ 2024-05-21 10:40 Marek Vasut
  2024-05-21 12:29 ` Laurent Pinchart
  2024-05-21 14:22 ` Rob Herring (Arm)
  0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2024-05-21 10:40 UTC (permalink / raw)
  To: devicetree
  Cc: Marek Vasut, Andrzej Hajda, Conor Dooley, Daniel Vetter,
	David Airlie, Fabio Estevam, Jernej Skrabec, Jonas Karlman,
	Krzysztof Kozlowski, Laurent Pinchart, Liu Ying,
	Maarten Lankhorst, Mark Yao, Maxime Ripard, Neil Armstrong,
	Pengutronix Kernel Team, Philipp Zabel, Rob Herring, Robert Foss,
	Sascha Hauer, Shawn Guo, Thomas Zimmermann, dri-devel, imx,
	kernel, linux-arm-kernel

The ddc-i2c-bus property should be placed in connector node,
mark the HDMI TX side property as deprecated.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mark Yao <markyao0591@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
---
 .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml     | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
index 828709a8ded26..d09a0bee54247 100644
--- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
@@ -47,6 +47,7 @@ properties:
 
   ddc-i2c-bus:
     $ref: /schemas/types.yaml#/definitions/phandle
+    deprecated: true
     description:
       The HDMI DDC bus can be connected to either a system I2C master or the
       functionally-reduced I2C master contained in the DWC HDMI. When connected
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated
  2024-05-21 10:40 [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated Marek Vasut
@ 2024-05-21 12:29 ` Laurent Pinchart
  2024-05-21 12:39   ` Neil Armstrong
  2024-05-21 14:22 ` Rob Herring (Arm)
  1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2024-05-21 12:29 UTC (permalink / raw)
  To: Marek Vasut
  Cc: devicetree, Andrzej Hajda, Conor Dooley, Daniel Vetter,
	David Airlie, Fabio Estevam, Jernej Skrabec, Jonas Karlman,
	Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Mark Yao,
	Maxime Ripard, Neil Armstrong, Pengutronix Kernel Team,
	Philipp Zabel, Rob Herring, Robert Foss, Sascha Hauer, Shawn Guo,
	Thomas Zimmermann, dri-devel, imx, kernel, linux-arm-kernel

Hi Marek,

Thank you for the patch.

On Tue, May 21, 2024 at 12:40:47PM +0200, Marek Vasut wrote:
> The ddc-i2c-bus property should be placed in connector node,
> mark the HDMI TX side property as deprecated.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Mark Yao <markyao0591@gmail.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml     | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 828709a8ded26..d09a0bee54247 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -47,6 +47,7 @@ properties:
>  
>    ddc-i2c-bus:
>      $ref: /schemas/types.yaml#/definitions/phandle
> +    deprecated: true
>      description:
>        The HDMI DDC bus can be connected to either a system I2C master or the
>        functionally-reduced I2C master contained in the DWC HDMI. When connected

How about adding an additional sentence here to explain what should be
used instead ?

       to a system I2C master this property contains a phandle to that I2C
       master controller.
+
+      This property is deprecated, the system I2C master controller should
+      be referenced through the ddc-i2c-bus property of the HDMI connector
+      node.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated
  2024-05-21 12:29 ` Laurent Pinchart
@ 2024-05-21 12:39   ` Neil Armstrong
  0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2024-05-21 12:39 UTC (permalink / raw)
  To: Laurent Pinchart, Marek Vasut
  Cc: devicetree, Andrzej Hajda, Conor Dooley, Daniel Vetter,
	David Airlie, Fabio Estevam, Jernej Skrabec, Jonas Karlman,
	Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Mark Yao,
	Maxime Ripard, Pengutronix Kernel Team, Philipp Zabel,
	Rob Herring, Robert Foss, Sascha Hauer, Shawn Guo,
	Thomas Zimmermann, dri-devel, imx, kernel, linux-arm-kernel

On 21/05/2024 14:29, Laurent Pinchart wrote:
> Hi Marek,
> 
> Thank you for the patch.
> 
> On Tue, May 21, 2024 at 12:40:47PM +0200, Marek Vasut wrote:
>> The ddc-i2c-bus property should be placed in connector node,
>> mark the HDMI TX side property as deprecated.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> Cc: Jonas Karlman <jonas@kwiboo.se>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: Liu Ying <victor.liu@nxp.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Mark Yao <markyao0591@gmail.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: devicetree@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: imx@lists.linux.dev
>> Cc: kernel@dh-electronics.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>>   .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml     | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
>> index 828709a8ded26..d09a0bee54247 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
>> @@ -47,6 +47,7 @@ properties:
>>   
>>     ddc-i2c-bus:
>>       $ref: /schemas/types.yaml#/definitions/phandle
>> +    deprecated: true
>>       description:
>>         The HDMI DDC bus can be connected to either a system I2C master or the
>>         functionally-reduced I2C master contained in the DWC HDMI. When connected
> 
> How about adding an additional sentence here to explain what should be
> used instead ?
> 
>         to a system I2C master this property contains a phandle to that I2C
>         master controller.
> +
> +      This property is deprecated, the system I2C master controller should
> +      be referenced through the ddc-i2c-bus property of the HDMI connector
> +      node.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

With the additional sentence:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated
  2024-05-21 10:40 [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated Marek Vasut
  2024-05-21 12:29 ` Laurent Pinchart
@ 2024-05-21 14:22 ` Rob Herring (Arm)
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-05-21 14:22 UTC (permalink / raw)
  To: Marek Vasut
  Cc: dri-devel, David Airlie, Conor Dooley, kernel, Thomas Zimmermann,
	Andrzej Hajda, Robert Foss, linux-arm-kernel, devicetree,
	Maxime Ripard, Laurent Pinchart, imx, Krzysztof Kozlowski,
	Fabio Estevam, Philipp Zabel, Shawn Guo, Jonas Karlman,
	Pengutronix Kernel Team, Neil Armstrong, Maarten Lankhorst,
	Mark Yao, Daniel Vetter, Jernej Skrabec, Liu Ying, Sascha Hauer


On Tue, 21 May 2024 12:40:47 +0200, Marek Vasut wrote:
> The ddc-i2c-bus property should be placed in connector node,
> mark the HDMI TX side property as deprecated.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Mark Yao <markyao0591@gmail.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml     | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-21 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 10:40 [PATCH] dt-bindings: display: synopsys,dw-hdmi: Mark ddc-i2c-bus as deprecated Marek Vasut
2024-05-21 12:29 ` Laurent Pinchart
2024-05-21 12:39   ` Neil Armstrong
2024-05-21 14:22 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox