From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BAA2C25B74 for ; Tue, 21 May 2024 18:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dxjf8RndL4y/T5ptWaNVx60v/Vl9dm1FQD6jPHcDXxA=; b=MW5/l7izpotgeu 3CImRkVJPYOaqQqbeJXyL9vdhLm51Ht4qTNj5pFytZYMd4GpZEcjjO9G6S0EIyjinCwqgTeFpHkd+ hw7X0OIYvE/wo4bvNbkhtEvX6qrCsXgxlNZJFxkPVw7S3nqCNvI5kgyUP4Wrjd8kULFKfocWkhyUC AAlDl0VqlWmuHZSB2QYWu+qSdjGXmn6Z4uJr6E5a+6NywLi1lsJZnOw5w4mwTUQr9SRxX4UxoWDi0 RtQKi1oILQVgKqgUd7lVEzBo05aohFG8EdCfL8k3KhUsgpAlI2/DauI7Gb/BDm/zR3vVHHzUxPCPt UUY6b0fQ/3ybuDuiFn3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9UK6-00000000mWB-2Av9; Tue, 21 May 2024 18:34:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9UK4-00000000mVl-1bin for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 18:34:53 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C66CB6241B; Tue, 21 May 2024 18:34:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31A35C2BD11; Tue, 21 May 2024 18:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716316490; bh=xuaEi37hbIILUT2lAX0OwqbMbYbwhS0HahEYD+jR+N4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c5kUGmrqMC3z+Ni6ppmgJfteqNcFuNQTdMr6y9MX9TTf83Bvbl5dwIzMFC7nrm1pC J7eo1TzbvpoAu5CQsrVE3dm3onMAyoHXH9AxkY/FIxankCducOyujTMxR4PJ7ce4Qk piKQKydlK4h4d+vszUFws7HA7JrZOarrCumWxuMKhFQl0AoiOqeDEuP+cuKDdFM2pO 8Xc3XaRP8Vn0tvhhaxX/2Cq9y8v17ZHB/gL9WaUgSA4LxjTC9cx8+Sjd8o3vupNnrC EQ0H05pgI6PZYNH3v4quYBX8DCHvpt75dmHGA3mTc35kUcQ16kDeB2r3d1A15olvFK V+srNuC8Kt48g== Date: Tue, 21 May 2024 19:34:45 +0100 From: Will Deacon To: Johannes Nixdorf Cc: Marc Zyngier , Ard Biesheuvel , Mark Brown , linux-arm-kernel@lists.infradead.org, Janne Grunau Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Message-ID: <20240521183445.GA7154@willie-the-truck> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240521_113452_611583_C859BD11 X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johannes, On Tue, May 21, 2024 at 08:22:08AM +0200, Johannes Nixdorf wrote: > Bad news: I hit the bug again with 2632e2521769 ("arm64: fpsimd: Implement > lazy restore for kernel mode FPSIMD") reverted during prolonged interactive > usage with the downstream Asahi Linux kernel. Damn, but thanks for the update. I have to ask, but are you absolutely sure this was with 2632e2521769 reverted? If you're able to double-check that, it would be great, since we're having trouble reproducing the issue. > This prompted me to adjust the reproducer to be closer to the desktop use > case, which then also found aefbab8e77eb ("arm64: fpsimd: Preserve/restore > kernel mode NEON at context switch"). With the vanilla kernel before the > commit or that commit reverted on the Asahi Linux kernel the new reproducer > also sees no bug, and interactive usage seems fine. I've already reverted 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD"), so it sounds like I should revert aefbab8e77eb ("arm64: fpsimd: Preserve/restore kernel mode NEON at context switch") as well while we work to reproduce the issue. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel