From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A69DC25B78 for ; Wed, 22 May 2024 22:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=yYRZuWpix3tcEzTxSdS+TUJIvOs96OYilV4hox32Mrs=; b=1SZlhW2doZGrN0 tsW96pdxYnl3Q1MoAjdfcdwmrzIDS98GpuxNg0kPaC1maToBL7pSc9nTO3JO+ws7qP/fBPx1et93m l28BA+swBG2SxBZQgCJwJ8JZ00ruk8oAaiWUsurkZ2mYnOpCFrvWXlPtHrecZUFqlVdf49JUELPX0 auXAiIaDhxuxRDHYTwuXxRejLn68fgsc/YETkCkCPHg+spbFgZCSKINInkU2z272rjEKJmnMYx7qA DpNRiIsuCzyRd/HvII3lAqoLufe22V+KWiYsu6D3+lvB7TbYAV4kP8wX8aMxigRuGBs3mAXcS1spc GkddIJ9GsE6Y7ulFaAjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9uRy-00000004HNk-0wA7; Wed, 22 May 2024 22:28:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9uRs-00000004HMU-3r5p for linux-arm-kernel@lists.infradead.org; Wed, 22 May 2024 22:28:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2CE3162B7C; Wed, 22 May 2024 22:28:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD247C2BBFC; Wed, 22 May 2024 22:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716416920; bh=FyDYtMT/2nQuK4XVRGpg4ULNIilNC8aI7hQ/yAbnWms=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gluCjXV/cS6TMjmiB4c6zKFpfxBVeYDczAlUg6W/JLtLxMPtImzQMvnjf9A+t7VIK uDbNq3WmWVczLwFlWgq+wcDcktc17i3e4yaDT6A2nladW75Fg5OImyC9uZwjYF5vTA f+NbS5JrNlVD3jD/XVSjogkAvsewrhQUlMvlfHNdnjZyLZLPupEQw37cEgZPjfAy17 Ax9dlOzm14HefTumxgJyGYv7mF/VLWWXDotCT/gID0HdWrB4V392HDTte33b1a0jGm uxygzqywCVWx4FGqkAMmQflEjIBGqVzXyDahXa4ecaYsGbiPAtvzIi341WCut2EHVx fYVS7cfIjrZbw== Date: Wed, 22 May 2024 17:28:38 -0500 From: Bjorn Helgaas To: Sean Anderson , g@bhelgaas Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , linux-pci@vger.kernel.org, Michal Simek , Thippeswamy Havalige , linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/7] dt-bindings: pci: xilinx-nwl: Add phys Message-ID: <20240522222838.GA101305@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240520145402.2526481-2-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_152843_045247_24439E8B X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 20, 2024 at 10:53:56AM -0400, Sean Anderson wrote: > Add phys properties so Linux can power-on/configure the GTR > transcievers. s/transcievers/transceivers/ Possibly s/phys/PHYs/ in subject, commit log, DT description to avoid confusion with "phys" (short for generic "physical"). Or maybe even just "PHY properties"? What does "GTR" mean? Possibly expand that? > Signed-off-by: Sean Anderson > --- > > Changes in v3: > - Document phys property > > Changes in v2: > - Remove phy-names > - Add an example > > Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > index 426f90a47f35..cc50795d170b 100644 > --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > @@ -61,6 +61,11 @@ properties: > interrupt-map: > maxItems: 4 > > + phys: > + minItems: 1 > + maxItems: 4 > + description: One phy per logical lane, in order > + > power-domains: > maxItems: 1 > > @@ -110,6 +115,7 @@ examples: > - | > #include > #include > + #include > #include > soc { > #address-cells = <2>; > @@ -138,6 +144,7 @@ examples: > <0x0 0x0 0x0 0x3 &pcie_intc 0x3>, > <0x0 0x0 0x0 0x4 &pcie_intc 0x4>; > msi-parent = <&nwl_pcie>; > + phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>; > power-domains = <&zynqmp_firmware PD_PCIE>; > iommus = <&smmu 0x4d0>; > pcie_intc: legacy-interrupt-controller { > -- > 2.35.1.1320.gc452695387.dirty > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel