* [PATCH] arm64: dts: allwinner: convert NanoPi R1S H5 NVMEM content to layout syntax
@ 2024-05-24 12:56 Rafał Miłecki
2024-05-24 18:52 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2024-05-24 12:56 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-sunxi, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
Use cleaner (and non-deprecated) bindings syntax. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
index 3a7ee44708a2..36e46e40b8f8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
@@ -146,11 +146,15 @@ eeprom@51 {
reg = <0x51>;
pagesize = <16>;
read-only;
- #address-cells = <1>;
- #size-cells = <1>;
- eth_mac1: mac-address@fa {
- reg = <0xfa 0x06>;
+ nvmem-layout {
+ compatible = "fixed-layout";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ eth_mac1: mac-address@fa {
+ reg = <0xfa 0x06>;
+ };
};
};
};
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: convert NanoPi R1S H5 NVMEM content to layout syntax
2024-05-24 12:56 [PATCH] arm64: dts: allwinner: convert NanoPi R1S H5 NVMEM content to layout syntax Rafał Miłecki
@ 2024-05-24 18:52 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2024-05-24 18:52 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-arm-kernel,
linux-sunxi, Rafał Miłecki
On Fri, 24 May 2024 14:56:17 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
Hi Rafał,
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Use cleaner (and non-deprecated) bindings syntax. See commit
> bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> details.
Is there anything that this commit fixes, or is it just "nicer"?
If I see this correctly, then this commit would break with older
kernels, or more precisely anything that doesn't support the
"fixed-layout" compatible string, right?
For sunxi we try to keep the DTs compatible both ways, so that the
latest DT (as imported in U-Boot, for instance), can run with both
older stable and the newest kernels.
Cheers,
Andre
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> index 3a7ee44708a2..36e46e40b8f8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> @@ -146,11 +146,15 @@ eeprom@51 {
> reg = <0x51>;
> pagesize = <16>;
> read-only;
> - #address-cells = <1>;
> - #size-cells = <1>;
>
> - eth_mac1: mac-address@fa {
> - reg = <0xfa 0x06>;
> + nvmem-layout {
> + compatible = "fixed-layout";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + eth_mac1: mac-address@fa {
> + reg = <0xfa 0x06>;
> + };
> };
> };
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-24 18:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-24 12:56 [PATCH] arm64: dts: allwinner: convert NanoPi R1S H5 NVMEM content to layout syntax Rafał Miłecki
2024-05-24 18:52 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).