Re: [PATCH v2 2/8] dt-bindings: counter: Add new ti,am62-eqep compatible

From: Conor Dooley <conor@kernel.org>
To: Judith Mendez <jm@ti.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	William Breathitt Gray <william.gray@linaro.org>,
	David Lechner <david@lechnology.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 2/8] dt-bindings: counter: Add new ti,am62-eqep compatible
Date: Sat, 25 May 2024 16:23:52 +0100	[thread overview]
Message-ID: <20240525-tall-cultural-1a3f181d39ac@spud> (raw)
In-Reply-To: <57e4f7b1-2955-4dd5-b9d9-f3b1f27aab75@ti.com>

[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]

On Fri, May 24, 2024 at 04:30:32PM -0500, Judith Mendez wrote:
> On 5/24/24 1:38 PM, Conor Dooley wrote:
> > On Thu, May 23, 2024 at 06:15:10PM -0500, Judith Mendez wrote:
> > > Add new compatible ti,am62-eqep for TI K3 devices. If a device
> > > uses this compatible, require power-domains property.
> > > 
> > > Since there is only one functional and interface clock for eqep,
> > > clock-names is not really required. The clock-name also changed
> > > for TI K3 SoCs so make clock-names optional for the new compatible
> > > since there is only one clock that is routed to the IP.
> > 
> > Really the clock should be named after the function it has in the IP
> > block - it looks like "sysoutclk" is more likely the name of the clock
> > routed to the IP rather than the role it has?
> 
> It is the name of the clock, though id like to keep sysclkout for
> backwards compatibility, even though the name is confusing.

FWIW, I was not suggesting that it be renamed.

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel