From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AA15C25B74 for ; Mon, 27 May 2024 09:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HJJU6EB1arYVEKv1p9wgR0dZu7mHfhOXcS9fApq5BVk=; b=jyVe/evkJP0T9KFpP/OT4CHoZ9 RKOdkOAZQgYOaLlZUssmGBY6LMvJw728Q5N/dkeWNUF91vHxiEc4BOUlwQ6kcpQTaY37qjW289Q6k rGs+wpUz9dzGnHLPqA19Fi9KQ2KEQix32fkWSWKoqp98XdDe0YUdGTKsB+JB7sCtQxpW5w1irvR4r v9aETyoeMArqB2rBL2n3+CBMRQ6yYI2XQQm5kCDVuKfO+rIpFf0Wb3wHJKHWL+YfuoHHWL23iDxlt JQ8saeTpjQwCnYWMVMyLekeV7dvd5vKS+Wrg6lnleNekTuZlqozOxAcDG8rqjKF8qbWrcYMikYBXD beCEuTmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBWFL-0000000ELCY-32ze; Mon, 27 May 2024 09:02:23 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBWFI-0000000ELBl-3meT; Mon, 27 May 2024 09:02:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 81B04CE0B26; Mon, 27 May 2024 09:02:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A944C2BBFC; Mon, 27 May 2024 09:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716800536; bh=uYAFBgtM5vXI9g7/LeVQ+pczQ1yooR+keQpxvhcuA8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TRMPiNiIHap5cUpLkC3niSfLnS5r5ay/7/AKD7dAXmxw4VtzFUte71pZ8s4wYxN6C 5N7gB4+obnBGFvTNNxSuXzK/U5TbAzL9ZplGMilaZr1KdblJ6LczlqxIQ8GuuBy7nc 9i1Xee/2KLe/dEp3NpfRWXYMXpQGjWGZRqeXwpsjJf83/GO2GxAql5Y4nbHCV2YGjz rYh02qQutduLCSqGeaeXpUEYU9uSWnlHpo/iwn2FqW2k+BzSyYmty//oZ6FRorGIBN +xcOBIRc0ZuQyvFii3U1AO5zNKn47fmXCnneBR7Hq+ycIaKg4tSKiWLgwSvWA5gvkB +hbDCAwtJxCnQ== Date: Mon, 27 May 2024 11:02:13 +0200 From: Maxime Ripard To: Dmitry Baryshkov Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andy Yan , Hans Verkuil , Sebastian Wick , Ville =?utf-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Dave Stevenson , Pekka Paalanen Subject: Re: [PATCH v14 17/28] drm/connector: hdmi: Add Broadcast RGB property Message-ID: <20240527-adamant-just-spaniel-ebed4e@houat> References: <20240521-kms-hdmi-connector-state-v14-0-51950db4fedb@kernel.org> <20240521-kms-hdmi-connector-state-v14-17-51950db4fedb@kernel.org> <4n55dbl2h275z5ubebigri4xjtjsvt44w62n656srdgndcav2j@rrq5haucqx5u> MIME-Version: 1.0 In-Reply-To: <4n55dbl2h275z5ubebigri4xjtjsvt44w62n656srdgndcav2j@rrq5haucqx5u> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240527_020221_335799_0FB36146 X-CRM114-Status: GOOD ( 26.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5898026537761249179==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5898026537761249179== Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="wqcwbvnihqwt2l7e" Content-Disposition: inline --wqcwbvnihqwt2l7e Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks again for that thorough review :) On Thu, May 23, 2024 at 01:22:56PM GMT, Dmitry Baryshkov wrote: > On Tue, May 21, 2024 at 12:13:50PM +0200, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > > The vc4 driver then implemented the same property with the same > > semantics. KWin has support for it, and a PR for mutter is also there to > > support it. > >=20 > > Both drivers implementing the same property with the same semantics, > > plus the userspace having support for it, is proof enough that it's > > pretty much a de-facto standard now and we can provide helpers for it. > >=20 > > Let's plumb it into the newly created HDMI connector. > >=20 > > Reviewed-by: Dave Stevenson > > Acked-by: Pekka Paalanen > > Reviewed-by: Sebastian Wick > > Signed-off-by: Maxime Ripard > > --- > > Documentation/gpu/kms-properties.csv | 1 - > > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 4 +- > > drivers/gpu/drm/drm_atomic.c | 2 + > > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ > > drivers/gpu/drm/drm_connector.c | 88 +++++++++++++++++= ++++++++ > > include/drm/drm_connector.h | 36 ++++++++++ > > 6 files changed, 133 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/gpu/kms-properties.csv b/Documentation/gpu/k= ms-properties.csv > > index 0f9590834829..caef14c532d4 100644 > > --- a/Documentation/gpu/kms-properties.csv > > +++ b/Documentation/gpu/kms-properties.csv > > @@ -15,11 +15,10 @@ Owner Module/Drivers,Group,Property Name,Type,Prope= rty Values,Object attached,De > > ,,=E2=80=9Csaturation=E2=80=9D,RANGE,"Min=3D0, Max=3D100",Connector,TBD > > ,,=E2=80=9Chue=E2=80=9D,RANGE,"Min=3D0, Max=3D100",Connector,TBD > > ,Virtual GPU,=E2=80=9Csuggested X=E2=80=9D,RANGE,"Min=3D0, Max=3D0xfff= fffff",Connector,property to suggest an X offset for a connector > > ,,=E2=80=9Csuggested Y=E2=80=9D,RANGE,"Min=3D0, Max=3D0xffffffff",Conn= ector,property to suggest an Y offset for a connector > > ,Optional,"""aspect ratio""",ENUM,"{ ""None"", ""4:3"", ""16:9"" }",Co= nnector,TDB > > -i915,Generic,"""Broadcast RGB""",ENUM,"{ ""Automatic"", ""Full"", ""Li= mited 16:235"" }",Connector,"When this property is set to Limited 16:235 an= d CTM is set, the hardware will be programmed with the result of the multip= lication of CTM by the limited range matrix to ensure the pixels normally i= n the range 0..1.0 are remapped to the range 16/255..235/255." >=20 > Should it still be defined as a generic property? I'm not sure what you mean here, sorry. It's being documented as a connector property now, so it's very much still listed as a generic property? Maxime --wqcwbvnihqwt2l7e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZlRMEAAKCRAnX84Zoj2+ dhGAAYDS1llqP+ICZyWXx+g6L1EiXrG7OIB0z7t7KF3yJW5Y1zN4+dIvVNhFS6LU gAXKTp4BgKUepq65FIlFjrRN3gyXTVxmbiIMJd5mPgjySS4scgX65VNBO5cc0Qvt qThCHUrQ2A== =K55A -----END PGP SIGNATURE----- --wqcwbvnihqwt2l7e-- --===============5898026537761249179== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5898026537761249179==--