From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2009C25B74 for ; Mon, 27 May 2024 17:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jz+oqOa1y7e2UBP2E7a/PphbhZW6OSFakxlOS6Ds4rQ=; b=VjO9GF5wz/K0L4ECoYksnu1KxL anjwir1HFZXImKKySVyXca+mQTSWRB4Txu6z22gCve6Msv3v3tZVROAO337AfpbRDSesONJgUm0Y5 IMZgWeKiCdnt9Dz5n7JZcl6tC2+Z9goinmIKaMj1phcQJQ4UzGNh85Abr2lxs01TxWWWtBoS3wy/a TUIbHIKMMFpcTp5C2Oq/N2iaDrUtCA+0du5f9mc1xgaNmH17BuEsngAOOhqNAI2hPBW//yOH3z1Or SRwce7pr2iUc5HwOxqUoJWaQWtDSsaf+qnJGETRahYq9yyO68HEzkqvL6+QmeG9kh11L1YA84mksw zycG7O6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBe9l-0000000Fy7o-0wSA; Mon, 27 May 2024 17:29:09 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBe9i-0000000Fy79-1jjs; Mon, 27 May 2024 17:29:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E364ACE0FFF; Mon, 27 May 2024 17:29:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03AB3C2BBFC; Mon, 27 May 2024 17:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716830942; bh=7i3HHxr+FZXrpHZk66CJoa9lBp61kJPFRiR8dLMG28U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H5uJoSqx3pJ+EzYT62rpf1TlQZ23hQZdtjGFmPN85Nji9cZDtYuv6V+smkqyDa0tC UwAwL4vwO8xLPz9e7trjDNstvhY2tCil6W8FKRJMW7Ey8Bh/f3+rPprBPP3q5xowQ4 47ORJPSJOe9uv4cSz8gJz/m9E8zJ/S8BB0yaiCU+pizhycf60XKq+05r5xNrnIzDda rSSf7Y4jV/FicQHw6V1b5C4VGRXRky8YIsmpGXFbtTkOva36k1CDq2nT3T+0FNi9IF A6ISG84RRuhHjHNkb/8qQaj6xmAi4PeUSOKIbQoYJRPwVDNVK/lkY9hd3xKIKsg4Vo 1qPZ1N53beKJQ== Date: Mon, 27 May 2024 18:28:56 +0100 From: Conor Dooley To: Julien Panis Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Lezcano , Nicolas Pitre , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v5 1/6] dt-bindings: thermal: mediatek: Rename thermal zone definitions for MT8186 and MT8188 Message-ID: <20240527-wife-dress-3ecaf1509506@spud> References: <20240524-mtk-thermal-mt818x-dtsi-v5-0-56f8579820e7@baylibre.com> <20240524-mtk-thermal-mt818x-dtsi-v5-1-56f8579820e7@baylibre.com> <20240524-concerned-fritter-262f5e16293e@spud> <20240524-clatter-antivirus-b1939900ee58@spud> <61a1be10-7df3-4ba7-b7b4-ccc7f0379656@baylibre.com> MIME-Version: 1.0 In-Reply-To: <61a1be10-7df3-4ba7-b7b4-ccc7f0379656@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240527_102906_834091_1AB4DDA8 X-CRM114-Status: GOOD ( 25.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7371420264727101430==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7371420264727101430== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bM4p+zZXQPt+WasM" Content-Disposition: inline --bM4p+zZXQPt+WasM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 27, 2024 at 05:25:35PM +0200, Julien Panis wrote: > On 5/24/24 20:27, Conor Dooley wrote: > > On Fri, May 24, 2024 at 07:24:47PM +0100, Conor Dooley wrote: > > > On Fri, May 24, 2024 at 11:04:34AM +0200, Julien Panis wrote: > > > > Use thermal zone names that make more sense. > > > >=20 > > > > Signed-off-by: Julien Panis > > > Removing the defines is an ABI break. If these are all the same devic= es, > > > but with more accurate naming, then keep the old defines and add new > > > ones. However, the GPU1 define changes in the course of this patch wh= ich > > > is more problematic. > > > > [RFC] When PATCH 1/6 and 2/6 are squashed, checkpatch raises this W= ARNING: > > > > "DT binding docs and includes should be a separate patch." That's w= hy I > > > > split them in this v5. The problem is that the driver can't be comp= iled > > > > any more at PATCH 1/6. It needs PATCH 2/6 to be compiled. Should the > > > > checkpatch warning be ignored here ? Should I finally squash PATCH = 1/6 > > > > and PATCH 2/6 ? > > Heh, and there's just one of the issues caused by your ABI break... >=20 > Conor, >=20 > Would Russell's suggestion be acceptable for you ? > I mean, this one: > https://lore.kernel.org/all/ZlDMNkdE2jmFgD8B@shell.armlinux.org.uk/ >=20 > I could implement it, but before submitting it I would like to make > sure that it suits everyone. How's that going to work? MT8188_AP_GPU1 currently means 1, after your series it means 2. You're gonna need to pick a different naming for the new defines to avoid that. Additionally, why even delete the old ones? Just define new names with the same numbering and you don't need to worry about any compatibility issues. Thanks, Conor. --bM4p+zZXQPt+WasM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlTC2AAKCRB4tDGHoIJi 0kYaAQCBeeWym98m0dKTR3H3Xk4DUECdqWHnyikIkpibSIdLBQEA0YSS+Kyv4IH8 jOjyvUdcAS6mMC++BHn0WX/1xnIDNwY= =lnm9 -----END PGP SIGNATURE----- --bM4p+zZXQPt+WasM-- --===============7371420264727101430== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7371420264727101430==--