linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings
@ 2024-05-28 14:22 Michael Tretter
  2024-05-28 14:22 ` [PATCH 1/2] arm64: zynqmp: Align nvmem-firmware with dt-binding Michael Tretter
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Tretter @ 2024-05-28 14:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michal Simek
  Cc: Michael Tretter, devicetree, linux-arm-kernel, kernel

Running make CHECK_DTBS=1 for any ZynqMP device trees prints warnings a
few warnings that are caused by the zynqmp.dtsi file.

Fix the zynqmp.dtsi to fix these warnings.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
Michael Tretter (2):
      arm64: zynqmp: Align nvmem-firmware with dt-binding
      arm64: zynqmp: Rename fpga-full to fpga-region

 arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240528-zynqmp-dt-a47093b45beb

Best regards,
-- 
Michael Tretter <m.tretter@pengutronix.de>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: zynqmp: Align nvmem-firmware with dt-binding
  2024-05-28 14:22 [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michael Tretter
@ 2024-05-28 14:22 ` Michael Tretter
  2024-05-28 14:22 ` [PATCH 2/2] arm64: zynqmp: Rename fpga-full to fpga-region Michael Tretter
  2024-05-28 14:55 ` [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michal Simek
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Tretter @ 2024-05-28 14:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michal Simek
  Cc: Michael Tretter, devicetree, linux-arm-kernel, kernel

The xlnx,zynqmp-firmware.yaml binding defines the soc-nvmem property
instead of firmware-nvmem:

	zynqmp-firmware: 'nvmem-firmware' does not match any of the regexes: 'pinctrl-[0-9]+'

Furthermore, the xlnx,zynqmp-nvmem.yaml uses an nvmem-layout subnode for
the layout definition:

	nvmem-firmware: Unevaluated properties are not allowed ('soc-revision@0' was unexpected)

Align the node with the specified dt-binding.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index d99830c9b85f..511a786c4b8b 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -207,13 +207,16 @@ zynqmp_power: power-management {
 				mbox-names = "tx", "rx";
 			};
 
-			nvmem-firmware {
+			soc-nvmem {
 				compatible = "xlnx,zynqmp-nvmem-fw";
-				#address-cells = <1>;
-				#size-cells = <1>;
-
-				soc_revision: soc-revision@0 {
-					reg = <0x0 0x4>;
+				nvmem-layout {
+					compatible = "fixed-layout";
+					#address-cells = <1>;
+					#size-cells = <1>;
+
+					soc_revision: soc-revision@0 {
+						reg = <0x0 0x4>;
+					};
 				};
 			};
 

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: zynqmp: Rename fpga-full to fpga-region
  2024-05-28 14:22 [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michael Tretter
  2024-05-28 14:22 ` [PATCH 1/2] arm64: zynqmp: Align nvmem-firmware with dt-binding Michael Tretter
@ 2024-05-28 14:22 ` Michael Tretter
  2024-05-28 14:55 ` [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michal Simek
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Tretter @ 2024-05-28 14:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michal Simek
  Cc: Michael Tretter, devicetree, linux-arm-kernel, kernel

The "fpga-region" compatible expects a node name "fpga-region".

Checking the ZynqMP device trees prints the following warning:

	fpga-full: $nodename:0: 'fpga-full' does not match '^fpga-region(@.*|-([0-9]|[1-9][0-9]+))?$'

Rename the node accordingly.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 511a786c4b8b..51235e6b6b4f 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -255,7 +255,7 @@ timer {
 			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
 	};
 
-	fpga_full: fpga-full {
+	fpga_full: fpga-region {
 		compatible = "fpga-region";
 		fpga-mgr = <&zynqmp_pcap>;
 		#address-cells = <2>;

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings
  2024-05-28 14:22 [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michael Tretter
  2024-05-28 14:22 ` [PATCH 1/2] arm64: zynqmp: Align nvmem-firmware with dt-binding Michael Tretter
  2024-05-28 14:22 ` [PATCH 2/2] arm64: zynqmp: Rename fpga-full to fpga-region Michael Tretter
@ 2024-05-28 14:55 ` Michal Simek
  2 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2024-05-28 14:55 UTC (permalink / raw)
  To: Michael Tretter, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-arm-kernel, kernel



On 5/28/24 16:22, Michael Tretter wrote:
> Running make CHECK_DTBS=1 for any ZynqMP device trees prints warnings a
> few warnings that are caused by the zynqmp.dtsi file.
> 
> Fix the zynqmp.dtsi to fix these warnings.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> Michael Tretter (2):
>        arm64: zynqmp: Align nvmem-firmware with dt-binding
>        arm64: zynqmp: Rename fpga-full to fpga-region
> 
>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)
> ---
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
> change-id: 20240528-zynqmp-dt-a47093b45beb
> 
> Best regards,

Already the part of

https://lore.kernel.org/r/cover.1716802450.git.michal.simek@amd.com

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-28 14:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 14:22 [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michael Tretter
2024-05-28 14:22 ` [PATCH 1/2] arm64: zynqmp: Align nvmem-firmware with dt-binding Michael Tretter
2024-05-28 14:22 ` [PATCH 2/2] arm64: zynqmp: Rename fpga-full to fpga-region Michael Tretter
2024-05-28 14:55 ` [PATCH 0/2] arm64: zynqmp: fix CHECK_DTBS warnings Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).