* [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call
@ 2024-05-28 12:02 Arnd Bergmann
2024-05-29 18:22 ` Tanmay Shah
2024-05-30 22:17 ` Tanmay Shah
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-05-28 12:02 UTC (permalink / raw)
To: Jassi Brar, Michal Simek, Tanmay Shah, Saeed Nowshadi
Cc: Arnd Bergmann, Ben Levinsky, Gustavo A. R. Silva, Rob Herring,
Uwe Kleine-König, linux-kernel, linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
irq_to_desc() is not exported to loadable modules, so this driver now
fails to link in some configurations:
ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined!
I can't see a purpose for this call, since the return value is unused
and probably left over from some code refactoring.
Address the link failure by just removing the line.
Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 7c90bac3de21..4acf5612487c 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev,
return ret;
}
- irq_to_desc(pdata->virq_sgi);
irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
/* Setup function for the CPU hot-plug cases */
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call
2024-05-28 12:02 [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call Arnd Bergmann
@ 2024-05-29 18:22 ` Tanmay Shah
2024-05-30 22:17 ` Tanmay Shah
1 sibling, 0 replies; 3+ messages in thread
From: Tanmay Shah @ 2024-05-29 18:22 UTC (permalink / raw)
To: Arnd Bergmann, Jassi Brar, Michal Simek, Saeed Nowshadi
Cc: Arnd Bergmann, Ben Levinsky, Gustavo A. R. Silva, Rob Herring,
Uwe Kleine-König, linux-kernel, linux-arm-kernel
Hello Arnd,
Thanks for your patch.
I am okay to remove it. I will test this and provide TB.
Thanks,
Tanmay
On 5/28/24 7:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> irq_to_desc() is not exported to loadable modules, so this driver now
> fails to link in some configurations:
>
> ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined!
>
> I can't see a purpose for this call, since the return value is unused
> and probably left over from some code refactoring.
>
> Address the link failure by just removing the line.
>
> Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 7c90bac3de21..4acf5612487c 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev,
> return ret;
> }
>
> - irq_to_desc(pdata->virq_sgi);
> irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
>
> /* Setup function for the CPU hot-plug cases */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call
2024-05-28 12:02 [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call Arnd Bergmann
2024-05-29 18:22 ` Tanmay Shah
@ 2024-05-30 22:17 ` Tanmay Shah
1 sibling, 0 replies; 3+ messages in thread
From: Tanmay Shah @ 2024-05-30 22:17 UTC (permalink / raw)
To: Arnd Bergmann, Jassi Brar, Michal Simek, Saeed Nowshadi
Cc: Arnd Bergmann, Ben Levinsky, Gustavo A. R. Silva, Rob Herring,
Uwe Kleine-König, linux-kernel, linux-arm-kernel
Tested-by: Tanmay Shah <tanmay.shah@amd.com>
On 5/28/24 7:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> irq_to_desc() is not exported to loadable modules, so this driver now
> fails to link in some configurations:
>
> ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined!
>
> I can't see a purpose for this call, since the return value is unused
> and probably left over from some code refactoring.
>
> Address the link failure by just removing the line.
>
> Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 7c90bac3de21..4acf5612487c 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev,
> return ret;
> }
>
> - irq_to_desc(pdata->virq_sgi);
> irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
>
> /* Setup function for the CPU hot-plug cases */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-30 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 12:02 [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call Arnd Bergmann
2024-05-29 18:22 ` Tanmay Shah
2024-05-30 22:17 ` Tanmay Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).