From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB28BC27C43 for ; Wed, 29 May 2024 14:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hc3i67KLN6/YkijmEZ6fbMARsHAWRQqsJKA+owtIXTw=; b=zElMkzzYjo+zC4 SqoeNQNHGotcYk1QLaJ8fPtoWd2T27usUHKKG9vpBsVVkGAmdVon26Cq5oWw99U44D3dEUNIjWldt F1z8VvvNQ4WlBdFPFWOPe2kUgSs7+ChOAvvbAJ1N+zYOKeSue902pPnGNQPNNZ2vayyYpmHc3t74y m2e7hvKQw2kfMUWP81XKIzdhq4Oco6TX7tb4d0x9wiFOK1qzI2UxFPqIdTeFQP6fGDCUXpnwHr4jn rO+vKIXSJZJDd8QBT0DGuFD5elMdU8txEsTN1njER8aHcJG4loRqLSCCTANChXhagcMG9igtuZqxM 11nC2NiYvfmJNh9yP48Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCK0n-00000004PKp-33aR; Wed, 29 May 2024 14:10:41 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCK0j-00000004PHQ-3kWQ for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 14:10:39 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a63036f2daaso265571466b.1 for ; Wed, 29 May 2024 07:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716991835; x=1717596635; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=seHfK1T0CIDoh74FZ9rFB1MYhs/7Ky7lSWNsiaH4Ato=; b=RYZLtJ3KqClEcZSjxdkCeality+XVALmDLCO1FiOVFSmNR6allpyBShU+rg6RPltXf JowHi8i/1T4I6lnvK4EopGxnNGtqj7hRatVOJPR5QopSNCtQKb95TtYo6+npu7y+rzne o0LMbINNHns1beXr9cebqophcicBsLm5sNW94IT0VSO4+AX2gTSLX/T7XjkouLdzQmTL lA2CCqXDOa2EnKm5oQPpmwIW9La9rhBeJq5Ll+SLi9G67BZ0ZkmZVTcuUk2xonv8VILs 1tsKdAeDGahniDaJ79LgtezY8JGvnnUZEt/7dDbUn31T/OpJN2J4/aIbDfE1tDBDb0W4 h10A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716991835; x=1717596635; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=seHfK1T0CIDoh74FZ9rFB1MYhs/7Ky7lSWNsiaH4Ato=; b=BS2Z1RmESVJuswh9qLufLcQ9zWx3N7pPhuFzUm6KeqZuIS+IiZjnFS8xmHjtY0q17p upt6LhH6hH7HcAqf76XHtwxQhS7e0BD77KZHE4iOxWA0JRuqp4MiU8ngldM3wq8HwzsA b94c+HQCqhu9/AOFmRe86yMZhNm2WzrlRkLVk4ljpDTKVfQRnNvws4O7Lv3dS/arKtsD QubH8HP2HpZ8JpwwbldkKw1m/0OTC96YK4moh8i9lE3wy8AM8yAWVO7eqHsKrLObMD3r Hc93W6uvGJRVT+sxzJsc04qF5PLCsYXaAEXsCThxZdeItyRAo11sY3WHQ4P64hUS6IK3 jkMg== X-Forwarded-Encrypted: i=1; AJvYcCVoF4/VmIuuIov3Y+647/byvbgcqB3yvbK8zNdr8WeztBt3vn0Zn/778JK8V+Q+rCku8Hdkzcb6vBGQn8/0KVbX5s7OZD9SQWFCzMh90pZBvpQn2E4= X-Gm-Message-State: AOJu0YwzvboT2lXALqKZCpQSCghPdeH+dG6em3hjbFENq5ZTXUhwJfzB 22t/AjotR3Mfa8Y3KNiGiWfjYCQ84zfvwVXHdzV5wo9E7+xDGYEv X-Google-Smtp-Source: AGHT+IER8t7cuMdH3WgXBrJavuAe0qg/yrQsSI5WtFPMXA+CURNazRJm23qelZOFl3U7mrYlhQ6UcQ== X-Received: by 2002:a17:907:6d22:b0:a62:9699:5125 with SMTP id a640c23a62f3a-a6296995222mr1042831266b.14.1716991834383; Wed, 29 May 2024 07:10:34 -0700 (PDT) Received: from localhost (host-95-246-50-43.retail.telecomitalia.it. [95.246.50.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6357bf05f6sm130830066b.206.2024.05.29.07.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 07:10:34 -0700 (PDT) From: Matteo Martelli To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Marcus Cooper , =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Cc: Matteo Martelli , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 0/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode Date: Wed, 29 May 2024 16:00:14 +0200 Message-ID: <20240529140658.180966-2-matteomartelli3@gmail.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_071037_969440_18022442 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I found an issue on the sunxi i2s controller driver while doing some tests with a Pine64 A64 host board and an external codec (ES8311). The A64 i2s controller is compatible with the sun8i-h3-i2s driver. The LRCLK was being inverted when the bus was operated in i2s mode: normally should be left channel on low LRCLK and right channel on high LRCLK, but it was the opposite instead. I noticed this issue due to the playback being addressed on the wrong codec channel, then confirmed by analyzing the clock signal with a logic analyzer. Note that this fix applies for all the i2s controllers compatible with sun8i-h3-i2s and sun50i-h6-i2s, but I could test it only for the A64. The issue had likely been introduced in commit dd657eae8164 ("ASoC: sun4i-i2s: Fix the LRCK polarity") due to a misinterpreted bit in the H3 or H6 User Manual. I suppose that the i2s mode had not been tested at that time. Can this be confirmed? Otherwise there is something else going on and this patch should not be applied as is. Matteo Martelli (1): ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode sound/soc/sunxi/sun4i-i2s.c | 143 ++++++++++++++++++------------------ 1 file changed, 73 insertions(+), 70 deletions(-) base-commit: 47d09270d7776e46858a161f94b735640b2fb056 -- 2.45.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel