From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B06DCC25B75 for ; Wed, 29 May 2024 18:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xI5sbwfx6dqyfeLaeSg3UvJxpxTwTdIJ6E5wC9Fo+Gk=; b=KYNOsSWDw6fTmM Trecb6b9Njq0+5ZfSDkkoELqwMOqDbeisl3YHVzI7sUk3/SCUtjp0UlTOGlJw9b0vDaN1WB2eJ1Bn sUci7mNwNfFm8GNiNQNdNmauykMPrGgm54TVzolk4bQHGQQoTkxYzJ4IAzVXXT7ek7igS88qZ4QT1 qxI32TwHFg/5fB/eQnO80sAZHdDT1usY/P3pP/vPuoyjfKACMRheaHphNE2rBLThdlGRxeTAZNIi6 Kc8wbWOiCVByGewjJa6l0EPGiM6snu4PRKO4HEM4KKdX1z02ITE1sIpwNu8xB1YIYwnmdEHlJX9g9 o9ZM4IB8+yWgWlq6V3+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCNpT-00000005B9P-2vGm; Wed, 29 May 2024 18:15:15 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCNpQ-00000005B8Q-2Bbf for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 18:15:13 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 708722D54; Wed, 29 May 2024 20:15:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717006505; bh=KW3tC/eVtpr9y5DkPXDrxg4ZHjgcWjKUM64ZfGeQpfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kHJYfeqTYzNlDS4lqw8IrnvK5zom2gF+2APMIdZex6RLSS1T5vgrgPQk+qoaK4L7f X1esPk77ZvdfewZOI3gQJycIbBOw0CwLmAl3jQBau37hNLTd/SDoaO6R2GWfgPOYcI T4MZ/fkw995nlYLU46Fme8OMZ/w3cp0dBG054+Jw= Date: Wed, 29 May 2024 21:14:56 +0300 From: Laurent Pinchart To: Daniel Scally Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com, sakari.ailus@iki.fi Subject: Re: [PATCH v5 01/16] media: uapi: Add MEDIA_BUS_FMT_RGB202020_1X60 format code Message-ID: <20240529181456.GA10586@pendragon.ideasonboard.com> References: <20240529152858.183799-1-dan.scally@ideasonboard.com> <20240529152858.183799-2-dan.scally@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240529152858.183799-2-dan.scally@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_111512_761085_F0288AB4 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, Thank you for the patch. On Wed, May 29, 2024 at 04:28:43PM +0100, Daniel Scally wrote: > The Mali-C55 ISP by ARM requires 20-bits per colour channel input on > the bus. Add a new media bus format code to represent it. > > Acked-by: Nayden Kanchev > Co-developed-by: Jacopo Mondi > Signed-off-by: Jacopo Mondi > Signed-off-by: Daniel Scally > --- > Changes in v5: > > - none > > Changes in v4: > > - None > > Changes in v3: > > - None > > Changes in v2: > > - none > .../media/v4l/subdev-formats.rst | 168 ++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 3 +- > 2 files changed, 170 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index d2a6cd2e1eb2..8d164a9a9e15 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -2224,6 +2224,174 @@ The following table list existing packed 48bit wide RGB formats. > > \endgroup > > +The following table list existing packed 60bit wide RGB formats. > + > +.. tabularcolumns:: |p{4.0cm}|p{0.7cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}| Maybe one day we should try to make those tables more compact. > + > +.. _v4l2-mbus-pixelcode-rgb-60: > + > +.. raw:: latex > + > + \begingroup > + \tiny > + \setlength{\tabcolsep}{2pt} > + > +.. flat-table:: 60bit RGB formats > + :header-rows: 3 > + :stub-columns: 0 > + :widths: 36 7 3 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 > + > + * - Identifier > + - Code > + - > + - :cspan:`31` Data organization > + * - > + - > + - Bit > + - > + - > + - > + - > + - 59 > + - 58 > + - 57 > + - 56 > + - 55 > + - 54 > + - 53 > + - 52 > + - 51 > + - 50 > + - 49 > + - 48 > + - 47 > + - 46 > + - 45 > + - 44 > + - 43 > + - 42 > + - 41 > + - 40 > + - 39 > + - 38 > + - 37 > + - 36 > + - 35 > + - 34 > + - 33 > + - 32 > + * - > + - > + - > + - 31 > + - 30 > + - 29 > + - 28 > + - 27 > + - 26 > + - 25 > + - 24 > + - 23 > + - 22 > + - 21 > + - 20 > + - 19 > + - 18 > + - 17 > + - 16 > + - 15 > + - 14 > + - 13 > + - 12 > + - 11 > + - 10 > + - 9 > + - 8 > + - 7 > + - 6 > + - 5 > + - 4 > + - 3 > + - 2 > + - 1 > + - 0 > + * .. _MEDIA-BUS-FMT-RGB202020-1X60: > + > + - MEDIA_BUS_FMT_RGB202020_1X60 > + - 0x1026 > + - > + - > + - > + - > + - > + - r\ :sub:`19` > + - r\ :sub:`18` > + - r\ :sub:`17` > + - r\ :sub:`16` > + - r\ :sub:`15` > + - r\ :sub:`14` > + - r\ :sub:`13` > + - r\ :sub:`12` > + - r\ :sub:`11` > + - r\ :sub:`10` > + - r\ :sub:`8` I was thinking that reviews of this kind of patches were tedious and not very useful, and then I found this mistake :-D With that fixed, Reviewed-by: Laurent Pinchart > + - r\ :sub:`8` > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - g\ :sub:`19` > + - g\ :sub:`18` > + - g\ :sub:`17` > + - g\ :sub:`16` > + - g\ :sub:`15` > + - g\ :sub:`14` > + - g\ :sub:`13` > + - g\ :sub:`12` > + * - > + - > + - > + - g\ :sub:`11` > + - g\ :sub:`10` > + - g\ :sub:`9` > + - g\ :sub:`8` > + - g\ :sub:`7` > + - g\ :sub:`6` > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - b\ :sub:`19` > + - b\ :sub:`18` > + - b\ :sub:`17` > + - b\ :sub:`16` > + - b\ :sub:`15` > + - b\ :sub:`14` > + - b\ :sub:`13` > + - b\ :sub:`12` > + - b\ :sub:`11` > + - b\ :sub:`10` > + - b\ :sub:`9` > + - b\ :sub:`8` > + - b\ :sub:`7` > + - b\ :sub:`6` > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + > +.. raw:: latex > + > + \endgroup > + > On LVDS buses, usually each sample is transferred serialized in seven > time slots per pixel clock, on three (18-bit) or four (24-bit) > differential data pairs at the same time. The remaining bits are used > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index d4c1d991014b..49be328d9a3b 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,7 +34,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x1026 */ > +/* RGB - next is 0x1027 */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -72,6 +72,7 @@ > #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO 0x1021 > #define MEDIA_BUS_FMT_RGB121212_1X36 0x1019 > #define MEDIA_BUS_FMT_RGB161616_1X48 0x101a > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026 > > /* YUV (including grey) - next is 0x202f */ > #define MEDIA_BUS_FMT_Y8_1X8 0x2001 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel