From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4549EC25B75 for ; Wed, 29 May 2024 18:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DngFMbWnRDJijP3qqxD3bK9kdRp4LIL/+brrx7RSLQE=; b=SDdBK+fc68jt5J 1aDDQjeY/QPirOteYDsA2xSoq4XGXjG2csHPRzMlYgDZP/Awyx7+oSm9zh3E7op7KmYwi69KHrtg4 OLWRjLoqWiA3ZXVoZWIUmNLYW1aw8s9RQkUEXZRiOxy4mGh4DuNGaGwRx3RtvX6AjgHmTwhGFounm kzTftVj8QuhYTnnfhbYLk+e9nD13tEDHFaHayuz0Q4eiN8IeHthedkauJjOKAMTWbmrUKrUBHhMX7 muWUBwWoS1xw8pTHxO1jXC2gZdJXqfPjkVv/GRaPvv5WYanTIk1/vQqV3TOAsRbcNM1DWyslqGUIe qYxNX040mnp32qYrwdLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCNvq-00000005C4l-0cqL; Wed, 29 May 2024 18:21:50 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCNvj-00000005C3g-24vb for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 18:21:49 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C736B53; Wed, 29 May 2024 20:21:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717006898; bh=QMahEnMhWL3YVKxXbMHSVPHRv23PvSsjHi04UEr3N3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SmM9nKaqtBKGFdSBtphh1uUNF2oJ4FKeZTSS5ZJ+IlHZYvI0pXhMhQvFBcWsKp+F2 sBu7V24BXkHNjjtn6ASOIFieonMLZYUW3pPBaC4s9oFEVxI1zL7fAcN7xzbMYfg1t5 /6DvBtAiC9m3BRHP+PmcmpiNRX15E++iVlcrpkAQ= Date: Wed, 29 May 2024 21:21:30 +0300 From: Laurent Pinchart To: Daniel Scally Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com, sakari.ailus@iki.fi Subject: Re: [PATCH v5 04/16] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240529182130.GD10586@pendragon.ideasonboard.com> References: <20240529152858.183799-1-dan.scally@ideasonboard.com> <20240529152858.183799-5-dan.scally@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240529152858.183799-5-dan.scally@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_112146_580662_909D1CBF X-CRM114-Status: GOOD ( 20.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, Thank you for the patch. On Wed, May 29, 2024 at 04:28:46PM +0100, Daniel Scally wrote: > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > > Reviewed-by: Krzysztof Kozlowski > Acked-by: Nayden Kanchev > Co-developed-by: Jacopo Mondi > Signed-off-by: Jacopo Mondi > Signed-off-by: Daniel Scally Reviewed-by: Laurent Pinchart > --- > Changes in v5: > > - None > > Changes in v4: > > - Switched to port instead of ports > > Changes in v3: > > - Dropped the video clock as suggested by Laurent. I didn't retain it > for the purposes of the refcount since this driver will call .s_stream() > for the sensor driver which will refcount the clock anyway. > - Clarified that the port is a parallel input port rather (Sakari) > > Changes in v2: > > - Added clocks information > - Fixed the warnings raised by Rob > > .../bindings/media/arm,mali-c55.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > new file mode 100644 > index 000000000000..9cc2481f2da3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARM Mali-C55 Image Signal Processor > + > +maintainers: > + - Daniel Scally > + - Jacopo Mondi > + > +properties: > + compatible: > + const: arm,mali-c55 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ISP AXI clock > + - description: ISP AHB-lite clock > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input parallel video bus > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/properties/endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + mali_c55: isp@400000 { > + compatible = "arm,mali-c55"; > + reg = <0x400000 0x200000>; > + clocks = <&clk 0>, <&clk 1>; > + clock-names = "aclk", "hclk"; > + interrupts = <0>; > + > + port { > + isp_in: endpoint { > + remote-endpoint = <&csi2_rx_out>; > + }; > + }; > + }; > +... -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel