From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1803FC25B74 for ; Thu, 30 May 2024 07:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oe9585HIkK4ie/lxRNje2rowIoHJsBZv9jt6rzDslRM=; b=M82/YlMgjPLjmC NoSgYtcJx/HeUH0OK32OF5q5rrqlGUM1PQ14dxmBOcnEmanSaUiX9gHLBT8JXbpIMjs2EelsUekjH 1ht2jQki0b1EYSuXBgh9sJPxzq4MXm8q1NA8GWop3/s2mno914rNGpD4JDCEmxvGqqhMW/++Uj+4V Z9oiCkvZ/BBQPkAF2zMOUEXLa/a33cXo5KmL00aDSHqAP3qa2vWZs0IPJ0PXgMXJVmzrk6IxG8cZo 1312adoip8SoOXvlTAIdqlb9VCsfZdfSnDsGC6BA7FSXArfe2EsHuCuqunLylt+gqDx/n2msGbflz gxhFXY3kD9Ltp3dTGVHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCaOV-00000006XBS-25zR; Thu, 30 May 2024 07:40:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCaOS-00000006XAl-3Ycp for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 07:40:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 938DF60686; Thu, 30 May 2024 07:40:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFAFFC2BBFC; Thu, 30 May 2024 07:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717054809; bh=wNN960FphnubiQ9QbNQbnvG3rJVXxUI69WDQ4o/6EvY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ayoqaR3eB0FFbwcg8JkZVAtblT/BzCHcQScR/gPHUtH/y7vPIJKjPvU/+X9iEVzaN oJwFP4vJaOuoRF4EPFu34dPav4543Rz0lNbrOAR9Vt7LIYA73if6sk1jCkaeOB0700 H5wFz1FRmjTqxJoE28bumw2DwcLFeIZxEtoovx/U= Date: Thu, 30 May 2024 09:40:13 +0200 From: Greg Kroah-Hartman To: Jiri Slaby , Nathan Chancellor Cc: Kees Cook , "Gustavo A. R. Silva" , Bill Wendling , Justin Stitt , linux-serial@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] tty: mxser: Remove __counted_by from mxser_board.ports[] Message-ID: <2024053008-sadly-skydiver-92be@gregkh> References: <20240529-drop-counted-by-ports-mxser-board-v1-1-0ab217f4da6d@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_004013_033533_335568CA X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 30, 2024 at 08:22:03AM +0200, Jiri Slaby wrote: > > This will be an error in a future compiler version [-Werror,-Wbounds-safety-counted-by-elt-type-unknown-size] > > 291 | struct mxser_port ports[] __counted_by(nports); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > 1 error generated. > > > > Remove this use of __counted_by to fix the warning/error. However, > > rather than remove it altogether, leave it commented, as it may be > > possible to support this in future compiler releases. > > This looks like a compiler bug/deficiency. I agree, why not just turn that option off in the compiler so that these "warnings" will not show up? > What does gcc say BTW? > > > Cc: stable@vger.kernel.org > > Closes: https://github.com/ClangBuiltLinux/linux/issues/2026 > > Fixes: f34907ecca71 ("mxser: Annotate struct mxser_board with __counted_by") > > I would not say "Fixes" here. It only works around a broken compiler. Agreed, don't add Fixes: for this, it's a compiler bug, not a kernel issue. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel