From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7E41C25B74 for ; Thu, 30 May 2024 16:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FHKxPUSeCw653GGdODvLLanqpGtePwMNXUxHRO9h8w8=; b=xkOSvoK4Ex+7Jh K+NAfpAfc8ASgrReRm9F3L/IFXmSJ0IRYdeqKYeEuEsnQXgyhzDgBvoWxht0EgQ0l2ruL1MsPur9+ PXiyTomjs/8OJOTgT+9SGbtn20ATE2aTCvuXrWAkn2Zdl1CpdCm4Q5N3xAi9rgNTnUuh5rvW+/Zbf 3mAY4liEsiTeb640Z+8qdrXhxEf+n6jGsecrLLXrRHDh22LU3WBuHfKqWU42sM9HS6xOC5VPo8VAn gzO729IxF6f8ZKofSxGxM9IDLBSn9brT2paGHarWyFeTJjt72c5jLLHG+Vu6kdLDirt2/vchS6jAN flHRq5OlKqECd9P1T0PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCiPI-00000007oKQ-2Xtd; Thu, 30 May 2024 16:13:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCiPF-00000007oK4-0x74 for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 16:13:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 43D8660B94; Thu, 30 May 2024 16:13:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B350C2BBFC; Thu, 30 May 2024 16:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717085612; bh=PfJbQricCfe6xXO/btTWODyoQHxmmR7NyBEvK16OrTA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WK48dhGa24x2IlutQf0BRwlTmhjcJlIUaUgtVU3SxywObeSgfOJGvUMWBMScFTAZd ISDSGqUTgClDZZTlYoGtEf/UlzzFy6UaOtFHAPMLMSt6tdRgF92PHNHBBmMFk3zdHN yxJobDk4Afff/dA5r5fsiYOhGbD/zTIms4wkhdDAotURS+wxmbKq+76k7fDHnwrRFw lSLl1g/OXNSmV36nqyWL/3hN6l9oYgI9iRMwmcIQBbiU6L8ccc7dAv3lMdsmNkcZIG CFUfsxqHZkfCtM88aDNPUJjZn/N8RZvJikGOTNXk5cIK/kzYUWyTuX/5bmFRR4OmAB Wcoq2bkwa8kmA== Date: Thu, 30 May 2024 09:13:30 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Vladimir Oltean , Xiaolei Wang , Andrew Lunn , alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net v2 PATCH] net: stmmac: Update CBS parameters when speed changes after linking up Message-ID: <20240530091330.13a20fdc@kernel.org> In-Reply-To: References: <20240530061453.561708-1-xiaolei.wang@windriver.com> <20240530132822.xv23at32wj73hzfj@skbuf> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_091333_365955_83E851E6 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 30 May 2024 14:40:30 +0100 Russell King (Oracle) wrote: > I think what you're proposing leads to the hardware being effectively > "de-programmed" for CBS while "tc qdisc show" will probably report > that CBS is active on the interface - which clearly would be absurd. FWIW the "switch-offloaded" qdiscs do support reporting that they got "de-programmed" given that more complex hierarchies can easily go out of what HW is capable of. They call the driver from the .dump callback, nominally to get stats (e.g. red_dump() -> red_dump_offload_stats()) but it also refreshes the offloaded state (see qdisc_offload_dump_helper()). For "NIC-offloaded" qdiscs (i.e. all traffic passes thru the host, rather than being forwarded) the stats callback makes less sense. But all this is to say that there _is_ precedent for clearing qdisc "offloaded" bits. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel