From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B06DC27C4F for ; Fri, 31 May 2024 20:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hw/aJnYcCuD3Uyx4qJ5byj/7tB8VIViKD5/I5gTw1ZQ=; b=bn7mxCLay6W6jK UBaXHiGWlOyTlfMJIMIJe7bHFY39DbZSrbxIAsghxbc7FGYYRXyUsIsObWD/mwlh4Xn3zRnYz//sc EGCx2Hk6Rp19SKZ2FayFVQfXIdUEY7gLm2P/rGfI7hEOjpldK5oHJWuIXxJADah+U97GXmdVmi4Pi gXRF3cLR9a5b49hdB4P0+hkOdHD6ZTonv8eKWJc6T/l5/kXb3kBSoht4tS+V7rMyKbiIYmzs2ccUq DVAXZKrhnv8Qmi+hCEpwPnhG4BGQWTKVyfRGtM62baFeDi8vK/TAljYH8AsU58dutwaP78NaqhD85 CMZBCpcKqDZeVgQfdjlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD8zH-0000000BOGx-1BSo; Fri, 31 May 2024 20:36:31 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sD8z9-0000000BODy-2yUT; Fri, 31 May 2024 20:36:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4ACBCCE0DA2; Fri, 31 May 2024 20:36:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5434C2BD10; Fri, 31 May 2024 20:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717187780; bh=WdOxa9rbUS6q9NaRbl/yb1oNoDnPk7wE0Gs06YTBa5U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BgzTgIjjAbBDZJJ7SdGkQGn03Ke7koI9sJcvxzGG85wTTVXYUoUXrCv+9F2+Fr/p0 5ann9Kudtmbhm5NuShztMv0EAjFKOaxiiV420z9fm1LqUhVPUVOjjqLne17p6ZqDO6 CcaaVgkybPhHQeBRx2sqjj+RSW+PjtVnZWl+o4Vr8Oxjr9x7Bb1Cx03QlEgURZp6EG 16FKupbqrEl+oHu3VZYCeT6Mx98i18EH8N3S3AP2mWIg+PYTuDZWK6dcQ/bk5MvmF6 fSkyQ45BE5IcQWascYcv86qbwspWcJ21Qps/yZ3OASZ6k7bTUBrGBqENi+FNwL1/53 BTJoDAANj2F2A== Date: Fri, 31 May 2024 21:36:12 +0100 From: Simon Horman To: Liju-clr Chen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Richard Cochran , Matthias Brugger , AngeloGioacchino Del Regno , Yingshiuan Pan , Ze-yu Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, David Bradil , Trilok Soni , Shawn Hsiao , PeiLun Suei , Chi-shen Yeh , Kevenny Hsieh Subject: Re: [PATCH v11 08/21] virt: geniezone: Add vcpu support Message-ID: <20240531203612.GU491852@kernel.org> References: <20240529084239.11478-1-liju-clr.chen@mediatek.com> <20240529084239.11478-9-liju-clr.chen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240529084239.11478-9-liju-clr.chen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240531_133625_133809_7DABD5BE X-CRM114-Status: GOOD ( 26.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024 at 04:42:26PM +0800, Liju-clr Chen wrote: > From: Yi-De Wu > > From: "Yingshiuan Pan" nit: I think there should be at most one From line, denoting the author of the patch. Based on the Signed-off-by lines I assume that is Yingshiuan Pan. If there are multiple authors perhaps the Co-developed-by tag should be used below. And on that note, it's not clear to me what the significance of the Signed-off-by lines, other than that of Yingshiuan Pan (presumed author) and Liju Chen (sender) are. I'd suggest deleting them unless they are accompanied by Co-developed-by tags. And, lastly, the sender's signed-off-by line should come last. See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > > VMM use this interface to create vcpu instance which is a fd, and this > fd will be for any vcpu operations, such as setting vcpu registers and > accepts the most important ioctl GZVM_VCPU_RUN which requests GenieZone > hypervisor to do context switch to execute VM's vcpu context. > > Signed-off-by: Yingshiuan Pan > Signed-off-by: Jerry Wang > Signed-off-by: kevenny hsieh > Signed-off-by: Liju Chen > Signed-off-by: Yi-De Wu ... > diff --git a/drivers/virt/geniezone/Makefile b/drivers/virt/geniezone/Makefile > index 25614ea3dea2..9cc453c0819b 100644 > --- a/drivers/virt/geniezone/Makefile > +++ b/drivers/virt/geniezone/Makefile > @@ -6,4 +6,5 @@ > > GZVM_DIR ?= ../../../drivers/virt/geniezone > > -gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o > +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ > + $(GZVM_DIR)/gzvm_vcpu.o > diff --git a/drivers/virt/geniezone/gzvm_vcpu.c b/drivers/virt/geniezone/gzvm_vcpu.c > new file mode 100644 > index 000000000000..1aca13fef422 > --- /dev/null > +++ b/drivers/virt/geniezone/gzvm_vcpu.c > @@ -0,0 +1,249 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2023 MediaTek Inc. > + */ > + > +#include nit: It's not clear to me that sysreg.h needs to be included in this file. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* maximum size needed for holding an integer */ > +#define ITOA_MAX_LEN 12 > + > +static long gzvm_vcpu_update_one_reg(struct gzvm_vcpu *vcpu, > + void __user *argp, > + bool is_write) > +{ > + struct gzvm_one_reg reg; > + void __user *reg_addr; > + u64 data = 0; > + u64 reg_size; > + long ret; > + > + if (copy_from_user(®, argp, sizeof(reg))) > + return -EFAULT; > + > + reg_addr = (void __user *)reg.addr; nit: Perhaps u64_to_user_ptr() is appropriate here. Also in gzvm_vm_ioctl_create_device() in patch 09/21. > + reg_size = (reg.id & GZVM_REG_SIZE_MASK) >> GZVM_REG_SIZE_SHIFT; > + reg_size = BIT(reg_size); > + > + if (reg_size != 1 && reg_size != 2 && reg_size != 4 && reg_size != 8) > + return -EINVAL; > + > + if (is_write) { > + /* GZ hypervisor would filter out invalid vcpu register access */ > + if (copy_from_user(&data, reg_addr, reg_size)) > + return -EFAULT; > + } else { > + return -EOPNOTSUPP; > + } > + > + ret = gzvm_arch_vcpu_update_one_reg(vcpu, reg.id, is_write, &data); > + > + if (ret) > + return ret; > + > + return 0; > +} ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel