Re: [PATCH v2 2/3] coresight: Add support to get preferred id for system trace sources

[kernel test robot <lkp@intel.com>]

Hi Mao,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on atorgue-stm32/stm32-next linus/master v6.10-rc2 next-20240603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mao-Jinlong/dt-bindings-arm-Add-trace-id-for-coresight-dummy-source/20240603-175023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240603094354.2348-3-quic_jinlmao%40quicinc.com
patch subject: [PATCH v2 2/3] coresight: Add support to get preferred id for system trace sources
config: arm64-randconfig-001-20240604 (https://download.01.org/0day-ci/archive/20240604/202406040902.AybuHOVD-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040902.AybuHOVD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406040902.AybuHOVD-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/hwtracing/coresight/coresight-tpda.c:6:
   In file included from include/linux/amba/bus.h:19:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2253:
   include/linux/vmstat.h:500:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     500 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     501 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:507:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     507 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     508 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     514 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:519:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     519 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     520 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:528:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     528 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     529 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/hwtracing/coresight/coresight-tpda.c:254:42: error: too few arguments to function call, single argument 'id' was not specified
     254 |         atid = coresight_trace_id_get_system_id();
         |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
   drivers/hwtracing/coresight/coresight-trace-id.h:126:5: note: 'coresight_trace_id_get_system_id' declared here
     126 | int coresight_trace_id_get_system_id(int id);
         |     ^                                ~~~~~~
   5 warnings and 1 error generated.


vim +/id +254 drivers/hwtracing/coresight/coresight-tpda.c

5b7916625c017e Mao Jinlong 2023-01-17  243  
5b7916625c017e Mao Jinlong 2023-01-17  244  static int tpda_init_default_data(struct tpda_drvdata *drvdata)
5b7916625c017e Mao Jinlong 2023-01-17  245  {
5b7916625c017e Mao Jinlong 2023-01-17  246  	int atid;
5b7916625c017e Mao Jinlong 2023-01-17  247  	/*
5b7916625c017e Mao Jinlong 2023-01-17  248  	 * TPDA must has a unique atid. This atid can uniquely
5b7916625c017e Mao Jinlong 2023-01-17  249  	 * identify the TPDM trace source connected to the TPDA.
5b7916625c017e Mao Jinlong 2023-01-17  250  	 * The TPDMs which are connected to same TPDA share the
5b7916625c017e Mao Jinlong 2023-01-17  251  	 * same trace-id. When TPDA does packetization, different
5b7916625c017e Mao Jinlong 2023-01-17  252  	 * port will have unique channel number for decoding.
5b7916625c017e Mao Jinlong 2023-01-17  253  	 */
5b7916625c017e Mao Jinlong 2023-01-17 @254  	atid = coresight_trace_id_get_system_id();
5b7916625c017e Mao Jinlong 2023-01-17  255  	if (atid < 0)
5b7916625c017e Mao Jinlong 2023-01-17  256  		return atid;
5b7916625c017e Mao Jinlong 2023-01-17  257  
5b7916625c017e Mao Jinlong 2023-01-17  258  	drvdata->atid = atid;
5b7916625c017e Mao Jinlong 2023-01-17  259  	return 0;
5b7916625c017e Mao Jinlong 2023-01-17  260  }
5b7916625c017e Mao Jinlong 2023-01-17  261  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel