[PATCH 0/7] arm64: dts: ti: McASP fixes

[PATCH 0/7] arm64: dts: ti: McASP fixes

[Jai Luthra]

Drop McASP AFIFOs for all AM62 based platforms, as the extra buffering
is not needed with BCDMA already having internal buffering.

Also fix the pinmux for McASP1 on AM62P.

Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
Jai Luthra (7):
      arm64: dts: ti: k3-am62x: Drop McASP AFIFOs
      arm64: dts: ti: k3-am62a7: Drop McASP AFIFOs
      arm64: dts: ti: k3-am62p5: Drop McASP AFIFOs
      arm64: dts: ti: k3-am625-beagleplay: Drop McASP AFIFOs
      arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs
      arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Drop McASP AFIFOs
      arm64: dts: ti: k3-am62p5-sk: Fix pinmux for McASP1 TX

 arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi            | 8 ++++----
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts        | 4 ++--
 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 4 ++--
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts               | 4 ++--
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts               | 6 +++---
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi        | 4 ++--
 6 files changed, 15 insertions(+), 15 deletions(-)
---
base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
change-id: 20240604-mcasp_fifo_drop-683bc3412262

Best regards,
-- 
Jai Luthra <j-luthra@ti.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/7] arm64: dts: ti: k3-am62x: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: b94b43715e91 ("arm64: dts: ti: Enable audio on SK-AM62(-LP)")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index 3c45782ab2b7..07e739573d84 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -504,8 +504,8 @@ &mcasp1 {
 	       0 0 0 0
 	       0 0 0 0
 	>;
-	tx-num-evt = <32>;
-	rx-num-evt = <32>;
+	tx-num-evt = <0>;
+	rx-num-evt = <0>;
 };
 
 &dss {

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/7] arm64: dts: ti: k3-am62a7: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 4a2c5dddf9e9 ("arm64: dts: ti: k3-am62a7-sk: Enable audio on AM62A")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index fa43cd0b631e..b042599b529d 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -701,8 +701,8 @@ &mcasp1 {
 	       0 0 0 0
 	       0 0 0 0
 	>;
-	tx-num-evt = <32>;
-	rx-num-evt = <32>;
+	tx-num-evt = <0>;
+	rx-num-evt = <0>;
 };
 
 &dss {

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/7] arm64: dts: ti: k3-am62p5: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: c00504ea42c0 ("arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 6e7234659111..2aaf7d490c77 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -549,8 +549,8 @@ &mcasp1 {
 	       0 0 0 0
 	       0 0 0 0
 	>;
-	tx-num-evt = <32>;
-	rx-num-evt = <32>;
+	tx-num-evt = <0>;
+	rx-num-evt = <0>;
 };
 
 &fss {

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/7] arm64: dts: ti: k3-am625-beagleplay: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 1f7226a5e52c ("arm64: dts: ti: k3-am625-beagleplay: Add HDMI support")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index 18e3070a8683..c6d17332e6d5 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -924,6 +924,6 @@ &mcasp1 {
 	       0 0 0 0
 	       0 0 0 0
 	>;
-	tx-num-evt = <32>;
-	rx-num-evt = <32>;
+	tx-num-evt = <0>;
+	rx-num-evt = <0>;
 };

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
index 2038c5e04639..27e5220e1dc7 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
@@ -1364,8 +1364,8 @@ &mcasp0 {
 	       0 0 0 0
 	>;
 	tdm-slots = <2>;
-	rx-num-evt = <32>;
-	tx-num-evt = <32>;
+	rx-num-evt = <0>;
+	tx-num-evt = <0>;
 	#sound-dai-cells = <0>;
 	status = "disabled";
 };
@@ -1382,8 +1382,8 @@ &mcasp1 {
 	       0 0 0 0
 	>;
 	tdm-slots = <2>;
-	rx-num-evt = <32>;
-	tx-num-evt = <32>;
+	rx-num-evt = <0>;
+	tx-num-evt = <0>;
 	#sound-dai-cells = <0>;
 	status = "disabled";
 };

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

[Francesco Dolcini]

Hello Jai, thanks for the patch.

On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote:
> McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
> on the DMA IP. Drop these for better audio latency.
> 
> Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> index 2038c5e04639..27e5220e1dc7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> @@ -1364,8 +1364,8 @@ &mcasp0 {
>  	       0 0 0 0
>  	>;
>  	tdm-slots = <2>;
> -	rx-num-evt = <32>;
> -	tx-num-evt = <32>;
> +	rx-num-evt = <0>;
> +	tx-num-evt = <0>;

From my understanding of the dt-binding having these properties set to
<0> is equivalent to not having those properties at all.
My suggestion would be to just remove those, therefore.

With that said, in any case, whatever you do my suggested change or not,

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

[Jai Luthra]

Hi Francesco,

Thanks for the review.

On Jun 05, 2024 at 10:47:13 +0200, Francesco Dolcini wrote:
> Hello Jai, thanks for the patch.
> 
> On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote:
> > McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
> > on the DMA IP. Drop these for better audio latency.
> > 
> > Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
> > Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > index 2038c5e04639..27e5220e1dc7 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > @@ -1364,8 +1364,8 @@ &mcasp0 {
> >  	       0 0 0 0
> >  	>;
> >  	tdm-slots = <2>;
> > -	rx-num-evt = <32>;
> > -	tx-num-evt = <32>;
> > +	rx-num-evt = <0>;
> > +	tx-num-evt = <0>;
> 
> From my understanding of the dt-binding having these properties set to
> <0> is equivalent to not having those properties at all.
> My suggestion would be to just remove those, therefore.
> 

I was following the existing convention of setting it to 0 for 
disabling, as done in k3-j721e-common-proc-board.dts

IMO it is better to keep it explicit, but I don't feel strongly against 
dropping it either (as long as we do the same for j721e). Will defer the 
decision to the tree maintainers.

> With that said, in any case, whatever you do my suggested change or 
> not,
> 
> Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Francesco
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

[Nishanth Menon]

On 14:28-20240605, Jai Luthra wrote:
> Hi Francesco,
> 
> Thanks for the review.
> 
> On Jun 05, 2024 at 10:47:13 +0200, Francesco Dolcini wrote:
> > Hello Jai, thanks for the patch.
> > 
> > On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote:
> > > McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
> > > on the DMA IP. Drop these for better audio latency.
> > > 
> > > Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
> > > Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > > ---
> > >  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > > index 2038c5e04639..27e5220e1dc7 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > > @@ -1364,8 +1364,8 @@ &mcasp0 {
> > >  	       0 0 0 0
> > >  	>;
> > >  	tdm-slots = <2>;
> > > -	rx-num-evt = <32>;
> > > -	tx-num-evt = <32>;
> > > +	rx-num-evt = <0>;
> > > +	tx-num-evt = <0>;
> > 
> > From my understanding of the dt-binding having these properties set to
> > <0> is equivalent to not having those properties at all.
> > My suggestion would be to just remove those, therefore.
> > 
> 
> I was following the existing convention of setting it to 0 for 
> disabling, as done in k3-j721e-common-proc-board.dts
> 
> IMO it is better to keep it explicit, but I don't feel strongly against 
> dropping it either (as long as we do the same for j721e). Will defer the 
> decision to the tree maintainers.
> 

If they are equivalent, then just drop them.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 6/7] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Drop McASP AFIFOs

[Jai Luthra]

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
index 50d2573c840e..77c86ba3849f 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
@@ -441,8 +441,8 @@ &mcasp2 {
 			0 0 0 0
 			0 0 0 0
 	>;
-	tx-num-evt = <32>;
-	rx-num-evt = <32>;
+	tx-num-evt = <0>;
+	rx-num-evt = <0>;
 	status = "okay";
 };
 

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 7/7] arm64: dts: ti: k3-am62p5-sk: Fix pinmux for McASP1 TX

[Jai Luthra]

On SK-AM62P, McASP1 uses two pins for communicating with the codec over
I2S protocol. One of these pins (AXR0) is used for audio playback (TX)
so the direction of the pin should be OUTPUT.

Fixes: c00504ea42c0 ("arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 2aaf7d490c77..aa45a6fa6e0b 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -207,7 +207,7 @@ main_mcasp1_pins_default: main-mcasp1-default-pins {
 		pinctrl-single,pins = <
 			AM62PX_IOPAD(0x0090, PIN_INPUT, 2) /* (U24) GPMC0_BE0n_CLE.MCASP1_ACLKX */
 			AM62PX_IOPAD(0x0098, PIN_INPUT, 2) /* (AA24) GPMC0_WAIT0.MCASP1_AFSX */
-			AM62PX_IOPAD(0x008c, PIN_INPUT, 2) /* (T25) GPMC0_WEn.MCASP1_AXR0 */
+			AM62PX_IOPAD(0x008c, PIN_OUTPUT, 2) /* (T25) GPMC0_WEn.MCASP1_AXR0 */
 			AM62PX_IOPAD(0x0084, PIN_INPUT, 2) /* (R25) GPMC0_ADVn_ALE.MCASP1_AXR2 */
 		>;
 	};

-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/7] arm64: dts: ti: McASP fixes

[Francesco Dolcini]

Hello Jai,

On Tue, Jun 04, 2024 at 03:11:01PM +0530, Jai Luthra wrote:
> Drop McASP AFIFOs for all AM62 based platforms, as the extra buffering
> is not needed with BCDMA already having internal buffering.

Is this related with the issue in which after play/record or use the
McASP interface the system crashes or behaves in unexpected ways or this
is something else?

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Re: [PATCH 0/7] arm64: dts: ti: McASP fixes

[Jai Luthra]

Hi Francesco,

On Jun 04, 2024 at 15:33:52 +0200, Francesco Dolcini wrote:
> Hello Jai,
> 
> On Tue, Jun 04, 2024 at 03:11:01PM +0530, Jai Luthra wrote:
> > Drop McASP AFIFOs for all AM62 based platforms, as the extra buffering
> > is not needed with BCDMA already having internal buffering.
> 
> Is this related with the issue in which after play/record or use the
> McASP interface the system crashes or behaves in unexpected ways or this
> is something else?
> 

This series does not address that issue. This is for general latency 
improvements.

The fix for that is in the DMA driver. We have something working and 
well tested now in the evil vendor tree, will be posting that to 
dmaengine@ in a few days.

> Francesco
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel