From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E0DFC25B78 for ; Tue, 4 Jun 2024 14:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xL12d9vJ7xRJukeKD7ifp6LoZNyeDWjUATgjRvDL/E8=; b=iYKGm9b3jtpowL iE05+bQ228LLdGWTA2iX1TiSdTk0CiDvNHEEanFt8MvxuPAxxluGX+/IU12uXe/dTVk/AelSdybuV v1iZU1RznlAJ/tU583X6v1XYeZvPBop5VYN/XUHSgJkpB8QqsLvr9KvjRD+n4sp3rLZ3esZvi7ysl TKXH8zFCI8cKa1D1sPwuq44NDT07/rTgogjxv5UBX0BlsWa5uYQJXJB80/9EMok4hhfLNIkNmovBo 46W65krC7s+I9MopZUloTKLu7Xeu8DrP0QJWOYqv8nCnE3lFSWjwwI2vlIrwUtj+LZYDwH7tXr9vQ rla7IFWutMpdvMncO3hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEVAg-00000002hBD-3UcJ; Tue, 04 Jun 2024 14:29:54 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEVAe-00000002hAn-0B7f for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 14:29:53 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DBF6561255; Tue, 4 Jun 2024 14:29:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E945BC32786; Tue, 4 Jun 2024 14:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717511389; bh=RYVqR2gATEQ+i8NFnZGN6b5inLIzZ2bALRV5omE/pto=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LMQxkxwItHEyc0tuHD46Cq6ZIFnI2PqRgcPo/rHiZxmQYoXWcW+z8Me6WqY4UTpfD p5xGiufhACSdpulwIDjc0ROPASwruHfmhvDGJrlbuQ5SU9meMtvwCAl8OarGE6bd2+ gfxwVfJUUAu3EUroDavLsd7BdRTR054oPF8jtuyDlOw62e8zeX2Bgahp+BimJ5102H lOcSUeEF88Y0hF+lR1V4e+KgswypSX6qb6On8mHFA4JOrX2mej4kbhWlLfQn1HcG/d 5IwUiGDgxSpr/+hxtVtgubCv1WC1s6TgLE4dthl42VVGbfAw3hKjoekzIXTrM1q8Ht QxMsW4NONw73w== Date: Tue, 4 Jun 2024 15:29:41 +0100 From: Will Deacon To: Alice Ryhl Cc: Jamie.Cunliffe@arm.com, a.hindborg@samsung.com, alex.gaynor@gmail.com, ardb@kernel.org, benno.lossin@proton.me, bjorn3_gh@protonmail.com, boqun.feng@gmail.com, broonie@kernel.org, catalin.marinas@arm.com, gary@garyguo.net, keescook@chromium.org, kernel@valentinobst.de, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, masahiroy@kernel.org, maz@kernel.org, miguel.ojeda.sandonis@gmail.com, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, ojeda@kernel.org, rust-for-linux@vger.kernel.org, samitolvanen@google.com, wedsonaf@gmail.com Subject: Re: [PATCH v2] rust: add flags for shadow call stack sanitizer Message-ID: <20240604142941.GD20384@willie-the-truck> References: <20240409103120.GA22557@willie-the-truck> <20240430110925.1064685-1-aliceryhl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430110925.1064685-1-aliceryhl@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_072952_205966_2DE172EA X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 11:09:25AM +0000, Alice Ryhl wrote: > Will Deacon wrote: > > On Tue, Mar 05, 2024 at 01:14:19PM +0100, Miguel Ojeda wrote: > >> Otherwise partially reverting to the `target.json` approach sounds good too. > >> > >> I added the `-Zuse-sync-unwind=n` to the list at > >> https://github.com/Rust-for-Linux/linux/issues/2. Given the default is > >> what we want, I have put it in the "Good to have" section. > > > > I think we have time to do this properly, like we did for the clang > > enablement a few years ago. In hindsight, avoiding hacks for the early > > toolchains back then was a really good idea because it meant we could > > rely on a solid baseline set of compiler features from the start. > > > > So, please can we fix this in rustc and just have SCS dependent on that? > > Just to keep you in the loop, I've posted a PR to make rustc recognize > the reserve-x18 target feature, so that the -Ctarget-feature=+reserve-x18 > flag stops emitting a warning. > > This should be sufficient for adding support for CONFIG_DYNAMIC_SCS. > > You can find it here: > https://github.com/rust-lang/rust/pull/124323 > > As for non-dynamic SCS, I plan to tackle that after the PR is merged. > See the "Future possibilities" section in the linked PR for more info on > that. Thanks for persevering with this, Alice. I read the pull request above, but it looks like you went with: https://github.com/rust-lang/rust/pull/124655 instead, which was merged (hurrah!). Do we need anything else? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel