linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: Enable TI LP873X PMIC
@ 2024-06-04 23:38 Nathan Morrisson
  2024-06-05  7:15 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Nathan Morrisson @ 2024-06-04 23:38 UTC (permalink / raw)
  To: catalin.marinas, will, quic_bjorande, krzysztof.kozlowski,
	geert+renesas, konrad.dybcio, shawnguo, neil.armstrong, arnd,
	m.szyprowski, nfraprado, u-kumar1
  Cc: linux-arm-kernel, linux-kernel, upstream, w.egorov

Enable the TI LP873X PMIC configs.

Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 57a9abe78ee4..24ea62a8fdbf 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_SL28CPLD=y
 CONFIG_RZ_MTU3=y
 CONFIG_MFD_TI_AM335X_TSCADC=m
+CONFIG_MFD_TI_LP873X=y
 CONFIG_MFD_TPS65219=y
 CONFIG_MFD_TPS6594_I2C=m
 CONFIG_MFD_ROHM_BD718XX=y
@@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_REGULATOR_HI6421V530=y
 CONFIG_REGULATOR_HI655X=y
+CONFIG_REGULATOR_LP873X=y
 CONFIG_REGULATOR_MAX77620=y
 CONFIG_REGULATOR_MAX8973=y
 CONFIG_REGULATOR_MAX20411=m
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC
  2024-06-04 23:38 [PATCH] arm64: defconfig: Enable TI LP873X PMIC Nathan Morrisson
@ 2024-06-05  7:15 ` Krzysztof Kozlowski
  2024-06-06 23:38   ` Nathan Morrisson
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05  7:15 UTC (permalink / raw)
  To: Nathan Morrisson, catalin.marinas, will, quic_bjorande,
	geert+renesas, konrad.dybcio, shawnguo, neil.armstrong, arnd,
	m.szyprowski, nfraprado, u-kumar1
  Cc: linux-arm-kernel, linux-kernel, upstream, w.egorov

On 05/06/2024 01:38, Nathan Morrisson wrote:
> Enable the TI LP873X PMIC configs.

Why? No user of this, sorry. Please explain in commit msg why this
should be done, e.g. which upstream user needs it.

> 
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 57a9abe78ee4..24ea62a8fdbf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
>  CONFIG_MFD_SL28CPLD=y
>  CONFIG_RZ_MTU3=y
>  CONFIG_MFD_TI_AM335X_TSCADC=m
> +CONFIG_MFD_TI_LP873X=y

Why this cannot be m?

>  CONFIG_MFD_TPS65219=y
>  CONFIG_MFD_TPS6594_I2C=m
>  CONFIG_MFD_ROHM_BD718XX=y
> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
>  CONFIG_REGULATOR_GPIO=y
>  CONFIG_REGULATOR_HI6421V530=y
>  CONFIG_REGULATOR_HI655X=y
> +CONFIG_REGULATOR_LP873X=y

Why this cannot be m?

>  CONFIG_REGULATOR_MAX77620=y
>  CONFIG_REGULATOR_MAX8973=y
>  CONFIG_REGULATOR_MAX20411=m

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC
  2024-06-05  7:15 ` Krzysztof Kozlowski
@ 2024-06-06 23:38   ` Nathan Morrisson
  0 siblings, 0 replies; 3+ messages in thread
From: Nathan Morrisson @ 2024-06-06 23:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski, catalin.marinas, will, quic_bjorande,
	geert+renesas, konrad.dybcio, shawnguo, neil.armstrong, arnd,
	m.szyprowski, nfraprado, u-kumar1
  Cc: linux-arm-kernel, linux-kernel, upstream, w.egorov


On 6/5/24 12:15 AM, Krzysztof Kozlowski wrote:
> On 05/06/2024 01:38, Nathan Morrisson wrote:
>> Enable the TI LP873X PMIC configs.
> Why? No user of this, sorry. Please explain in commit msg why this
> should be done, e.g. which upstream user needs it.

This will be used by the phytec am642-phyboard-electra, but the patch 
[1] has not been accepted yet. I will fix the other issues in a v2 as well.


[1] 
https://lore.kernel.org/lkml/aac6a41f-a384-43c5-8eb0-722cda74b4ea@phytec.de/


Regards,

Nathan

>
>> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
>> ---
>>   arch/arm64/configs/defconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 57a9abe78ee4..24ea62a8fdbf 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
>>   CONFIG_MFD_SL28CPLD=y
>>   CONFIG_RZ_MTU3=y
>>   CONFIG_MFD_TI_AM335X_TSCADC=m
>> +CONFIG_MFD_TI_LP873X=y
> Why this cannot be m?
>
>>   CONFIG_MFD_TPS65219=y
>>   CONFIG_MFD_TPS6594_I2C=m
>>   CONFIG_MFD_ROHM_BD718XX=y
>> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
>>   CONFIG_REGULATOR_GPIO=y
>>   CONFIG_REGULATOR_HI6421V530=y
>>   CONFIG_REGULATOR_HI655X=y
>> +CONFIG_REGULATOR_LP873X=y
> Why this cannot be m?
>
>>   CONFIG_REGULATOR_MAX77620=y
>>   CONFIG_REGULATOR_MAX8973=y
>>   CONFIG_REGULATOR_MAX20411=m
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-06 23:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 23:38 [PATCH] arm64: defconfig: Enable TI LP873X PMIC Nathan Morrisson
2024-06-05  7:15 ` Krzysztof Kozlowski
2024-06-06 23:38   ` Nathan Morrisson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).