Re: [PATCH 02/11] staging: vchiq_arm: Drop obsolete comment

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Umang Jain <umang.jain@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/11] staging: vchiq_arm: Drop obsolete comment
Date: Wed, 5 Jun 2024 09:52:53 +0300	[thread overview]
Message-ID: <20240605065253.GD879@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240604172904.61613-3-wahrenst@gmx.net>

Hi Stefan,

Thank you for the patch.

On Tue, Jun 04, 2024 at 07:28:55PM +0200, Stefan Wahren wrote:
> The BUG_ON has been replaced with WARN_ON. So we can drop the
> comment.

Note https://lwn.net/Articles/969923/ :-)

This being said, I think the comment can be dropped, regardless of
whether or not we drop the WARN_ON() later.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index e2f4aa00cb70..515cdcba043d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1451,7 +1451,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service)
> 
>  	write_lock_bh(&arm_state->susp_res_lock);
>  	if (!arm_state->videocore_use_count || !(*entity_uc)) {
> -		/* Don't use BUG_ON - don't allow user thread to crash kernel */
>  		WARN_ON(!arm_state->videocore_use_count);
>  		WARN_ON(!(*entity_uc));
>  		ret = -EINVAL;

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel