From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 740C5C25B76 for ; Wed, 5 Jun 2024 06:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8iVBPfj6MUcybGxvnNsIBhyMm3Hh5GhrqyOhpXXXqFQ=; b=Po3a5SxHNTRjc1 sZxuhiv2xp6CuFxHTqAihcwMCACyBErCanAJbM79FvfIwGa/gsklqQlgeoKPmq+2x1uuf+4fakafz ofxN4nm6zn284Z3Y+UT0TCYZ4dWTWRjH3DnbCZs0XLSAqaeZ10iPRx15GS74TD6Z168zXpeXwfDrB 4vmu5Fnk2kfIu6nprXIiKL/muRND7g2D2cDzusNKd+mxlISgiuQgJOuXXJWXcBq9CqJLLQTPeKUou 6F6KwwnAfQM9N1pCzg7F3tzSyo48AS4hrOU+2U9ZvdcoM25hwSxQiAbBCSBBVh/aw5HIgcjb9rKCo SpDdhUnDQK5vm7EpS+dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEkWL-00000004sP5-1gs7; Wed, 05 Jun 2024 06:53:17 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEkWG-00000004sNm-41Gn for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 06:53:15 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B978C16D4; Wed, 5 Jun 2024 08:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717570382; bh=mwryQMj9zZer12GOO+D0qdHkKPN+qd4eU1TTGFQz3d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iU7CEiOnAT9/X+Tp7rXiJ41QPVKcThle+EiJzgaT3nTjFsDhj4o1w2CBCbgK6lyHU MxdgyFbPFl1WvfJZpsCaUCrdwbAQzPbriC2dhwyh25WCVd5iaAWpUmpuS0wL7yZXBI 7EHJtPKp3YidEtH1pZZQBBXSC6LWEpF5Cr9uZK/k= Date: Wed, 5 Jun 2024 09:52:53 +0300 From: Laurent Pinchart To: Stefan Wahren Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/11] staging: vchiq_arm: Drop obsolete comment Message-ID: <20240605065253.GD879@pendragon.ideasonboard.com> References: <20240604172904.61613-1-wahrenst@gmx.net> <20240604172904.61613-3-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240604172904.61613-3-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_235313_181066_F41A39B7 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Thank you for the patch. On Tue, Jun 04, 2024 at 07:28:55PM +0200, Stefan Wahren wrote: > The BUG_ON has been replaced with WARN_ON. So we can drop the > comment. Note https://lwn.net/Articles/969923/ :-) This being said, I think the comment can be dropped, regardless of whether or not we drop the WARN_ON() later. Reviewed-by: Laurent Pinchart > Signed-off-by: Stefan Wahren > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index e2f4aa00cb70..515cdcba043d 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1451,7 +1451,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) > > write_lock_bh(&arm_state->susp_res_lock); > if (!arm_state->videocore_use_count || !(*entity_uc)) { > - /* Don't use BUG_ON - don't allow user thread to crash kernel */ > WARN_ON(!arm_state->videocore_use_count); > WARN_ON(!(*entity_uc)); > ret = -EINVAL; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel