linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Umang Jain <umang.jain@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/11] staging: vchiq_arm: Drop unnecessary declarations
Date: Wed, 5 Jun 2024 10:02:14 +0300	[thread overview]
Message-ID: <20240605070214.GF879@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240604172904.61613-5-wahrenst@gmx.net>

Hi Stefan,

Thank you for the patch.

On Tue, Jun 04, 2024 at 07:28:57PM +0200, Stefan Wahren wrote:
> These declarations are left from cleanups and not necessary
> anymore. So we can drop them.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h  | 3 ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
> index fd1b9d3555ce..b402aac333d9 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
> @@ -109,9 +109,6 @@ vchiq_release_service(struct vchiq_instance *instance, unsigned int handle);
>  extern int
>  vchiq_check_service(struct vchiq_service *service);
> 
> -extern void
> -vchiq_dump_platform_use_state(struct vchiq_state *state);
> -
>  extern void
>  vchiq_dump_service_use_state(struct vchiq_state *state);
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index be20abcfad75..3c7a6838ddba 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -539,8 +539,6 @@ int vchiq_platform_init_state(struct vchiq_state *state);
> 
>  int vchiq_check_service(struct vchiq_service *service);
> 
> -void vchiq_on_remote_use_active(struct vchiq_state *state);
> -
>  int vchiq_send_remote_use(struct vchiq_state *state);
> 
>  int vchiq_send_remote_use_active(struct vchiq_state *state);

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-06-05  7:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 17:28 [PATCH 00/11] staging: vc04_services: Random cleanups Stefan Wahren
2024-06-04 17:28 ` [PATCH 01/11] staging: vchiq_arm: Replace variable ret with status Stefan Wahren
2024-06-05  6:51   ` Laurent Pinchart
2024-06-05 10:04     ` Stefan Wahren
2024-06-04 17:28 ` [PATCH 02/11] staging: vchiq_arm: Drop obsolete comment Stefan Wahren
2024-06-05  6:52   ` Laurent Pinchart
2024-06-05 10:02     ` Stefan Wahren
2024-06-05 10:32       ` Dan Carpenter
2024-06-04 17:28 ` [PATCH 03/11] staging: vchiq_core: Drop non-functional struct members Stefan Wahren
2024-06-05  7:00   ` Laurent Pinchart
2024-06-04 17:28 ` [PATCH 04/11] staging: vchiq_arm: Drop unnecessary declarations Stefan Wahren
2024-06-05  7:02   ` Laurent Pinchart [this message]
2024-06-04 17:28 ` [PATCH 05/11] staging: vchiq_arm: Get the rid off struct vchiq_2835_state Stefan Wahren
2024-06-05  7:11   ` Laurent Pinchart
2024-06-05 10:11     ` Stefan Wahren
2024-06-11 21:22       ` Laurent Pinchart
2024-06-12  5:12         ` Stefan Wahren
2024-06-04 17:28 ` [PATCH 06/11] staging: vchiq_arm: Drop vchiq_arm_init_state Stefan Wahren
2024-06-05  7:08   ` Laurent Pinchart
2024-06-04 17:29 ` [PATCH 07/11] staging: vchiq_arm: Reduce indentation of service_callback Stefan Wahren
2024-06-05  7:07   ` Laurent Pinchart
2024-06-04 17:29 ` [PATCH 08/11] staging: vchiq_core: Add comments to mutex/spinlocks Stefan Wahren
2024-06-05  7:10   ` Laurent Pinchart
2024-06-04 17:29 ` [PATCH 09/11] staging: vchiq: Move struct vchiq_config to vchiq.h Stefan Wahren
2024-06-05  7:16   ` Laurent Pinchart
2024-06-05 10:15     ` Stefan Wahren
2024-06-04 17:29 ` [PATCH 10/11] staging: vchiq_core: Add hex prefix to debugfs output Stefan Wahren
2024-06-05  7:12   ` Laurent Pinchart
2024-06-04 17:29 ` [PATCH 11/11] staging: vc04_services: Update testing instructions Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605070214.GF879@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=umang.jain@ideasonboard.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).