From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E39AC25B76 for ; Wed, 5 Jun 2024 07:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ncFy9TTf8Y8prjy4DkMKepg/KxnX0pVTBPBgGHsTnFI=; b=fla3umM1gPER0/ Jw6oAvYeXznrFbRHuaIi0ZVzfM+QzwKjC93jipvob7SVbh5uOtoAa3iMwIQEM28KBTihjQ6U2FFHa yFFPO4TNuhrILkW8XUR/Y2POZtZH1VtdwyIyt9k3QrSTVyUxnPDryk05nu5gWgbeMUZ7u7cEV7ImK bxTIjW3i8L6DL6G76nWu11xR3dFzMnuQ0h0FAvG11vBcs4M0eV1ct2J0NaQK1lHXxKE0hBNFdlKVp i3+29bWPMKgqCNSuQqX/ufPhM9ESOjYv/jCWBcVlRAueMW3FwzI9+7+zyzKbPzyrne4PtU16ZzFmF m7dbSmi70OBHUscSV4zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEksy-00000004xXN-34yn; Wed, 05 Jun 2024 07:16:40 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEksv-00000004xW5-3cyo for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 07:16:39 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 29DA2BEB; Wed, 5 Jun 2024 09:16:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717571788; bh=1ESLAowMP1JRP9ka+WuhpLYX0ZkJUOoxoJbrwEM2aKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c1TwfO/GAax7ct/52TTuN9exPeul25B1Cqi+Od6+JdFO1ijmlejuny4Fm/O7hqlGC Cn9jw2WDFKlDPqZBcx2wyKysk81Wq4jHilK/Y1lf6U+9VDM3SRr+EIrFf2r+H16VPE 41xVYv0DRgj/VrevZ3NJ5oED+ahOOHMMwgjr+3Ts= Date: Wed, 5 Jun 2024 10:16:19 +0300 From: Laurent Pinchart To: Stefan Wahren Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/11] staging: vchiq: Move struct vchiq_config to vchiq.h Message-ID: <20240605071619.GI879@pendragon.ideasonboard.com> References: <20240604172904.61613-1-wahrenst@gmx.net> <20240604172904.61613-10-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240604172904.61613-10-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_001638_112209_E6D5A05E X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Thank you for the patch. On Tue, Jun 04, 2024 at 07:29:02PM +0200, Stefan Wahren wrote: > This struct is part of the VCHIQ userspace API, which we > don't want to break. So move the struct definition to > vchiq.h, which contains the rest of the userspace API. Dies it ? vchiq.h contains lots of kernel API elements. Beside, we have headers such as vc04_services/interface/vchiq_arm/vchiq_ioctl.h that contain UAPI elements. Splitting the UAPI to separate headers is a good idea. Could you address that task as a whole, and create a drivers/staging/vc04_services/include/uapi/linux/raspberrypi/vchiq.h file for the whole UAPI ? > Signed-off-by: Stefan Wahren > --- > .../vc04_services/include/linux/raspberrypi/vchiq.h | 12 ++++++++++++ > .../vc04_services/interface/vchiq_arm/vchiq_core.h | 12 ------------ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > index 6c40d8c1dde6..2e34c67966c6 100644 > --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > @@ -79,6 +79,18 @@ struct vchiq_service_params_kernel { > short version_min; /* Update for incompatible changes */ > }; > > +struct vchiq_config { > + unsigned int max_msg_size; > + unsigned int bulk_threshold; /* The message size above which it > + * is better to use a bulk transfer > + * (<= max_msg_size) > + */ > + unsigned int max_outstanding_bulks; > + unsigned int max_services; > + short version; /* The version of VCHIQ */ > + short version_min; /* The minimum compatible version of VCHIQ */ > +}; > + > extern int vchiq_initialise(struct vchiq_state *state, > struct vchiq_instance **pinstance); > extern int vchiq_shutdown(struct vchiq_instance *instance); > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > index 3abcd6910f25..a83f9a5d478f 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > @@ -423,18 +423,6 @@ struct bulk_waiter { > int actual; > }; > > -struct vchiq_config { > - unsigned int max_msg_size; > - unsigned int bulk_threshold; /* The message size above which it > - * is better to use a bulk transfer > - * (<= max_msg_size) > - */ > - unsigned int max_outstanding_bulks; > - unsigned int max_services; > - short version; /* The version of VCHIQ */ > - short version_min; /* The minimum compatible version of VCHIQ */ > -}; > - > extern spinlock_t bulk_waiter_spinlock; > > extern const char * -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel