Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

From: Francesco Dolcini <francesco@dolcini.it>
To: Jai Luthra <j-luthra@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jayesh Choudhary <j-choudhary@ti.com>,
	Devarsh Thakkar <devarsht@ti.com>, Bryan Brattlof <bb@ti.com>,
	Aradhya Bhatia <a-bhatia1@ti.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs
Date: Wed, 5 Jun 2024 10:47:13 +0200	[thread overview]
Message-ID: <20240605084713.GA10711@francesco-nb> (raw)
In-Reply-To: <20240604-mcasp_fifo_drop-v1-5-03ebe25f47db@ti.com>

Hello Jai, thanks for the patch.

On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote:
> McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
> on the DMA IP. Drop these for better audio latency.
> 
> Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> index 2038c5e04639..27e5220e1dc7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> @@ -1364,8 +1364,8 @@ &mcasp0 {
>  	       0 0 0 0
>  	>;
>  	tdm-slots = <2>;
> -	rx-num-evt = <32>;
> -	tx-num-evt = <32>;
> +	rx-num-evt = <0>;
> +	tx-num-evt = <0>;

From my understanding of the dt-binding having these properties set to
<0> is equivalent to not having those properties at all.
My suggestion would be to just remove those, therefore.

With that said, in any case, whatever you do my suggested change or not,

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel