From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D029C25B76 for ; Wed, 5 Jun 2024 08:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zs3uX8M4yBiJyvHVMVbT2nfiQOnBuofbMgbSE2La/Jo=; b=N7SvJWZQUcBaAm Ah1WDzQcuqAbA3FA6tFpteVYlDpFuYd3A4roXJFNZ152wzu7SIG5dx8eXa/GVpOerbW6JsAx9NOqU Y+wQFtdD83UZ3gFGb+7IUqF8EhtUjwTBXZtHBcotUMffaw7S0gShsizIvzxCo58xm7O4o5JdUKWgO MZ9B6SbsbApUKMn6+foxTCFNe3JJ/wlZ0Y14QAlI8DAa9zg6VnebQDtJutEIToZdNu5vDzeMIMWyw 6UNOnrJ3jb/dSt4fwMWH9bkhvqBh9xbfBGI6SyvGBoT4qrqTwyfJNBD+qibZ1xoAG26GQpmidDuy4 6J3LhFvrwsJAehZx3C6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEmIr-00000005HV8-2Uiy; Wed, 05 Jun 2024 08:47:29 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEmIn-00000005HUC-1zCX for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 08:47:28 +0000 Received: from francesco-nb (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 2E8A81F843; Wed, 5 Jun 2024 10:47:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1717577238; bh=xPg8iIOPgRxEgj4VlXJ9uIv+R1QzFM1fm/iyzjcKhGM=; h=From:To:Subject; b=GnFpXb4suv0I34y+fusFjIRa4zEQhy90oZ8X9PW0JFkdG/qB/iHXx7LYd5cw+Qyd8 I6/c5dcJy+HipSgJvIciXP5mBIzIxju5l8EtXZFN+TrI1r8izHRfT2peypRPZCXUAB d4BC/pl8RlLldypZ9P4/sauTGkGLdNKaFZI1yAPVSIYAoaHosUdH4QlhohUYrgZ4hL PYL28TV+ULlp4TNwPPikerVtYMCu44ezRrRFWe9i1ihWtEE8HRlbp8hXuQPx+P1ORP kVnjugBfGf09shuYIDEXxhOlbystfYI5JZcrNaixTF4ReEvG5UW5nviP8s2U8ylv1y c5LALiRZ52r+Q== Date: Wed, 5 Jun 2024 10:47:13 +0200 From: Francesco Dolcini To: Jai Luthra Cc: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary , Devarsh Thakkar , Bryan Brattlof , Aradhya Bhatia , Francesco Dolcini , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs Message-ID: <20240605084713.GA10711@francesco-nb> References: <20240604-mcasp_fifo_drop-v1-0-03ebe25f47db@ti.com> <20240604-mcasp_fifo_drop-v1-5-03ebe25f47db@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240604-mcasp_fifo_drop-v1-5-03ebe25f47db@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_014726_444448_395FC13B X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Jai, thanks for the patch. On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote: > McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering > on the DMA IP. Drop these for better audio latency. > > Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62") > Signed-off-by: Jai Luthra > --- > arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > index 2038c5e04639..27e5220e1dc7 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > @@ -1364,8 +1364,8 @@ &mcasp0 { > 0 0 0 0 > >; > tdm-slots = <2>; > - rx-num-evt = <32>; > - tx-num-evt = <32>; > + rx-num-evt = <0>; > + tx-num-evt = <0>; >From my understanding of the dt-binding having these properties set to <0> is equivalent to not having those properties at all. My suggestion would be to just remove those, therefore. With that said, in any case, whatever you do my suggested change or not, Acked-by: Francesco Dolcini Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel