From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB09C27C53 for ; Wed, 5 Jun 2024 12:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LpqiT7dN6a112OVwpmchNhZMU371xQAgdrZAz21RSGg=; b=udIJX4JYznnRRT OwWGZWoTIk+qbOgBuQ8fdg9ehd7d4+IoFyUi+HeWpEjh5rTa7VioX7kpAvUWun6hCZCiIA71nxdhB cp+szF+jVUqVz7DHIt2FaAz5JC7ZlkxI/IFZJuhfK9516yNfvNbbuyUw5/0NgwDOUlLUR8C6GLfw2 Jy1G2mP2Vrp7xARZzn/yOtylnpyIejjGdymBOAviDkEyyjOnhq2EaYGqzdzU5MVlEBDL4kQ7op1xv vE5NJnwfL/zjM1gFN1M04pNtx0+tHslk69PQcJMrf07K21Q+nDBc+yR2DpMU/GboP7i36ODJwXuz9 cNgXJDrK3+rerKw/hfgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEq8C-000000066Yi-160D; Wed, 05 Jun 2024 12:52:44 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEq89-000000066Xf-1T3w for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 12:52:42 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 455CqXsp119194; Wed, 5 Jun 2024 07:52:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1717591953; bh=PZVe92Rj78eN1DbQzLm0zMnQYFdOj9DVODRU7I5SMuI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=WnB4isZmCxppFWtKWywfN/vCtH+mz0z5CKJINTCZX98cDRGKHU02w0GCW3z28rBxL FBXA6rREkk1Gv5vLQJ/ymxZ0RXrD3/6KkbgUOv3y8KMud+gfBHTmIXDKKMYuejAhVX 2v4mDVxw8GXNNJrIg+bRz+MLxrbhqCX62U5IhOa4= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 455CqXlP113459 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Jun 2024 07:52:33 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 5 Jun 2024 07:52:32 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 5 Jun 2024 07:52:32 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 455CqWSL115373; Wed, 5 Jun 2024 07:52:32 -0500 Date: Wed, 5 Jun 2024 07:52:32 -0500 From: Nishanth Menon To: Jai Luthra CC: Francesco Dolcini , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary , Devarsh Thakkar , Bryan Brattlof , Aradhya Bhatia , Francesco Dolcini , , , Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs Message-ID: <20240605125232.5xql5nonllyslchc@saucy> References: <20240604-mcasp_fifo_drop-v1-0-03ebe25f47db@ti.com> <20240604-mcasp_fifo_drop-v1-5-03ebe25f47db@ti.com> <20240605084713.GA10711@francesco-nb> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_055241_513630_759281DC X-CRM114-Status: GOOD ( 26.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14:28-20240605, Jai Luthra wrote: > Hi Francesco, > > Thanks for the review. > > On Jun 05, 2024 at 10:47:13 +0200, Francesco Dolcini wrote: > > Hello Jai, thanks for the patch. > > > > On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote: > > > McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering > > > on the DMA IP. Drop these for better audio latency. > > > > > > Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62") > > > Signed-off-by: Jai Luthra > > > --- > > > arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > > > index 2038c5e04639..27e5220e1dc7 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > > > @@ -1364,8 +1364,8 @@ &mcasp0 { > > > 0 0 0 0 > > > >; > > > tdm-slots = <2>; > > > - rx-num-evt = <32>; > > > - tx-num-evt = <32>; > > > + rx-num-evt = <0>; > > > + tx-num-evt = <0>; > > > > From my understanding of the dt-binding having these properties set to > > <0> is equivalent to not having those properties at all. > > My suggestion would be to just remove those, therefore. > > > > I was following the existing convention of setting it to 0 for > disabling, as done in k3-j721e-common-proc-board.dts > > IMO it is better to keep it explicit, but I don't feel strongly against > dropping it either (as long as we do the same for j721e). Will defer the > decision to the tree maintainers. > If they are equivalent, then just drop them. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel