From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69B4DC25B75 for ; Thu, 6 Jun 2024 03:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DpIV9eMArDFnv4AEZZHycPnPzk1+atkj/WKvuaTU0kg=; b=QIHVoDeNsT0SyE nUmwcvcBTplIwXv4LFJMWFBinWJBshr87katOaxysRYAib2FWuvEMHYclhxLJGfoIcyDu404KMosV q7qw4oKiokW3V1QDxbe5GOj47vQkWwYif/O4wBVFfBsVhCpMvTD2U2y5mzzBdN9RLtVua/KLtZciq fzQfdkI9qVtNeRKk0gw/dXw1p1Q9IFsR9T53w1mGjWbNMPtPbpp0IjDAbbdAJYBDCh/9+mz4gcg5U LVey8oC1ahPr/YvlZTeexYFe/toEligwPixVDdloBQhS3h42WlGeSVH+otVy3BuvHnHMT+LRT8+IG KOpkv5CiLScbDU1Re1xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF3Wn-00000008D8F-0nIi; Thu, 06 Jun 2024 03:11:01 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF3Wj-00000008D7m-3R8f for linux-arm-kernel@lists.infradead.org; Thu, 06 Jun 2024 03:10:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 19B55CE1A13; Thu, 6 Jun 2024 03:10:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09BB0C2BD10; Thu, 6 Jun 2024 03:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717643427; bh=fSvKb4xL6usgTVuwwJWrOkwMNU8N0nfeCoolR2MrPTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lq5z6O63dxZ5+bq+0SKBYgIvQEerPq0sxsgeOUmRamuruvYnh+Fj4TGn5tdmqwD3l UA/LQKEkuTeQfrItj4/U1BuLgja1sSW2u0Elx2GECM/sAAmR6FICsjkWT5pC1uC+qD 192+/L+RMwcxAAYgbGuMFTteZa0V08FhW+OSQfdiAFx/mmaBRNCrqMO6S2qRJYmi1V ddM6kQGVGLiRIEQfO2srA/o4HEdo4wX2HiI3al12yAB5n7z4eGFwI0V6yf7ZVQZqfv nvpRRvGnT8KCz3jO2kFUECm3qvFyWUgyFffxdsMKmWwSWCBMRfDH/W/Zs/YqnMNmx/ JNdHIciVii+CQ== Date: Wed, 5 Jun 2024 20:10:25 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Message-ID: <20240605201025.764f0881@kernel.org> In-Reply-To: <20240605124920.720690-4-maxime.chevallier@bootlin.com> References: <20240605124920.720690-1-maxime.chevallier@bootlin.com> <20240605124920.720690-4-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_201058_063065_33ACA4A2 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote: > +/** > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY > + * @upstream: pointer to the upstream phy device > + * @phy: pointer to the SFP module's phy device > + * > + * This helper allows keeping track of PHY devices on the link. It adds the > + * SFP module's phy to the phy namespace of the upstream phy > + */ > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy) We run scripts/kernel-doc with -Wall now, it wants return values to be documented, too. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel