From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83BC7C27C53 for ; Wed, 5 Jun 2024 23:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gEERzQTw2sE32RP40A9zIA7gsMrcDhzpjZNT323qTLk=; b=E+0VdJ+noObbsr V+n0rbXoR8lEBLTqrhiWNJNz2LqVTfr//fs6b010rpfBZtyMa26wpz2aUdwyJI80+UpIfe3JLHOe2 qdiF6EhSZVR9Z9swzJ81K9H8rNN1VQP0XmtxP5xMBecsHuJuk+UmNyHauLgETUdRtqe3WHL4DHCbV SseImgSWgUQorEq2p50r+PBnTSqmJE3arSS0tF903N/QUAZzS7m4e9RzsVJsjD2WKGVkywWJ0K322 iiQ4jph4X5eFuXn2ABkE8IlGRU7LNsbmy4dKvXo61lANjR1opA0zLEZR+/EVkxqutHVi6cSpoJaT9 9dVyaLYp86tLXm3f3OCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEzxO-00000007pPm-2XF4; Wed, 05 Jun 2024 23:22:14 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEzxM-00000007pPD-0r14; Wed, 05 Jun 2024 23:22:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 56599CE19F5; Wed, 5 Jun 2024 23:22:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19C6EC2BD11; Wed, 5 Jun 2024 23:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717629729; bh=XPL0NllaL6Uk5BD+SwKrbhuEPF/y1e3rhDVOFvsQHDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bGZZ8HD8FzultabdV9ttkxSlLITCB/QG9WzPaX++/yLnA77h+G+615QE2Wdt66b48 Pxft1zXv5mYubfihiQkrhajbx7IgMspSqSD8zpZ0E5T9NyDUxIIWixWCmfSbFQQAOB PNxnV7mc+knvx5GBCZ250i7RdJDJiDBCUoldzdGpGv5Rqp1A12OJfINdghMfEzlAJW hrsxDwBxYGUrjISiB62yk6v9IXzQR/9WbD8/KeCNCjjZEwLFgQvzG+kQmb9uo04YHr 8hYralA8y1witEvspIpNIjJYemqgA8FYigJzBLOm09h8OvY5I6HP2DVqHkfpDd9GP0 LMt0DSVKLePgQ== Date: Wed, 5 Jun 2024 17:22:06 -0600 From: Rob Herring To: Cristian Ciocaltea Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Krzysztof Kozlowski , Conor Dooley , Mark Yao , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer Subject: Re: [PATCH 12/14] dt-bindings: display: rockchip,dw-hdmi: Add compatible for RK3588 Message-ID: <20240605232206.GA3345910-robh@kernel.org> References: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> <20240601-b4-rk3588-bridge-upstream-v1-12-f6203753232b@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240601-b4-rk3588-bridge-upstream-v1-12-f6203753232b@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_162212_976653_AF2CCA55 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 01, 2024 at 04:12:34PM +0300, Cristian Ciocaltea wrote: > Document the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller > found on Rockchip RK3588 SoC family. > > Since RK3588 uses different clocks than previous Rockchip SoCs and also > requires a couple of reset lines and some additional properties, provide > the required changes in the binding to accommodate all variants. > > Signed-off-by: Cristian Ciocaltea > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 127 +++++++++++++++------ > 1 file changed, 90 insertions(+), 37 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 2aac62219ff6..60d6b815227f 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -10,12 +10,10 @@ maintainers: > - Mark Yao > > description: | > - The HDMI transmitter is a Synopsys DesignWare HDMI 1.4 TX controller IP > - with a companion PHY IP. > - > -allOf: > - - $ref: ../bridge/synopsys,dw-hdmi.yaml# > - - $ref: /schemas/sound/dai-common.yaml# > + For SoCs up to RK3568, the HDMI transmitter is a Synopsys DesignWare > + HDMI 1.4 TX controller IP with a companion PHY IP. > + The RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) > + TX controller IP and a HDMI/eDP TX Combo PHY based on a Samsung IP block. > > properties: > compatible: > @@ -25,6 +23,7 @@ properties: > - rockchip,rk3328-dw-hdmi > - rockchip,rk3399-dw-hdmi > - rockchip,rk3568-dw-hdmi > + - rockchip,rk3588-dw-hdmi > > reg-io-width: > const: 4 > @@ -40,36 +39,6 @@ properties: > A 1.8V supply that powers up the SoC internal circuitry. The pin name on the > SoC usually is HDMI_TX_AVDD_1V8. > > - clocks: > - minItems: 2 > - items: > - - {} > - - {} > - # The next three clocks are all optional, but shall be specified in this > - # order when present. > - - description: The HDMI CEC controller main clock > - - description: Power for GRF IO > - - description: External clock for some HDMI PHY (old clock name, deprecated) > - - description: External clock for some HDMI PHY (new name) > - > - clock-names: > - minItems: 2 > - items: > - - {} > - - {} > - - enum: > - - cec > - - grf > - - vpll > - - ref > - - enum: > - - grf > - - vpll > - - ref > - - enum: > - - vpll > - - ref > - > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -131,13 +100,97 @@ properties: > required: > - compatible > - reg > - - reg-io-width > - clocks > - clock-names > - interrupts > - ports > - rockchip,grf > > +allOf: > + - $ref: /schemas/sound/dai-common.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3588-dw-hdmi > + then: > + properties: > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + items: > + - description: APB system interface clock > + # The next clocks are optional, but shall be specified in this > + # order when present. > + - description: TMDS/FRL link clock > + - description: EARC RX biphase clock > + - description: Reference clock > + - description: Audio interface clock > + - description: Video datapath clock > + > + clock-names: > + minItems: 1 > + items: > + - const: pclk > + - enum: [hdp, earc, ref, aud, hclk_vo1] > + - enum: [earc, ref, aud, hclk_vo1] > + - enum: [ref, aud, hclk_vo1] > + - enum: [aud, hclk_vo1] > + - const: hclk_vo1 > + > + resets: > + minItems: 2 > + maxItems: 2 > + > + reset-names: > + items: > + - const: ref > + - const: hdp > + > + interrupts: > + minItems: 1 > + maxItems: 5 > + > + rockchip,vo1_grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Some QP related data is accessed through VO1 GRF regs > + > + required: > + - resets > + - reset-names > + - rockchip,vo1_grf > + > + else: > + $ref: ../bridge/synopsys,dw-hdmi.yaml# This is odd... With this plus the amount of conditional schema, I think this should be a new schema doc. Doesn't have to have a common schema. You can let the 2nd user of this IP block do that. Though if you have the Synopsys spec, then it would be good to use it and be sure the binding corresponds to it. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel