From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B70FC27C52 for ; Thu, 6 Jun 2024 06:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=05xKA9wgALnHcijy3qxGvkmzEhByp5biwR2ZBDu7TD4=; b=i0c4rVjzN9RQ48 EnJRvMiRlNxDbGEqRG2rjDyLNuX1rz00pO3GK62nfqbXZ6lZPU9+iAxR7UhZpu82SRpFvi64c/Qxg IQ5HS77x+IolIo6K33VCaJrtdcflz9xSkoVC4+CUY98nPOr9Vq9kDx/pDI1z7MX/2jylcFU+NLuTF MlcK24j49pLoje8jkrvnwBKI0f3sqd16XDuSdepeAT1OL1I306X4hj+3cYqf89jldEU47Z8SJQfWg WJngh5aBiMMlYnGQsxD6uuTKWCKeRviD8e3NWtPRRwTFUjGXTXe3nOhKA29R6sgDUw+NkY0Ev6qVz vAfQZE6O+DxD4QU1+xpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF74F-00000008b8y-2PhW; Thu, 06 Jun 2024 06:57:47 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF74C-00000008b8F-0Ebl for linux-arm-kernel@lists.infradead.org; Thu, 06 Jun 2024 06:57:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 30F6260004; Thu, 6 Jun 2024 06:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717657058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgXWC6wrNxd7gBlX7Te69IijPU34lb7hb+iH3eHJsXo=; b=FIiZKxzzXuNWsWWUYEG9s1CHkdsJ69grzzhE1fJ75F9v5Ys2AuTSJdmoZO8Y7ExIAi0H9x D7UkSWOFwA5rcZ7uWjBFfyGHig5jG7cQkHEgVF9D0HIx2rFvJwWbgMivF7E88KuUExUAjK NVMGD+56L+Kkf3V0kw9e4YOZsvxoM4Qb/5J5gGmRyZmWl7vhLykq8me+cy7ve4kOYVt94T g82by/PcFlITDibCU0R6X8ywwCLUckU9bhKGGLdTSMP2xPaUR8hVa1Bo1rsBF2jx8CSVwt VWWMzrjSUKAYq1FQv6cuM6KZOxq3j2Zfkpk/bNnAYHJnLOjDDDP5f4uz4LYtBw== Date: Thu, 6 Jun 2024 08:57:34 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Message-ID: <20240606085734.73334c68@fedora> In-Reply-To: <20240605201025.764f0881@kernel.org> References: <20240605124920.720690-1-maxime.chevallier@bootlin.com> <20240605124920.720690-4-maxime.chevallier@bootlin.com> <20240605201025.764f0881@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_235744_411221_1AC5240A X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Jakub, On Wed, 5 Jun 2024 20:10:25 -0700 Jakub Kicinski wrote: > On Wed, 5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote: > > +/** > > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY > > + * @upstream: pointer to the upstream phy device > > + * @phy: pointer to the SFP module's phy device > > + * > > + * This helper allows keeping track of PHY devices on the link. It adds the > > + * SFP module's phy to the phy namespace of the upstream phy > > + */ > > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy) > > We run scripts/kernel-doc with -Wall now, it wants return values > to be documented, too. OK, I'll address that and make sure to run this script on all the patches in the series. Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel