Re: [PATCH v6 3/7] dt-bindings: iio: adc: ti,ads1015: add compatible for tla2021

From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Josua Mayer <josua@solid-run.com>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Konstantin Porotchkin <kostap@marvell.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-phy@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 3/7] dt-bindings: iio: adc: ti,ads1015: add compatible for tla2021
Date: Fri, 7 Jun 2024 15:40:39 +0100	[thread overview]
Message-ID: <20240607-extended-unseated-33ee0e5c7825@spud> (raw)
In-Reply-To: <20240606211222.3b0f7a01@jic23-huawei>

[-- Attachment #1.1: Type: text/plain, Size: 1174 bytes --]

On Thu, Jun 06, 2024 at 09:12:22PM +0100, Jonathan Cameron wrote:
> On Tue, 4 Jun 2024 18:42:46 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> > > TI tla2021 is a limited single-channel variant of tla2024 which is
> > > similar enough to be easily supportable through the same driver.
> > > 
> > > Add compatible string for tla2021 so boards may describe it in
> > > device-tree.
> > > 
> > > Signed-off-by: Josua Mayer <josua@solid-run.com>  
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> This binding has per channel descriptions. Perhaps for this device
> it should be updated to include a restriction on number of
> such sub nodes (probably via the reg value in them) ?

Oh yeah, it probably should be, using an enum of permitted values.

> Mind you it's currently 8 and the ti,tla2024 only has 4.
> So a possible job for another day, hopefully alongside the
> driver support and the tla2022 which seems to be the 2 channel
> version.

Or a follow-up from Josua if they want, don't think it'd be too hard
to add restrictions for these two tla devices.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel